Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436945 > unrolled thread
| Started by | Seung-Woo Kim <sw0312.kim@samsung.com> |
|---|---|
| First post | 2016-07-05 13:50 +0200 |
| Last post | 2016-07-06 08:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] memory: samsung: exynos-srom: fix wrong count of registers Seung-Woo Kim <sw0312.kim@samsung.com> - 2016-07-05 13:50 +0200
Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-06 02:20 +0200
Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-06 08:20 +0200
| From | Seung-Woo Kim <sw0312.kim@samsung.com> |
|---|---|
| Date | 2016-07-05 13:50 +0200 |
| Subject | [PATCH] memory: samsung: exynos-srom: fix wrong count of registers |
| Message-ID | <rRx1w-2fg-7@gated-at.bofh.it> |
This patch fixes wrong count of array for srom registers from probe
function.
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
drivers/memory/samsung/exynos-srom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
index 96756fb..c66d2bd 100644
--- a/drivers/memory/samsung/exynos-srom.c
+++ b/drivers/memory/samsung/exynos-srom.c
@@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, srom);
srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
- sizeof(exynos_srom_offsets));
+ ARRAY_SIZE(exynos_srom_offsets));
if (!srom->reg_offset) {
iounmap(srom->reg_base);
return -ENOMEM;
--
1.7.9.5
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-07-06 02:20 +0200 |
| Message-ID | <rRIJk-1Ki-7@gated-at.bofh.it> |
| In reply to | #1436945 |
On 2016년 07월 05일 20:40, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/memory/samsung/exynos-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index 96756fb..c66d2bd 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, srom);
>
> srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
> - sizeof(exynos_srom_offsets));
> + ARRAY_SIZE(exynos_srom_offsets));
> if (!srom->reg_offset) {
> iounmap(srom->reg_base);
> return -ENOMEM;
>
On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry.
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-07-06 08:20 +0200 |
| Message-ID | <rROlI-5yI-13@gated-at.bofh.it> |
| In reply to | #1436945 |
On 07/05/2016 01:40 PM, Seung-Woo Kim wrote: > This patch fixes wrong count of array for srom registers from probe > function. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > drivers/memory/samsung/exynos-srom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web