Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437384 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2016-07-06 05:00 +0200 |
| Last post | 2016-07-06 16:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool kbuild test robot <fengguang.wu@intel.com> - 2016-07-06 05:00 +0200
[PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2016-07-06 05:00 +0200
Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings Marek Lindner <mareklindner@neomailbox.ch> - 2016-07-06 16:10 +0200
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2016-07-06 05:00 +0200 |
| Subject | net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool |
| Message-ID | <rRLe9-3nf-5@gated-at.bofh.it> |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a99cde438de0c4c0cecc1d1af1a55a75b10bfdef commit: 4b426b108ac82b27f5af40df7da05a2501fd2aca batman-adv: Use bool as return type for boolean functions date: 8 weeks ago coccinelle warnings: (new ones prefixed by >>) >> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [next] | [standalone]
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2016-07-06 05:00 +0200 |
| Subject | [PATCH] batman-adv: fix boolreturn.cocci warnings |
| Message-ID | <rRLe9-3nf-15@gated-at.bofh.it> |
| In reply to | #1437384 |
net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Sven Eckelmann <sven@narfation.org> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- bridge_loop_avoidance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c @@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str /* Let the loopdetect frames on the mesh in any case. */ if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT) - return 0; + return false; /* check if it is a claim frame. */ ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,
[toc] | [prev] | [next] | [standalone]
| From | Marek Lindner <mareklindner@neomailbox.ch> |
|---|---|
| Date | 2016-07-06 16:10 +0200 |
| Subject | Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings |
| Message-ID | <rRVGx-1Ml-1@gated-at.bofh.it> |
| In reply to | #1437386 |
[Multipart message — attachments visible in raw view] — view raw
On Wednesday, July 06, 2016 10:49:29 kbuild test robot wrote: > net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in > function 'batadv_bla_process_claim' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > CC: Sven Eckelmann <sven@narfation.org> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > bridge_loop_avoidance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied in revision 36e7316. Thanks, Marek
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web