Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436449 > unrolled thread
| Started by | Martin Kepplinger <martink@posteo.de> |
|---|---|
| First post | 2016-07-04 14:30 +0200 |
| Last post | 2016-07-06 16:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements Martin Kepplinger <martink@posteo.de> - 2016-07-04 14:30 +0200
Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements Jonathan Cameron <jic23@kernel.org> - 2016-07-05 22:10 +0200
Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements Martin Kepplinger <martink@posteo.de> - 2016-07-06 16:20 +0200
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2016-07-04 14:30 +0200 |
| Subject | Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements |
| Message-ID | <rRbaG-5yi-29@gated-at.bofh.it> |
Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil: > Removed unwanted return statements from the function > mma8452_set_freefall_mode. You could've said "Don't unnecessarily save a return value.", but whatever :) Thanks for your review! > > Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com> Reviewed-by: Martin Kepplinger <martink@posteo.de> > --- > drivers/iio/accel/mma8452.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index e225d3c..d4a6d44 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state) > val |= MMA8452_FF_MT_CFG_OAE; > } > > - val = mma8452_change_config(data, chip->ev_cfg, val); > - if (val) > - return val; > - > - return 0; > + return mma8452_change_config(data, chip->ev_cfg, val); > } > > static int mma8452_set_hp_filter_frequency(struct mma8452_data *data, >
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-07-05 22:10 +0200 |
| Message-ID | <rREPo-7zl-7@gated-at.bofh.it> |
| In reply to | #1436449 |
On 04/07/16 13:23, Martin Kepplinger wrote: > Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil: >> Removed unwanted return statements from the function >> mma8452_set_freefall_mode. > > You could've said "Don't unnecessarily save a return value.", but > whatever :) Thanks for your review! > >> >> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com> > Reviewed-by: Martin Kepplinger <martink@posteo.de> Hi Martin, I've flipped that tag over to an Acked-by which is more appropriate in this case as an in depth review as signalled by Reviewed-by would be 'interesting' here ;) I'm enjoying the slightly doom laden commit messages :) Applied. Jonathan > >> --- >> drivers/iio/accel/mma8452.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c >> index e225d3c..d4a6d44 100644 >> --- a/drivers/iio/accel/mma8452.c >> +++ b/drivers/iio/accel/mma8452.c >> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state) >> val |= MMA8452_FF_MT_CFG_OAE; >> } >> >> - val = mma8452_change_config(data, chip->ev_cfg, val); >> - if (val) >> - return val; >> - >> - return 0; >> + return mma8452_change_config(data, chip->ev_cfg, val); >> } >> >> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data, >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [next] | [standalone]
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2016-07-06 16:20 +0200 |
| Message-ID | <rRVQd-1PF-21@gated-at.bofh.it> |
| In reply to | #1437252 |
Am 2016-07-05 um 22:04 schrieb Jonathan Cameron: > On 04/07/16 13:23, Martin Kepplinger wrote: >> Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil: >>> Removed unwanted return statements from the function >>> mma8452_set_freefall_mode. >> >> You could've said "Don't unnecessarily save a return value.", but >> whatever :) Thanks for your review! >> >>> >>> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com> >> Reviewed-by: Martin Kepplinger <martink@posteo.de> > Hi Martin, > > I've flipped that tag over to an Acked-by which is more > appropriate in this case as an in depth review as signalled > by Reviewed-by would be 'interesting' here ;) Sure, thanks! > > I'm enjoying the slightly doom laden commit messages :) > > Applied. > > Jonathan >> >>> --- >>> drivers/iio/accel/mma8452.c | 6 +----- >>> 1 file changed, 1 insertion(+), 5 deletions(-) >>> >>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c >>> index e225d3c..d4a6d44 100644 >>> --- a/drivers/iio/accel/mma8452.c >>> +++ b/drivers/iio/accel/mma8452.c >>> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state) >>> val |= MMA8452_FF_MT_CFG_OAE; >>> } >>> >>> - val = mma8452_change_config(data, chip->ev_cfg, val); >>> - if (val) >>> - return val; >>> - >>> - return 0; >>> + return mma8452_change_config(data, chip->ev_cfg, val); >>> } >>> >>> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data, >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web