Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1435175 > unrolled thread

[Patch v002] gcov: Added support for >=gcc-6

Started byFlorian Meier <Florian.Meier@informatik.uni-erlangen.de>
First post2016-07-01 11:10 +0200
Last post2016-07-04 10:20 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [Patch v002] gcov: Added support for >=gcc-6 Florian Meier <Florian.Meier@informatik.uni-erlangen.de> - 2016-07-01 11:10 +0200
    Re: [Patch v002] gcov: Added support for >=gcc-6 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> - 2016-07-01 13:00 +0200
      [PATCH v003] Added support for gcc version >= 6 Florian Meier <Florian.Meier@informatik.uni-erlangen.de> - 2016-07-01 15:30 +0200
        Re: [PATCH v003] Added support for gcc version >= 6 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> - 2016-07-01 17:50 +0200
        Re: [PATCH v003] Added support for gcc version >= 6 Joe Perches <joe@perches.com> - 2016-07-01 18:30 +0200
          Re: [PATCH v003] Added support for gcc version >= 6 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> - 2016-07-04 09:50 +0200
            Re: [PATCH v003] Added support for gcc version >= 6 Florian Meier <Florian.Meier@informatik.uni-erlangen.de> - 2016-07-04 10:00 +0200
              [PATCH v004] gcov: Added support for gcc version >= 6 Florian Meier <Florian.Meier@informatik.uni-erlangen.de> - 2016-07-04 10:20 +0200

#1435175 — [Patch v002] gcov: Added support for >=gcc-6

FromFlorian Meier <Florian.Meier@informatik.uni-erlangen.de>
Date2016-07-01 11:10 +0200
Subject[Patch v002] gcov: Added support for >=gcc-6
Message-ID<rQ2Ct-4KR-5@gated-at.bofh.it>
Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
 kernel/gcov/gcc_4_7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
 #include <linux/vmalloc.h>
 #include "gcov.h"

-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
 #define GCOV_COUNTERS 10
 #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
 #define GCOV_COUNTERS 9
-- 
2.9.0

[toc] | [next] | [standalone]

#1435255

FromPeter Oberparleiter <oberpar@linux.vnet.ibm.com>
Date2016-07-01 13:00 +0200
Message-ID<rQ4kV-5Ci-5@gated-at.bofh.it>
In reply to#1435175
On 01.07.2016 11:06, Florian Meier wrote:
> Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
> ---
>  kernel/gcov/gcc_4_7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index e25e92f..6a5c239 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,7 @@
>  #include <linux/vmalloc.h>
>  #include "gcov.h"
> 
> -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
> +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
>  #define GCOV_COUNTERS 10
>  #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
>  #define GCOV_COUNTERS 9
> 

Content looks good but the patch doesn't apply due to whitespace issues.
Could you send a version with the tabs remaining intact? Also a slightly
more verbose patch message (similar to the one of the original patch)
would be helpful.

-- 
Peter Oberparleiter
Linux on z Systems Development - IBM Germany

[toc] | [prev] | [next] | [standalone]

#1435337 — [PATCH v003] Added support for gcc version >= 6

FromFlorian Meier <Florian.Meier@informatik.uni-erlangen.de>
Date2016-07-01 15:30 +0200
Subject[PATCH v003] Added support for gcc version >= 6
Message-ID<rQ6G6-79F-37@gated-at.bofh.it>
In reply to#1435255
Added support for gcc version >= 6 in gcov.

Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
 kernel/gcov/gcc_4_7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
 #include <linux/vmalloc.h>
 #include "gcov.h"
 
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
 #define GCOV_COUNTERS			10
 #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
 #define GCOV_COUNTERS			9
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1435459 — Re: [PATCH v003] Added support for gcc version >= 6

FromPeter Oberparleiter <oberpar@linux.vnet.ibm.com>
Date2016-07-01 17:50 +0200
SubjectRe: [PATCH v003] Added support for gcc version >= 6
Message-ID<rQ8RA-8qk-41@gated-at.bofh.it>
In reply to#1435337
On 01.07.2016 15:09, Florian Meier wrote:
> Added support for gcc version >= 6 in gcov.
> 
> Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>

Looks good, thanks! Tested successfully with gcc 4.8.5 and gcc 6.1.0.
Andrew, could you pick this change up via your tree?

Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Tested-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>

> ---
>  kernel/gcov/gcc_4_7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index e25e92f..6a5c239 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,7 @@
>  #include <linux/vmalloc.h>
>  #include "gcov.h"
> 
> -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
> +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
>  #define GCOV_COUNTERS			10
>  #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
>  #define GCOV_COUNTERS			9
> 

-- 
Peter Oberparleiter
Linux on z Systems Development - IBM Germany

[toc] | [prev] | [next] | [standalone]

#1435487 — Re: [PATCH v003] Added support for gcc version >= 6

FromJoe Perches <joe@perches.com>
Date2016-07-01 18:30 +0200
SubjectRe: [PATCH v003] Added support for gcc version >= 6
Message-ID<rQ9uh-r2-13@gated-at.bofh.it>
In reply to#1435337
On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
> Added support for gcc version >= 6 in gcov.

It's important to mention the subsystem in the patch subject

e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"

[toc] | [prev] | [next] | [standalone]

#1436219 — Re: [PATCH v003] Added support for gcc version >= 6

FromPeter Oberparleiter <oberpar@linux.vnet.ibm.com>
Date2016-07-04 09:50 +0200
SubjectRe: [PATCH v003] Added support for gcc version >= 6
Message-ID<rR6NH-2Pw-5@gated-at.bofh.it>
In reply to#1435487
On 01.07.2016 18:26, Joe Perches wrote:
> On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
>> Added support for gcc version >= 6 in gcov.
> 
> It's important to mention the subsystem in the patch subject
> 
> e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"

Thanks for pointing this out - I completely missed that this was lost
between v2 and v3 of the patch. Should we re-post or can this be fixed
another way?

-- 
Peter Oberparleiter
Linux on z Systems Development - IBM Germany

[toc] | [prev] | [next] | [standalone]

#1436238 — Re: [PATCH v003] Added support for gcc version >= 6

FromFlorian Meier <Florian.Meier@informatik.uni-erlangen.de>
Date2016-07-04 10:00 +0200
SubjectRe: [PATCH v003] Added support for gcc version >= 6
Message-ID<rR6Xn-2SK-5@gated-at.bofh.it>
In reply to#1436219
I'll repost it, that's the easiest fix.

On 4 July 2016 at 09:43, Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
> On 01.07.2016 18:26, Joe Perches wrote:
>> On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
>>> Added support for gcc version >= 6 in gcov.
>>
>> It's important to mention the subsystem in the patch subject
>>
>> e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"
>
> Thanks for pointing this out - I completely missed that this was lost
> between v2 and v3 of the patch. Should we re-post or can this be fixed
> another way?
>
> --
> Peter Oberparleiter
> Linux on z Systems Development - IBM Germany
>

[toc] | [prev] | [next] | [standalone]

#1436255 — [PATCH v004] gcov: Added support for gcc version >= 6

FromFlorian Meier <Florian.Meier@informatik.uni-erlangen.de>
Date2016-07-04 10:20 +0200
Subject[PATCH v004] gcov: Added support for gcc version >= 6
Message-ID<rR7gJ-3eC-15@gated-at.bofh.it>
In reply to#1436238
Added support for gcc version >= 6 in gcov.

Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
 kernel/gcov/gcc_4_7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
 #include <linux/vmalloc.h>
 #include "gcov.h"
 
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
 #define GCOV_COUNTERS			10
 #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
 #define GCOV_COUNTERS			9
-- 
2.9.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web