Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435287 > unrolled thread
| Started by | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| First post | 2016-07-01 14:30 +0200 |
| Last post | 2016-07-04 05:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-01 14:30 +0200
Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC "Wu, Songjun" <songjun.wu@atmel.com> - 2016-07-04 05:10 +0200
| From | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| Date | 2016-07-01 14:30 +0200 |
| Subject | Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC |
| Message-ID | <rQ5K1-6Au-7@gated-at.bofh.it> |
Hi Songjun, First of all, please CC patch 2/2 to linux-media as well the next time you post this. I only see 1/2 on the mailinglist, and we need both. Secondly, before I can accept it you need to run the v4l2-compliance test first and I need to see the output of that test. The compliance test is here: https://git.linuxtv.org/v4l-utils.git. Always compile it from the repository so you know you are using the latest most up to date version. Since this driver supports multiple pixelformats you need to test with the -f option, which tests streaming for all pixelformats. Obviously, there shouldn't be any FAILs :-) I greatly simplifies the code review if I know it passes the compliance test. Regards, Hans
[toc] | [next] | [standalone]
| From | "Wu, Songjun" <songjun.wu@atmel.com> |
|---|---|
| Date | 2016-07-04 05:10 +0200 |
| Message-ID | <rR2qJ-jU-7@gated-at.bofh.it> |
| In reply to | #1435287 |
On 7/1/2016 20:20, Hans Verkuil wrote: > Hi Songjun, > > First of all, please CC patch 2/2 to linux-media as well the next time you post this. > I only see 1/2 on the mailinglist, and we need both. > > Secondly, before I can accept it you need to run the v4l2-compliance test first and > I need to see the output of that test. > > The compliance test is here: https://git.linuxtv.org/v4l-utils.git. Always compile it from > the repository so you know you are using the latest most up to date version. > > Since this driver supports multiple pixelformats you need to test with the -f option, > which tests streaming for all pixelformats. > > Obviously, there shouldn't be any FAILs :-) > > I greatly simplifies the code review if I know it passes the compliance test. > Hi Hans, You suggestion is very helpful to me. I will give the output of the compliance test in next version. > Regards, > > Hans >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web