Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1435917 > unrolled thread

[PATCH] drm/tegra: fix error handling

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/tegra: fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-07-03 08:20 +0200
    Re: [PATCH] drm/tegra: fix error handling Alexandre Courbot <gnurou@gmail.com> - 2016-07-04 03:50 +0200

#1435917 — [PATCH] drm/tegra: fix error handling

This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk'
is expected here.


Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/tegra/gr3d.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c
index 0b3f2b9..13f0d1b 100644
--- a/drivers/gpu/drm/tegra/gr3d.c
+++ b/drivers/gpu/drm/tegra/gr3d.c
@@ -268,9 +268,9 @@ static int gr3d_probe(struct platform_device *pdev)
 
 	if (of_device_is_compatible(np, "nvidia,tegra30-gr3d")) {
 		gr3d->clk_secondary = devm_clk_get(&pdev->dev, "3d2");
-		if (IS_ERR(gr3d->clk)) {
+		if (IS_ERR(gr3d->clk_secondary)) {
 			dev_err(&pdev->dev, "cannot get secondary clock\n");
-			return PTR_ERR(gr3d->clk);
+			return PTR_ERR(gr3d->clk_secondary);
 		}
 
 		gr3d->rst_secondary = devm_reset_control_get(&pdev->dev,
-- 
2.7.4

[toc] | [next] | [standalone]

#1436109

On Sun, Jul 3, 2016 at 3:18 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk'
> is expected here.

Very likely indeed.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web