Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435631 > unrolled thread
| Started by | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| First post | 2016-07-01 23:20 +0200 |
| Last post | 2016-07-01 23:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] soc: qcom: smem: Silence probe defer error Stephen Boyd <sboyd@codeaurora.org> - 2016-07-01 23:20 +0200
Re: [PATCH] soc: qcom: smem: Silence probe defer error Andy Gross <andy.gross@linaro.org> - 2016-07-01 23:40 +0200
Re: [PATCH] soc: qcom: smem: Silence probe defer error Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-01 23:50 +0200
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2016-07-01 23:20 +0200 |
| Subject | [PATCH] soc: qcom: smem: Silence probe defer error |
| Message-ID | <rQe0W-3cM-9@gated-at.bofh.it> |
If we fail to get the hwspinlock due to probe defer, we shouldn't
print an error message. Just be silent in this case.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/soc/qcom/smem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 2e1aa9f130f4..18ec52f2078a 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
if (hwlock_id < 0) {
- dev_err(&pdev->dev, "failed to retrieve hwlock\n");
+ if (hwlock_id != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to retrieve hwlock\n");
return hwlock_id;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Date | 2016-07-01 23:40 +0200 |
| Message-ID | <rQekh-3jb-1@gated-at.bofh.it> |
| In reply to | #1435631 |
On Fri, Jul 01, 2016 at 02:18:59PM -0700, Stephen Boyd wrote: > If we fail to get the hwspinlock due to probe defer, we shouldn't > print an error message. Just be silent in this case. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Looks good to me. This has needed to be fixed for a while. Thanks! Andy
[toc] | [prev] | [next] | [standalone]
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2016-07-01 23:50 +0200 |
| Message-ID | <rQetY-3mA-21@gated-at.bofh.it> |
| In reply to | #1435631 |
On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote:
> If we fail to get the hwspinlock due to probe defer, we shouldn't
> print an error message. Just be silent in this case.
>
This generally seems to result in a large pile of drivers ending up on
the probe deferr list, so something we should try to avoid.
But the patch itself looks good:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/soc/qcom/smem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 2e1aa9f130f4..18ec52f2078a 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev)
>
> hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
> if (hwlock_id < 0) {
> - dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> + if (hwlock_id != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to retrieve hwlock\n");
> return hwlock_id;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web