Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435909 > unrolled thread
| Started by | Salah Triki <salah.triki@gmail.com> |
|---|---|
| First post | 2016-07-03 06:50 +0200 |
| Last post | 2016-07-04 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl() Salah Triki <salah.triki@gmail.com> - 2016-07-03 06:50 +0200
Re: [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl() David Sterba <dsterba@suse.cz> - 2016-07-04 20:00 +0200
| From | Salah Triki <salah.triki@gmail.com> |
|---|---|
| Date | 2016-07-03 06:50 +0200 |
| Subject | [PATCH] fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl() |
| Message-ID | <rQHvX-4j3-3@gated-at.bofh.it> |
size contains the value returned by posix_acl_from_xattr(), which
returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
replace -ENOENT by -ERANGE.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
fs/btrfs/acl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 67a6077..53bb7af 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -55,8 +55,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
}
if (size > 0) {
acl = posix_acl_from_xattr(&init_user_ns, value, size);
- } else if (size == -ENOENT || size == -ENODATA || size == 0) {
- /* FIXME, who returns -ENOENT? I think nobody */
+ } else if (size == -ERANGE || size == -ENODATA || size == 0) {
acl = NULL;
} else {
acl = ERR_PTR(-EIO);
--
1.9.1
[toc] | [next] | [standalone]
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2016-07-04 20:00 +0200 |
| Message-ID | <rRgk2-9M-27@gated-at.bofh.it> |
| In reply to | #1435909 |
On Sun, Jul 03, 2016 at 05:40:10AM +0100, Salah Triki wrote: > size contains the value returned by posix_acl_from_xattr(), which > returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So > replace -ENOENT by -ERANGE. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> Reviewed-by: David Sterba <dsterba@suse.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web