Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1435241 > unrolled thread

[PATCH] drm/tegra: add missing include

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/tegra: add missing include Arnd Bergmann <arnd@arndb.de> - 2016-07-01 12:30 +0200
    Re: [PATCH] drm/tegra: add missing include Thierry Reding <thierry.reding@gmail.com> - 2016-07-01 15:20 +0200

#1435241 — [PATCH] drm/tegra: add missing include

A newly merged patch to configure the XBAR caused a build failure
in some configurations:

drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_set_pinmux':
drivers/gpu/drm/tegra/sor.c:252:10: error: implicit declaration of function 'pinctrl_lookup_state' [-Werror=implicit-function-declaration]
  state = pinctrl_lookup_state(sor->pinctrl, name);
          ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tegra/sor.c:252:8: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
  state = pinctrl_lookup_state(sor->pinctrl, name);

The functions are declared in linux/pinctrl/consumer.h, so we need
to include that file instead of relying on the inclusion to happen
through another header.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9e9d1315f4f4 ("drm/tegra: sor: Make XBAR configurable per SoC")
---
 drivers/gpu/drm/tegra/sor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 8425edaa4e8a..9ff6aa7585cf 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/pm_runtime.h>
 #include <linux/regulator/consumer.h>
 #include <linux/reset.h>
-- 
2.9.0

[toc] | [next] | [standalone]

#1435323

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jul 01, 2016 at 12:16:20PM +0200, Arnd Bergmann wrote:
> A newly merged patch to configure the XBAR caused a build failure
> in some configurations:
> 
> drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_set_pinmux':
> drivers/gpu/drm/tegra/sor.c:252:10: error: implicit declaration of function 'pinctrl_lookup_state' [-Werror=implicit-function-declaration]
>   state = pinctrl_lookup_state(sor->pinctrl, name);
>           ^~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tegra/sor.c:252:8: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>   state = pinctrl_lookup_state(sor->pinctrl, name);
> 
> The functions are declared in linux/pinctrl/consumer.h, so we need
> to include that file instead of relying on the inclusion to happen
> through another header.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 9e9d1315f4f4 ("drm/tegra: sor: Make XBAR configurable per SoC")
> ---
>  drivers/gpu/drm/tegra/sor.c | 1 +
>  1 file changed, 1 insertion(+)

This was actually introduced in 035f79bcd5e5 ("drm/tegra: sor: Support
DPAUX pin control"), which is causing other problems at runtime, so I've
backed it out again.

Thanks,
Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web