Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1435247 > unrolled thread
| Started by | Will Deacon <will.deacon@arm.com> |
|---|---|
| First post | 2016-07-01 12:40 +0200 |
| Last post | 2016-07-04 13:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 4/7] bus: arm-cci: add missing of_node_put after calling of_parse_phandle Will Deacon <will.deacon@arm.com> - 2016-07-01 12:40 +0200
Re: [PATCH 4/7] bus: arm-cci: add missing of_node_put after calling of_parse_phandle Will Deacon <will.deacon@arm.com> - 2016-07-04 11:20 +0200
RE: [PATCH 4/7] bus: arm-cci: add missing of_node_put after calling of_parse_phandle Peter Chen <peter.chen@nxp.com> - 2016-07-04 13:30 +0200
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2016-07-01 12:40 +0200 |
| Subject | Re: [PATCH 4/7] bus: arm-cci: add missing of_node_put after calling of_parse_phandle |
| Message-ID | <rQ41z-5v6-7@gated-at.bofh.it> |
On Fri, Jul 01, 2016 at 11:29:58AM +0100, Suzuki K Poulose wrote:
> On 01/07/16 10:41, Peter Chen wrote:
> >of_node_put needs to be called when the device node which is got
> >from of_parse_phandle has finished using.
> >
> >Cc: Will Deacon <will.deacon@arm.com>
> >Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> >Signed-off-by: Peter Chen <peter.chen@nxp.com>
>
> Thanks for the fix.
>
> >---
> > drivers/bus/arm-cci.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> >index a49b283..e7b0b8c 100644
> >--- a/drivers/bus/arm-cci.c
> >+++ b/drivers/bus/arm-cci.c
> >@@ -1912,9 +1912,12 @@ static int __cci_ace_get_port(struct device_node *dn, int type)
> > cci_portn = of_parse_phandle(dn, "cci-control-port", 0);
> > for (i = 0; i < nb_cci_ports; i++) {
> > ace_match = ports[i].type == type;
> >- if (ace_match && cci_portn == ports[i].dn)
> >+ if (ace_match && cci_portn == ports[i].dn) {
> >+ of_node_put(cci_portn);
> > return i;
> >+ }
> > }
> >+ of_node_put(cci_portn);
>
> nit: Could we please do some thing like this ?
> if (ace_match && cci_portn == ports[i].dn)
> break;
> }
>
> of_node_put(cci_portn);
> return (i < nb_cci_ports) ? i : -ENODEV ;
>
> Either way,
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Please route this via arm-soc once you've addressed Suzuki's comment.
Will
[toc] | [next] | [standalone]
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2016-07-04 11:20 +0200 |
| Message-ID | <rR8cO-3NA-17@gated-at.bofh.it> |
| In reply to | #1435247 |
On Mon, Jul 04, 2016 at 02:48:08AM +0000, Peter Chen wrote: > >Please route this via arm-soc once you've addressed Suzuki's comment. > > Hi Will, how to route patch via arm-soc? > > Does it mean sending patch by adding arm@kernel.org at To or Cc list? Yes. I just wanted to make it clear that I don't intend to pick this up (since I'd just send it to arm-soc anyway!). Will
[toc] | [prev] | [next] | [standalone]
| From | Peter Chen <peter.chen@nxp.com> |
|---|---|
| Date | 2016-07-04 13:30 +0200 |
| Message-ID | <rR8cO-3NA-19@gated-at.bofh.it> |
| In reply to | #1435247 |
>
>On Fri, Jul 01, 2016 at 11:29:58AM +0100, Suzuki K Poulose wrote:
>> On 01/07/16 10:41, Peter Chen wrote:
>> >of_node_put needs to be called when the device node which is got from
>> >of_parse_phandle has finished using.
>> >
>> >Cc: Will Deacon <will.deacon@arm.com>
>> >Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
>> >Signed-off-by: Peter Chen <peter.chen@nxp.com>
>>
>> Thanks for the fix.
>>
>> >---
>> > drivers/bus/arm-cci.c | 5 ++++-
>> > 1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> >diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index
>> >a49b283..e7b0b8c 100644
>> >--- a/drivers/bus/arm-cci.c
>> >+++ b/drivers/bus/arm-cci.c
>> >@@ -1912,9 +1912,12 @@ static int __cci_ace_get_port(struct device_node *dn,
>int type)
>> > cci_portn = of_parse_phandle(dn, "cci-control-port", 0);
>> > for (i = 0; i < nb_cci_ports; i++) {
>> > ace_match = ports[i].type == type;
>> >- if (ace_match && cci_portn == ports[i].dn)
>> >+ if (ace_match && cci_portn == ports[i].dn) {
>> >+ of_node_put(cci_portn);
>> > return i;
>> >+ }
>> > }
>> >+ of_node_put(cci_portn);
>>
>> nit: Could we please do some thing like this ?
>> if (ace_match && cci_portn == ports[i].dn)
>> break;
>> }
>>
>> of_node_put(cci_portn);
>> return (i < nb_cci_ports) ? i : -ENODEV ;
>>
>> Either way,
>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
>Please route this via arm-soc once you've addressed Suzuki's comment.
>
Hi Will, how to route patch via arm-soc?
Does it mean sending patch by adding arm@kernel.org at To or Cc list?
Peter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web