Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1434039 > unrolled thread

[PATCH 1/2] fs: befs: check silent flag before logging error

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] fs: befs: check silent flag before logging error Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-29 22:30 +0200
    [PATCH 2/2] fs: befs: remove comment that confuses kernel-doc Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-29 22:30 +0200

#1434039 — [PATCH 1/2] fs: befs: check silent flag before logging error

Log error only when silent flag is not set.

Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

Reading the backlog of latest patches to befs, I noticed that Salah's patch
missed one call to befs_error() when setting all to only be used when the
silent argument is false.

Thanks,
Luis

 fs/befs/linuxvfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index b700645..bf5658d 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
 	 */ 
 	blocksize = sb_min_blocksize(sb, 1024);
 	if (!blocksize) {
-		befs_error(sb, "unable to set blocksize");
+		if (!silent)
+			befs_error(sb, "unable to set blocksize");
 		goto unacquire_priv_sbp;
 	}
 
-- 
2.5.1

[toc] | [next] | [standalone]

#1434041 — [PATCH 2/2] fs: befs: remove comment that confuses kernel-doc

This comment with a mysterious unfinished line confuses the kernel-doc
system since, because it starts with /**, it thinks it is documenting a
function.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 fs/befs/linuxvfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index bf5658d..0a97fad 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -632,10 +632,6 @@ befs_nls2utf(struct super_block *sb, const char *in,
 	return -EILSEQ;
 }
 
-/**
- * Use the
- *
- */
 enum {
 	Opt_uid, Opt_gid, Opt_charset, Opt_debug, Opt_err,
 };
-- 
2.5.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web