Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433244 > unrolled thread
| Started by | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| First post | 2016-06-28 21:40 +0200 |
| Last post | 2016-07-01 00:10 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-06-28 22:20 +0200
Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Florian Fainelli <f.fainelli@gmail.com> - 2016-06-29 20:40 +0200
Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Ray Jui <ray.jui@broadcom.com> - 2016-06-30 20:10 +0200
Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason <jon.mason@broadcom.com> - 2016-07-01 00:10 +0200
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Date | 2016-06-28 21:40 +0200 |
| Subject | [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac |
| Message-ID | <rP71x-2K4-41@gated-at.bofh.it> |
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
.../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
new file mode 100644
index 0000000..efd36d5
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
@@ -0,0 +1,21 @@
+Broadcom GMAC Ethernet Controller Device Tree Bindings
+-------------------------------------------------------------
+
+Required properties:
+ - compatible: "brcm,bgmac-enet"
+ - reg: Address and length of the GMAC registers,
+ Address and length of the GMAC IDM registers
+ - interrupts: Interrupt number
+
+Optional properties:
+- mac-address: mac address to be assigned to the device
+
+Examples:
+
+gmac0: enet@18022000 {
+ compatible = "brcm,bgmac-enet";
+ reg = <0x18022000 0x1000>,
+ <0x18110000 0x1000>;
+ interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+};
--
1.9.1
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-06-28 22:20 +0200 |
| Subject | Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac |
| Message-ID | <rP7Ee-3d8-15@gated-at.bofh.it> |
| In reply to | #1433244 |
Hello.
On 06/28/2016 10:34 PM, Jon Mason wrote:
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> new file mode 100644
> index 0000000..efd36d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> @@ -0,0 +1,21 @@
> +Broadcom GMAC Ethernet Controller Device Tree Bindings
> +-------------------------------------------------------------
> +
> +Required properties:
> + - compatible: "brcm,bgmac-enet"
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
> + - interrupts: Interrupt number
> +
> +Optional properties:
> +- mac-address: mac address to be assigned to the device
Refer to ethernet.txt in the same directory.
> +
> +Examples:
> +
> +gmac0: enet@18022000 {
The node name should be "ethernet@..." to comply eith the ePAPR standard.
WBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2016-06-29 20:40 +0200 |
| Subject | Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac |
| Message-ID | <rPsyZ-7FB-9@gated-at.bofh.it> |
| In reply to | #1433244 |
On 06/28/2016 12:34 PM, Jon Mason wrote:
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> new file mode 100644
> index 0000000..efd36d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> @@ -0,0 +1,21 @@
> +Broadcom GMAC Ethernet Controller Device Tree Bindings
> +-------------------------------------------------------------
> +
> +Required properties:
> + - compatible: "brcm,bgmac-enet"
You might want something a bit more explicit like "brcm,bgmac-nsp" for
instance and also define a compatible string for the Northstar family maybe?
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
> + - interrupts: Interrupt number
> +
> +Optional properties:
> +- mac-address: mac address to be assigned to the device
> +
> +Examples:
> +
> +gmac0: enet@18022000 {
> + compatible = "brcm,bgmac-enet";
> + reg = <0x18022000 0x1000>,
> + <0x18110000 0x1000>;
> + interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> +};
>
--
Florian
[toc] | [prev] | [next] | [standalone]
| From | Ray Jui <ray.jui@broadcom.com> |
|---|---|
| Date | 2016-06-30 20:10 +0200 |
| Subject | Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac |
| Message-ID | <rPOzw-4q2-21@gated-at.bofh.it> |
| In reply to | #1433244 |
Hi Jon,
On 6/28/2016 12:34 PM, Jon Mason wrote:
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> new file mode 100644
> index 0000000..efd36d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
> @@ -0,0 +1,21 @@
> +Broadcom GMAC Ethernet Controller Device Tree Bindings
> +-------------------------------------------------------------
> +
> +Required properties:
> + - compatible: "brcm,bgmac-enet"
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
As we know there will be additional optional register banks required for
some of the other SoCs that the current driver has not yet supported. In
my opinion, we should consider to make "reg-names" a mandatory property
now and map the register blocks based on names.
I think this will help to make our life easier in the future when new
optional SoC specific register blocks are added, such that we can map
the register blocks based on names instead of indices, which will change
and be different among different SoCs and will require much more complex
logic in the driver to deal with.
> + - interrupts: Interrupt number
> +
> +Optional properties:
> +- mac-address: mac address to be assigned to the device
> +
> +Examples:
> +
> +gmac0: enet@18022000 {
> + compatible = "brcm,bgmac-enet";
> + reg = <0x18022000 0x1000>,
> + <0x18110000 0x1000>;
> + interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> +};
>
Btw, I think Rob Herring should be included in the review for device
tree binding document changes.
Thanks,
Ray
[toc] | [prev] | [next] | [standalone]
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Date | 2016-07-01 00:10 +0200 |
| Message-ID | <rPSjL-6FA-5@gated-at.bofh.it> |
| In reply to | #1434784 |
On Thu, Jun 30, 2016 at 2:06 PM, Ray Jui <ray.jui@broadcom.com> wrote:
> Hi Jon,
>
> On 6/28/2016 12:34 PM, Jon Mason wrote:
>>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>> ---
>> .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21
>> +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>> b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>> new file mode 100644
>> index 0000000..efd36d5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt
>> @@ -0,0 +1,21 @@
>> +Broadcom GMAC Ethernet Controller Device Tree Bindings
>> +-------------------------------------------------------------
>> +
>> +Required properties:
>> + - compatible: "brcm,bgmac-enet"
>> + - reg: Address and length of the GMAC registers,
>> + Address and length of the GMAC IDM registers
>
>
> As we know there will be additional optional register banks required for
> some of the other SoCs that the current driver has not yet supported. In my
> opinion, we should consider to make "reg-names" a mandatory property now and
> map the register blocks based on names.
>
> I think this will help to make our life easier in the future when new
> optional SoC specific register blocks are added, such that we can map the
> register blocks based on names instead of indices, which will change and be
> different among different SoCs and will require much more complex logic in
> the driver to deal with.
I don't have any objection to this. I'll tweak the patches to do it by name.
>
>> + - interrupts: Interrupt number
>> +
>> +Optional properties:
>> +- mac-address: mac address to be assigned to the device
>> +
>> +Examples:
>> +
>> +gmac0: enet@18022000 {
>> + compatible = "brcm,bgmac-enet";
>> + reg = <0x18022000 0x1000>,
>> + <0x18110000 0x1000>;
>> + interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> +};
>>
>
> Btw, I think Rob Herring should be included in the review for device tree
> binding document changes.
Thanks, I'll add him and the other DT maintainers when I send this out
as a "PATCH" shortly.
Thanks,
Jon
>
> Thanks,
>
> Ray
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web