Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433669 > unrolled thread

Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc()

Started byColy Li <i@coly.li>
First post2016-06-29 12:50 +0200
Last post2016-07-01 08:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for  cache_alloc() Coly Li <i@coly.li> - 2016-06-29 12:50 +0200
    Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for  cache_alloc() wangyijing <wangyijing@huawei.com> - 2016-07-01 04:20 +0200
      Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for  cache_alloc() Coly Li <colyli@suse.de> - 2016-07-01 06:30 +0200
        Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for  cache_alloc() wangyijing <wangyijing@huawei.com> - 2016-07-01 08:30 +0200

#1433669 — Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc()

FromColy Li <i@coly.li>
Date2016-06-29 12:50 +0200
SubjectRe: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc()
Message-ID<rPlea-36J-29@gated-at.bofh.it>
在 16/6/22 上午10:10, Yijing Wang 写道:
> Cache_sb is not used in cache_alloc, and we have copied
> sb info to cache->sb already, remove it.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
>  drivers/md/bcache/super.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index f5dbb4e..aecaace 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj)
>  	module_put(THIS_MODULE);
>  }
>  
> -static int cache_alloc(struct cache_sb *sb, struct cache *ca)
> +static int cache_alloc(struct cache *ca)
>  {
>  	size_t free;
>  	struct bucket *b;
> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page,
>  	if (blk_queue_discard(bdev_get_queue(ca->bdev)))
>  		ca->discard = CACHE_DISCARD(&ca->sb);
>  
> -	ret = cache_alloc(sb, ca);
> +	ret = cache_alloc(ca);

I am not sure whether struct cache_b *sb will be used in future, I
suggest to let it be for now.



>  	if (ret != 0)
>  		goto err;
>  
> 


-- 
Coly Li

[toc] | [next] | [standalone]

#1434962

Fromwangyijing <wangyijing@huawei.com>
Date2016-07-01 04:20 +0200
Message-ID<rPWdH-NS-3@gated-at.bofh.it>
In reply to#1433669

在 2016/6/29 18:20, Coly Li 写道:
> 在 16/6/22 上午10:10, Yijing Wang 写道:
>> Cache_sb is not used in cache_alloc, and we have copied
>> sb info to cache->sb already, remove it.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  drivers/md/bcache/super.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index f5dbb4e..aecaace 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj)
>>  	module_put(THIS_MODULE);
>>  }
>>  
>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca)
>> +static int cache_alloc(struct cache *ca)
>>  {
>>  	size_t free;
>>  	struct bucket *b;
>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page,
>>  	if (blk_queue_discard(bdev_get_queue(ca->bdev)))
>>  		ca->discard = CACHE_DISCARD(&ca->sb);
>>  
>> -	ret = cache_alloc(sb, ca);
>> +	ret = cache_alloc(ca);
> 
> I am not sure whether struct cache_b *sb will be used in future, I
> suggest to let it be for now.
> 

We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb.

Thanks!
Yijing.

> 
> 
>>  	if (ret != 0)
>>  		goto err;
>>  
>>
> 
>

[toc] | [prev] | [next] | [standalone]

#1435004

FromColy Li <colyli@suse.de>
Date2016-07-01 06:30 +0200
Message-ID<rPYfv-21k-1@gated-at.bofh.it>
In reply to#1434962
在 16/7/1 上午10:09, wangyijing 写道:
> 
> 
> 在 2016/6/29 18:20, Coly Li 写道:
>> 在 16/6/22 上午10:10, Yijing Wang 写道:
>>> Cache_sb is not used in cache_alloc, and we have copied
>>> sb info to cache->sb already, remove it.
>>>
>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>>> ---
>>>  drivers/md/bcache/super.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>>> index f5dbb4e..aecaace 100644
>>> --- a/drivers/md/bcache/super.c
>>> +++ b/drivers/md/bcache/super.c
>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj)
>>>  	module_put(THIS_MODULE);
>>>  }
>>>  
>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca)
>>> +static int cache_alloc(struct cache *ca)
>>>  {
>>>  	size_t free;
>>>  	struct bucket *b;
>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page,
>>>  	if (blk_queue_discard(bdev_get_queue(ca->bdev)))
>>>  		ca->discard = CACHE_DISCARD(&ca->sb);
>>>  
>>> -	ret = cache_alloc(sb, ca);
>>> +	ret = cache_alloc(ca);
>>
>> I am not sure whether struct cache_b *sb will be used in future, I
>> suggest to let it be for now.
>>
> 
> We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb.
> 

Hi Yijing,

Your point makes sense, please add
	Reviewed-by: Coly Li <colyli@suse.de>
in your patch, if you don't mind :-)

Thanks for your interpretation.

Coly

[toc] | [prev] | [next] | [standalone]

#1435039

Fromwangyijing <wangyijing@huawei.com>
Date2016-07-01 08:30 +0200
Message-ID<rQ07D-39G-1@gated-at.bofh.it>
In reply to#1435004

在 2016/7/1 12:24, Coly Li 写道:
> 在 16/7/1 上午10:09, wangyijing 写道:
>>
>>
>> 在 2016/6/29 18:20, Coly Li 写道:
>>> 在 16/6/22 上午10:10, Yijing Wang 写道:
>>>> Cache_sb is not used in cache_alloc, and we have copied
>>>> sb info to cache->sb already, remove it.
>>>>
>>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>>>> ---
>>>>  drivers/md/bcache/super.c |    4 ++--
>>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>>>> index f5dbb4e..aecaace 100644
>>>> --- a/drivers/md/bcache/super.c
>>>> +++ b/drivers/md/bcache/super.c
>>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj)
>>>>  	module_put(THIS_MODULE);
>>>>  }
>>>>  
>>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca)
>>>> +static int cache_alloc(struct cache *ca)
>>>>  {
>>>>  	size_t free;
>>>>  	struct bucket *b;
>>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page,
>>>>  	if (blk_queue_discard(bdev_get_queue(ca->bdev)))
>>>>  		ca->discard = CACHE_DISCARD(&ca->sb);
>>>>  
>>>> -	ret = cache_alloc(sb, ca);
>>>> +	ret = cache_alloc(ca);
>>>
>>> I am not sure whether struct cache_b *sb will be used in future, I
>>> suggest to let it be for now.
>>>
>>
>> We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb.
>>
> 
> Hi Yijing,
> 
> Your point makes sense, please add
> 	Reviewed-by: Coly Li <colyli@suse.de>
> in your patch, if you don't mind :-)
> 
> Thanks for your interpretation.
> 
> Coly

Thanks for your review very much!

Thanks!
Yijing.



> 
> .
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web