Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431831 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2016-06-27 11:10 +0200 |
| Last post | 2016-06-29 10:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-27 11:10 +0200
Re: [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent David Miller <davem@davemloft.net> - 2016-06-29 10:20 +0200
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-06-27 11:10 +0200 |
| Subject | [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent |
| Message-ID | <rOAIi-6Df-21@gated-at.bofh.it> |
pci_free_consistent's argument 'struct pci_dev' should be NULL not 0.
The Coccinelle semantic patch used to make this change is as follows:
@@
@@
pci_free_consistent(
- 0
+ NULL
, ...)
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
index 520cf50..01a7714 100644
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device *dev)
data->txring = dma_zalloc_coherent(NULL, txring_size, &data->txdma,
GFP_KERNEL);
if (!data->txring) {
- pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+ pci_free_consistent(NULL, rxring_size, data->rxring,
+ data->rxdma);
return -ENOMEM;
}
--
1.9.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-29 10:20 +0200 |
| Message-ID | <rPiT0-1Lg-31@gated-at.bofh.it> |
| In reply to | #1431831 |
From: Amitoj Kaur Chawla <amitoj1606@gmail.com> Date: Mon, 27 Jun 2016 14:34:50 +0530 > pci_free_consistent's argument 'struct pci_dev' should be NULL not 0. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > @@ > > pci_free_consistent( > - 0 > + NULL > , ...) > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> This patch doesn't apply.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web