Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433276 > unrolled thread

Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency Darren Hart <dvhart@infradead.org> - 2016-06-28 22:30 +0200
    RE: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com> - 2016-06-29 05:10 +0200

#1433276 — Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency

On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote:
> From: "Yu, Ong Hock" <ong.hock.yu@intel.com>
> 
> Telemetry capability does not depend on Monitor MWAIT feature.
> 
> Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>

Souvik, any objection?

> ---
>  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
>  drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
> index f5134ac..d76ee59 100644
> --- a/drivers/platform/x86/intel_telemetry_debugfs.c
> +++ b/drivers/platform/x86/intel_telemetry_debugfs.c
> @@ -78,7 +78,7 @@
>  #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
>  
>  #define TELEM_DEBUGFS_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data}
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
>  
>  #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \
>  	if (evtlog[index].telem_evtid == (EVTID)) { \
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 09c84a2..e62cee9 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -82,7 +82,7 @@
>  #define TELEM_SET_VERBOSITY_BITS(x, y)	((x) |= ((y) << 27))
>  
>  #define TELEM_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data }
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
>  
>  enum telemetry_action {
>  	TELEM_UPDATE = 0,
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [next] | [standalone]

#1433415

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Wednesday, June 29, 2016 1:54 AM
> To: Yu, Ong Hock <ong.hock.yu@intel.com>
> Cc: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; platform-driver-
> x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] platform:x86 Remove Monitor MWAIT feature
> dependency
> 
> On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote:
> > From: "Yu, Ong Hock" <ong.hock.yu@intel.com>
> >
> > Telemetry capability does not depend on Monitor MWAIT feature.
> >
> > Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>
Acked-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>

> 
> Souvik, any objection?
Seems reasonable, since I have not heard anything break from the Chrome guys as well.

> 
> > ---
> >  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
> > drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web