Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1434143 > unrolled thread

[PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

Started byKefeng Wang <wangkefeng.wang@huawei.com>
First post2016-06-30 03:30 +0200
Last post2016-06-30 16:50 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-30 03:30 +0200
    [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-30 03:40 +0200
      Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on  Hisilicon Hip05 soc Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-30 11:40 +0200
        Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on  Hisilicon Hip05 soc Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-30 12:00 +0200
          Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on  Hisilicon Hip05 soc Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-30 16:30 +0200
            Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on  Hisilicon Hip05 soc Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-30 16:50 +0200

#1434143 — [PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-06-30 03:30 +0200
Subject[PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPyXL-39e-3@gated-at.bofh.it>
Make dw8250_set_termios() as the default set_termios callback for 8250 dw uart, correct me
if I am wrong.

Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that it is not 16500
compatible. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out
and serial_in in ACPI.

Change since v1:
- Use acpi_match_device() instead of acpi_dev_found(), limit the check to the device
  being probed and not a global search for whole DSDT (pointed by graeme.gregory@linaro.org)

Kefeng Wang (2):
  serial: 8250_dw: make dw8250_set_termios as default set_termios
    callback
  serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

 drivers/tty/serial/8250/8250_dw.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

-- 
1.7.12.4

[toc] | [next] | [standalone]

#1434148 — [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-06-30 03:40 +0200
Subject[PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPz7r-3cj-1@gated-at.bofh.it>
In reply to#1434143
Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
that it is not 16550 compatibal.

Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out
and serial_in in ACPI.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 65f3da7..096431b 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan *chan, void *param)
 	return param == chan->device->dev->parent;
 }
 
+/* non 16550 compatible id list*/
+static const struct acpi_device_id non_16550_id_list[] = {
+	{ "HISI0031", 0 },
+	{ },
+};
+
 static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
 {
 	if (p->dev->of_node) {
@@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
 		p->iotype = UPIO_MEM32;
 		p->regshift = 2;
 		p->serial_in = dw8250_serial_in32;
-		/* So far none of there implement the Busy Functionality */
-		data->uart_16550_compatible = true;
+		p->serial_out = dw8250_serial_out32;
+
+		if (!acpi_match_device(non_16550_id_list, p->dev))
+			data->uart_16550_compatible = true;
 	}
 
 	/* Platforms with iDMA */
@@ -618,6 +626,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "APMC0D08", 0},
 	{ "AMD0020", 0 },
 	{ "AMDI0020", 0 },
+	{ "HISI0031", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
-- 
1.7.12.4

[toc] | [prev] | [next] | [standalone]

#1434412 — Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2016-06-30 11:40 +0200
SubjectRe: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPGBY-7Sr-19@gated-at.bofh.it>
In reply to#1434148
On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote:
> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
> that it is not 16550 compatibal.
> 
> Meanwhile, set dw8250_serial_out32 to keep consistent between
> serial_out
> and serial_in in ACPI.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_dw.c
> b/drivers/tty/serial/8250/8250_dw.c
> index 65f3da7..096431b 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan
> *chan, void *param)
>  	return param == chan->device->dev->parent;
>  }
>  
> +/* non 16550 compatible id list*/
> +static const struct acpi_device_id non_16550_id_list[] = {
> +	{ "HISI0031", 0 },
> +	{ },
> +};
> +

On first glance it looks redundant, see below.

>  static void dw8250_quirks(struct uart_port *p, struct dw8250_data
> *data)
>  {
>  	if (p->dev->of_node) {
> @@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p,
> struct dw8250_data *data)
>  		p->iotype = UPIO_MEM32;
>  		p->regshift = 2;
>  		p->serial_in = dw8250_serial_in32;
> -		/* So far none of there implement the Busy
> Functionality */
> -		data->uart_16550_compatible = true;
> +		p->serial_out = dw8250_serial_out32;
> +
> +		if (!acpi_match_device(non_16550_id_list, p->dev))
> +			data->uart_16550_compatible = true;
>  	}
>  
>  	/* Platforms with iDMA */
> @@ -618,6 +626,7 @@ static const struct acpi_device_id
> dw8250_acpi_match[] = {
>  	{ "APMC0D08", 0},
>  	{ "AMD0020", 0 },
>  	{ "AMDI0020", 0 },
> +	{ "HISI0031", 0 },

So, we may put something instead of 0 here and consider it as a set of
special quirks / setup instructions / etc.

struct dw8250_dev_info {
  unsigned int  uart_16550_compatible:1;
};

static const struct dw8250_dev_info hisi_dev_info = {
  .uart_16550_compatible = 1,
}

...
 { "HISI0031", (kernel_ulong_t)&hisi_dev_info },
...

And so on.

>  	{ },
>  };
>  MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1434420 — Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2016-06-30 12:00 +0200
SubjectRe: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPGVj-7Zc-11@gated-at.bofh.it>
In reply to#1434412
On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote:
> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote:
> > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
> > that it is not 16550 compatibal.
> > 
> > Meanwhile, set dw8250_serial_out32 to keep consistent between
> > serial_out
> > and serial_in in ACPI.
> > 
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > ---
> >  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > b/drivers/tty/serial/8250/8250_dw.c
> > index 65f3da7..096431b 100644
> > --- a/drivers/tty/serial/8250/8250_dw.c
> > +++ b/drivers/tty/serial/8250/8250_dw.c
> > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan
> > *chan, void *param)
> >  	return param == chan->device->dev->parent;
> >  }
> >  
> > +/* non 16550 compatible id list*/
> > +static const struct acpi_device_id non_16550_id_list[] = {
> > +	{ "HISI0031", 0 },
> > +	{ },
> > +};
> > +
> 
> On first glance it looks redundant, see below.

Oh, wait, this is still valid, but the better solution is to use device
properties for the rest except yours!

I will prepare patch later this week or at the beginning of next week if
you are in hurry, otherwise I would postpone this a bit (anyway it will
not make v4.8 cycle).

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1434615 — Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-06-30 16:30 +0200
SubjectRe: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPL8B-2eN-5@gated-at.bofh.it>
In reply to#1434420

On 2016/6/30 17:54, Andy Shevchenko wrote:
> On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote:
>> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote:
>>> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
>>> that it is not 16550 compatibal.
>>>
>>> Meanwhile, set dw8250_serial_out32 to keep consistent between
>>> serial_out
>>> and serial_in in ACPI.
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>>  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
>>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/8250/8250_dw.c
>>> b/drivers/tty/serial/8250/8250_dw.c
>>> index 65f3da7..096431b 100644
>>> --- a/drivers/tty/serial/8250/8250_dw.c
>>> +++ b/drivers/tty/serial/8250/8250_dw.c
>>> @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan
>>> *chan, void *param)
>>>  	return param == chan->device->dev->parent;
>>>  }
>>>  
>>> +/* non 16550 compatible id list*/
>>> +static const struct acpi_device_id non_16550_id_list[] = {
>>> +	{ "HISI0031", 0 },
>>> +	{ },
>>> +};
>>> +
>>
>> On first glance it looks redundant, see below.
> 
> Oh, wait, this is still valid, but the better solution is to use device
> properties for the rest except yours!

Do you mean using something like

static struct property_entry dw8250_properties[] = {
        PROPERTY_ENTRY_U32("reg-io-width", 4),
        PROPERTY_ENTRY_U32("reg-shift", 2),
        PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"),
        { },
};

then use platform_device_add_properties to add it to the device(16500 compatible),

but for hisi, use another property_entry without PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")?

Not clear about using device properties.

> 
> I will prepare patch later this week or at the beginning of next week if
> you are in hurry, otherwise I would postpone this a bit (anyway it will
> not make v4.8 cycle).
> 

Thanks, hope that it will come out soon.

BRs,
Kefeng

[toc] | [prev] | [next] | [standalone]

#1434635 — Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2016-06-30 16:50 +0200
SubjectRe: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc
Message-ID<rPLrX-2lA-9@gated-at.bofh.it>
In reply to#1434615
On Thu, 2016-06-30 at 22:26 +0800, Kefeng Wang wrote:
> 
> On 2016/6/30 17:54, Andy Shevchenko wrote:
> > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote:
> > > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote:
> > > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
> > > > that it is not 16550 compatibal.
> > > > 
> > > > Meanwhile, set dw8250_serial_out32 to keep consistent between
> > > > serial_out
> > > > and serial_in in ACPI.
> > > > 
> > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > > > ---
> > > >  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++--
> > > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/tty/serial/8250/8250_dw.c
> > > > b/drivers/tty/serial/8250/8250_dw.c
> > > > index 65f3da7..096431b 100644
> > > > --- a/drivers/tty/serial/8250/8250_dw.c
> > > > +++ b/drivers/tty/serial/8250/8250_dw.c
> > > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct
> > > > dma_chan
> > > > *chan, void *param)
> > > >  	return param == chan->device->dev->parent;
> > > >  }
> > > >  
> > > > +/* non 16550 compatible id list*/
> > > > +static const struct acpi_device_id non_16550_id_list[] = {
> > > > +	{ "HISI0031", 0 },
> > > > +	{ },
> > > > +};
> > > > +
> > > 
> > > On first glance it looks redundant, see below.
> > 
> > Oh, wait, this is still valid, but the better solution is to use
> > device
> > properties for the rest except yours!
> 
> Do you mean using something like
> 
> static struct property_entry dw8250_properties[] = {
>         PROPERTY_ENTRY_U32("reg-io-width", 4),
>         PROPERTY_ENTRY_U32("reg-shift", 2),
>         PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"),
>         { },
> };
> 
> then use platform_device_add_properties to add it to the device(16500
> compatible),

Correct for the existing devices.

> 
> but for hisi, use another property_entry without
> PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")?

For HISI in case of alternate configuration you have to tweak _DSD in
ACPI.

> 
> Not clear about using device properties.

Built-in device properties only for non-DT, non-ACPI devices. You may
consider it as a successor of platform data.

> 
> > 
> > I will prepare patch later this week or at the beginning of next
> > week if
> > you are in hurry, otherwise I would postpone this a bit (anyway it
> > will
> > not make v4.8 cycle).
> > 
> 
> Thanks, hope that it will come out soon.
> 

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web