Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1434431 > unrolled thread

[PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

Started byJan Stancek <jstancek@redhat.com>
First post2016-06-30 12:30 +0200
Last post2016-07-01 12:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Jan Stancek <jstancek@redhat.com> - 2016-06-30 12:30 +0200
    Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Herbert Xu <herbert@gondor.apana.org.au> - 2016-07-01 12:10 +0200

#1434431 — [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

FromJan Stancek <jstancek@redhat.com>
Date2016-06-30 12:30 +0200
Subject[PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
Message-ID<rPHom-8ot-63@gated-at.bofh.it>
Parallel build can sporadically fail because asn1 headers may
not be built yet by the time qat_asym_algs.o is compiled:
  drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
   #include "qat_rsapubkey-asn1.h"

Signed-off-by: Jan Stancek <jstancek@redhat.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
 drivers/crypto/qat/qat_common/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qat/qat_common/Makefile b/drivers/crypto/qat/qat_common/Makefile
index 6d74b91f2152..5fc3dbb9ada0 100644
--- a/drivers/crypto/qat/qat_common/Makefile
+++ b/drivers/crypto/qat/qat_common/Makefile
@@ -2,6 +2,7 @@ $(obj)/qat_rsapubkey-asn1.o: $(obj)/qat_rsapubkey-asn1.c \
 			     $(obj)/qat_rsapubkey-asn1.h
 $(obj)/qat_rsaprivkey-asn1.o: $(obj)/qat_rsaprivkey-asn1.c \
 			      $(obj)/qat_rsaprivkey-asn1.h
+$(obj)/qat_asym_algs.o: $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.h
 
 clean-files += qat_rsapubkey-asn1.c qat_rsapubkey-asn1.h
 clean-files += qat_rsaprivkey-asn1.c qat_rsaprivkey-asn1.h
-- 
1.8.3.1

[toc] | [next] | [standalone]


#1435235

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2016-07-01 12:10 +0200
Message-ID<rQ3yy-5kw-23@gated-at.bofh.it>
In reply to#1434431
On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
> Parallel build can sporadically fail because asn1 headers may
> not be built yet by the time qat_asym_algs.o is compiled:
>   drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
>    #include "qat_rsapubkey-asn1.h"
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>

Jan, Salvatore just posted a patch to delete the qat ASN code
altogether, so your patch won't be needed.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web