Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1430025 > unrolled thread

Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it

Started byPali Rohár <pali.rohar@gmail.com>
First post2016-06-23 19:50 +0200
Last post2016-06-30 07:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it Pali Rohár <pali.rohar@gmail.com> - 2016-06-23 19:50 +0200
    Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes  broke it Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-27 20:20 +0200
      Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes  broke it Tony Lindgren <tony@atomide.com> - 2016-06-30 07:00 +0200

#1430025 — Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it

FromPali Rohár <pali.rohar@gmail.com>
Date2016-06-23 19:50 +0200
SubjectRe: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it
Message-ID<rNgVj-4UA-33@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Wednesday 22 June 2016 21:22:17 Ivaylo Dimitrov wrote:
> The ir-rx51 driver for n900 has been disabled since the multiarch
> changes as plat include directory no longer is SoC specific.
> 
> Let's fix it with minimal changes to pass the dmtimer calls in
> pdata. Then the following changes can be done while things can
> be tested to be working for each change:
> 
> 1. Change the non-pwm dmtimer to use just hrtimer if possible
> 
> 2. Change the pwm dmtimer to use Linux PWM API with the new
>    drivers/pwm/pwm-omap-dmtimer.c and remove the direct calls
>    to dmtimer functions
> 
> 3. Parse configuration from device tree and drop the pdata
> 
> Note compilation of this depends on the previous patch
> "ARM: OMAP2+: Add more functions to pwm pdata for ir-rx51".

I think that this extensive description is not needed for commit 
message. Just for email discussion.

> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [next] | [standalone]


#1432211 — Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it

FromIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Date2016-06-27 20:20 +0200
SubjectRe: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it
Message-ID<rOJiy-3PR-9@gated-at.bofh.it>
In reply to#1430025

On 23.06.2016 20:48, Pali Rohár wrote:
> On Wednesday 22 June 2016 21:22:17 Ivaylo Dimitrov wrote:
>> The ir-rx51 driver for n900 has been disabled since the multiarch
>> changes as plat include directory no longer is SoC specific.
>>
>> Let's fix it with minimal changes to pass the dmtimer calls in
>> pdata. Then the following changes can be done while things can
>> be tested to be working for each change:
>>
>> 1. Change the non-pwm dmtimer to use just hrtimer if possible
>>
>> 2. Change the pwm dmtimer to use Linux PWM API with the new
>>     drivers/pwm/pwm-omap-dmtimer.c and remove the direct calls
>>     to dmtimer functions
>>
>> 3. Parse configuration from device tree and drop the pdata
>>
>> Note compilation of this depends on the previous patch
>> "ARM: OMAP2+: Add more functions to pwm pdata for ir-rx51".
>
> I think that this extensive description is not needed for commit
> message. Just for email discussion.
>

I guess Tony can strip the description a bit before applying.

Ivo

[toc] | [prev] | [next] | [standalone]


#1434223 — Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it

FromTony Lindgren <tony@atomide.com>
Date2016-06-30 07:00 +0200
SubjectRe: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it
Message-ID<rPCf0-59c-3@gated-at.bofh.it>
In reply to#1432211
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160627 11:22]:
> On 23.06.2016 20:48, Pali Rohár wrote:
> > On Wednesday 22 June 2016 21:22:17 Ivaylo Dimitrov wrote:
> > > The ir-rx51 driver for n900 has been disabled since the multiarch
> > > changes as plat include directory no longer is SoC specific.
> > > 
> > > Let's fix it with minimal changes to pass the dmtimer calls in
> > > pdata. Then the following changes can be done while things can
> > > be tested to be working for each change:
> > > 
> > > 1. Change the non-pwm dmtimer to use just hrtimer if possible
> > > 
> > > 2. Change the pwm dmtimer to use Linux PWM API with the new
> > >     drivers/pwm/pwm-omap-dmtimer.c and remove the direct calls
> > >     to dmtimer functions
> > > 
> > > 3. Parse configuration from device tree and drop the pdata
> > > 
> > > Note compilation of this depends on the previous patch
> > > "ARM: OMAP2+: Add more functions to pwm pdata for ir-rx51".
> > 
> > I think that this extensive description is not needed for commit
> > message. Just for email discussion.
> > 
> 
> I guess Tony can strip the description a bit before applying.

OK I'll leave out the last paragraph as that already got merged
earlier.

Tony

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web