Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1433156 > unrolled thread

Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port

Started byJoseph Myers <joseph@codesourcery.com>
First post2016-06-28 19:20 +0200
Last post2016-06-28 22:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port Joseph Myers <joseph@codesourcery.com> - 2016-06-28 19:20 +0200
    Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port Joseph Myers <joseph@codesourcery.com> - 2016-06-28 22:40 +0200
    Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port Adhemerval Zanella <adhemerval.zanella@linaro.org> - 2016-06-28 22:50 +0200

#1433156 — Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port

FromJoseph Myers <joseph@codesourcery.com>
Date2016-06-28 19:20 +0200
SubjectRe: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port
Message-ID<rP4Q1-1uE-23@gated-at.bofh.it>
On Tue, 28 Jun 2016, Yury Norov wrote:

> aarch64 and ilp32 has different size of time_t. So to have common
> layout for struct utmp and utmpx, corresponding headers are taken
> from s390 port.

You can't #include installed headers from other ports like this; it 
wouldn't work when using an installed library.

-- 
Joseph S. Myers
joseph@codesourcery.com

[toc] | [next] | [standalone]


#1433283

FromJoseph Myers <joseph@codesourcery.com>
Date2016-06-28 22:40 +0200
Message-ID<rP7Xz-3k5-3@gated-at.bofh.it>
In reply to#1433156
On Tue, 28 Jun 2016, Yury Norov wrote:

> > You can't #include installed headers from other ports like this; it 
> > wouldn't work when using an installed library.
> > 
> > -- 
> > Joseph S. Myers
> > joseph@codesourcery.com
> 
> So I should copy? Hmm...

Yes, unless you can develop an additional abstraction to describe the 
differences between architectures, so that all architectures can share the 
same bits/utmp.h and bits/utmpx.h and there's only a smaller header that 
needs copying.

-- 
Joseph S. Myers
joseph@codesourcery.com

[toc] | [prev] | [next] | [standalone]


#1433288

FromAdhemerval Zanella <adhemerval.zanella@linaro.org>
Date2016-06-28 22:50 +0200
Message-ID<rP87f-3nq-7@gated-at.bofh.it>
In reply to#1433156

On 28/06/2016 14:59, Yury Norov wrote:
> On Tue, Jun 28, 2016 at 05:18:04PM +0000, Joseph Myers wrote:
>> On Tue, 28 Jun 2016, Yury Norov wrote:
>>
>>> aarch64 and ilp32 has different size of time_t. So to have common
>>> layout for struct utmp and utmpx, corresponding headers are taken
>>> from s390 port.
>>
>> You can't #include installed headers from other ports like this; it 
>> wouldn't work when using an installed library.
>>
>> -- 
>> Joseph S. Myers
>> joseph@codesourcery.com
> 
> So I should copy? Hmm...
> 

In this case yes, since the reference will be broken because the s390
won't be installed.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web