Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432201 > unrolled thread

Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@kernel.org> - 2016-06-27 20:00 +0200
    Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 00:30 +0200
      Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 19:50 +0200
    Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-28 13:30 +0200

#1432201 — Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

On 06/23/2016 01:31 AM, Allen Hung wrote:
> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
> if device implements confidence usage")
>
> The commit enables palm rejection for Win8 Precision Touchpad devices but
> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
> properly. This quirk is originally designed for some WIn7 touchscreens. Use
> of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
> problem.
>
> Signed-off-by: Allen Hung <allen_hung@dell.com>
> ---
>  drivers/hid/hid-multitouch.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 95b7d61..4ef7006 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  			mt_store_field(usage, td, hi);
>  			return 1;
>  		case HID_DG_CONFIDENCE:
> -			if (cls->name == MT_CLS_WIN_8 &&
> -				field->application == HID_DG_TOUCHPAD) {
> -				cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
> -				cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
> -			}
>  			mt_store_field(usage, td, hi);
>  			return 1;
>  		case HID_DG_TIPSWITCH:
>

This and patch 2 are:

Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3

(And I'm curious why 1.4.3 seems to have been pulled.  Might it have 
been this issue?  For better or for worse, I upgraded in the narrow 
window in which it was available on Dell's website.)

--Andy

[toc] | [next] | [standalone]

#1432346

On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote:
> On 06/23/2016 01:31 AM, Allen Hung wrote:
>>
>> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
>> if device implements confidence usage")
>>
>> The commit enables palm rejection for Win8 Precision Touchpad devices but
>> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
>> properly. This quirk is originally designed for some WIn7 touchscreens.
>> Use
>> of this for a Win8 Precision Touchpad will cause unexpected pointer
>> jumping
>> problem.
>>
>> Signed-off-by: Allen Hung <allen_hung@dell.com>
>> ---
>>  drivers/hid/hid-multitouch.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 95b7d61..4ef7006 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device
>> *hdev, struct hid_input *hi,
>>                         mt_store_field(usage, td, hi);
>>                         return 1;
>>                 case HID_DG_CONFIDENCE:
>> -                       if (cls->name == MT_CLS_WIN_8 &&
>> -                               field->application == HID_DG_TOUCHPAD) {
>> -                               cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
>> -                               cls->quirks |=
>> MT_QUIRK_VALID_IS_CONFIDENCE;
>> -                       }
>>                         mt_store_field(usage, td, hi);
>>                         return 1;
>>                 case HID_DG_TIPSWITCH:
>>
>
> This and patch 2 are:
>
> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
>
> (And I'm curious why 1.4.3 seems to have been pulled.  Might it have been
> this issue?  For better or for worse, I upgraded in the narrow window in
> which it was available on Dell's website.)
>

I should amend that Tested-by slightly: these patches seem to make the
problem merely about as bad as it was before.  It's still not perfect
-- I still occasionally get stuck touches.

--Andy

[toc] | [prev] | [next] | [standalone]

#1433184

On Mon, Jun 27, 2016 at 3:25 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote:
>>
>> This and patch 2 are:
>>
>> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
>>
>> (And I'm curious why 1.4.3 seems to have been pulled.  Might it have been
>> this issue?  For better or for worse, I upgraded in the narrow window in
>> which it was available on Dell's website.)
>>
>
> I should amend that Tested-by slightly: these patches seem to make the
> problem merely about as bad as it was before.  It's still not perfect
> -- I still occasionally get stuck touches.

On further investigation, I'm not getting stuck touches AFAICT.  I'm
experiencing an upgraded version of libinput being clever and
incorrectly deciding that I middle-clicked.  Sorry for the noise.

https://bugs.freedesktop.org/show_bug.cgi?id=96710

--Andy

[toc] | [prev] | [next] | [standalone]

#1432878

Hi,

I've applied the series to hid.git#for-4.7/upstream-fixes

Thanks everybody,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web