Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433000 > unrolled thread

[PATCH] mg_disk: fix error path in mg_probe()

Back to article view | Back to linux.kernel

Contents

  [PATCH] mg_disk: fix error path in mg_probe() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-06-28 15:50 +0200
    Re: [PATCH] mg_disk: fix error path in mg_probe() Jens Axboe <axboe@kernel.dk> - 2016-06-28 19:10 +0200

#1433000 — [PATCH] mg_disk: fix error path in mg_probe()

MG_DISK_MAJ is defined as 0 so dynamic block major number
allocation is used by the driver and the assigned major
number is stored in host->major.  This patch fixes error
path in mg_probe() to use host->major instead of using
MG_DISK_MAJ.

Cc: unsik Kim <donari75@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/block/mg_disk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
index 1ee3918..e937fcf7 100644
--- a/drivers/block/mg_disk.c
+++ b/drivers/block/mg_disk.c
@@ -1015,7 +1015,7 @@ probe_err_7:
 probe_err_6:
 	blk_cleanup_queue(host->breq);
 probe_err_5:
-	unregister_blkdev(MG_DISK_MAJ, MG_DISK_NAME);
+	unregister_blkdev(host->major, MG_DISK_NAME);
 probe_err_4:
 	if (!prv_data->use_polling)
 		free_irq(host->irq, host);
-- 
1.9.1

[toc] | [next] | [standalone]

#1433135

On 06/28/2016 07:42 AM, Bartlomiej Zolnierkiewicz wrote:
> MG_DISK_MAJ is defined as 0 so dynamic block major number
> allocation is used by the driver and the assigned major
> number is stored in host->major.  This patch fixes error
> path in mg_probe() to use host->major instead of using
> MG_DISK_MAJ.

Added, thanks Bart.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web