Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430624 > unrolled thread

Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices

Started byJoseph Salisbury <joseph.salisbury@canonical.com>
First post2016-06-24 14:10 +0200
Last post2016-07-06 22:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed  devices Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-06-24 14:10 +0200
    Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed  devices Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-06-28 17:10 +0200
      Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed  devices Alan Stern <stern@rowland.harvard.edu> - 2016-06-28 17:50 +0200
        Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed  devices Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-07-06 22:30 +0200

#1430624 — Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices

FromJoseph Salisbury <joseph.salisbury@canonical.com>
Date2016-06-24 14:10 +0200
SubjectRe: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices
Message-ID<rNy5P-7Tc-11@gated-at.bofh.it>
On 06/22/2016 12:14 PM, Greg KH wrote:
> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote:
>> Hi Rupesh,
>>
>> A kernel bug report was opened against Ubuntu [0].  After a kernel
>> bisect, it was found that reverting the following commit resolved this bug:
>>
>> commit a8425292816ceaa8c49e29d2114e85d85a73e080
>> Author: Rupesh Tatiya <rtatiya@codeaurora.org>
>> Date:   Tue Apr 14 16:36:55 2015 +0530
>>
>>     usb: Enable LPM for USB 2.01+ full-speed devices
>>
>>
>> The regression was introduced as of v4.2-rc1.
>>
>> I was hoping to get your feedback, since you are the patch author.  Do
>> you think gathering any additional data will help diagnose this issue,
>> or would it be best to submit a revert request?
> Does the problem still happen with 4.7-rc4 or even 4.6?
>
> 4.2 is pretty old and obsolete you know :)
>
> thanks,
>
> greg k-h
The regression does exist in 4.6-rc2.  I'll have the latest mainline
4.7-rc4 kernel tested.

[toc] | [next] | [standalone]

#1433047

FromJoseph Salisbury <joseph.salisbury@canonical.com>
Date2016-06-28 17:10 +0200
Message-ID<rP2Od-hD-13@gated-at.bofh.it>
In reply to#1430624
On 06/24/2016 08:06 AM, Joseph Salisbury wrote:
> On 06/22/2016 12:14 PM, Greg KH wrote:
>> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote:
>>> Hi Rupesh,
>>>
>>> A kernel bug report was opened against Ubuntu [0].  After a kernel
>>> bisect, it was found that reverting the following commit resolved this bug:
>>>
>>> commit a8425292816ceaa8c49e29d2114e85d85a73e080
>>> Author: Rupesh Tatiya <rtatiya@codeaurora.org>
>>> Date:   Tue Apr 14 16:36:55 2015 +0530
>>>
>>>     usb: Enable LPM for USB 2.01+ full-speed devices
>>>
>>>
>>> The regression was introduced as of v4.2-rc1.
>>>
>>> I was hoping to get your feedback, since you are the patch author.  Do
>>> you think gathering any additional data will help diagnose this issue,
>>> or would it be best to submit a revert request?
>> Does the problem still happen with 4.7-rc4 or even 4.6?
>>
>> 4.2 is pretty old and obsolete you know :)
>>
>> thanks,
>>
>> greg k-h
> The regression does exist in 4.6-rc2.  I'll have the latest mainline
> 4.7-rc4 kernel tested.
The 4.7-rc4 kernel still exhibits the bug.

[toc] | [prev] | [next] | [standalone]

#1433078

FromAlan Stern <stern@rowland.harvard.edu>
Date2016-06-28 17:50 +0200
Message-ID<rP3qV-uu-5@gated-at.bofh.it>
In reply to#1433047
On Tue, 28 Jun 2016, Joseph Salisbury wrote:

> On 06/24/2016 08:06 AM, Joseph Salisbury wrote:
> > On 06/22/2016 12:14 PM, Greg KH wrote:
> >> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote:
> >>> Hi Rupesh,
> >>>
> >>> A kernel bug report was opened against Ubuntu [0].  After a kernel
> >>> bisect, it was found that reverting the following commit resolved this bug:
> >>>
> >>> commit a8425292816ceaa8c49e29d2114e85d85a73e080
> >>> Author: Rupesh Tatiya <rtatiya@codeaurora.org>
> >>> Date:   Tue Apr 14 16:36:55 2015 +0530
> >>>
> >>>     usb: Enable LPM for USB 2.01+ full-speed devices
> >>>
> >>>
> >>> The regression was introduced as of v4.2-rc1.
> >>>
> >>> I was hoping to get your feedback, since you are the patch author.  Do
> >>> you think gathering any additional data will help diagnose this issue,
> >>> or would it be best to submit a revert request?
> >> Does the problem still happen with 4.7-rc4 or even 4.6?
> >>
> >> 4.2 is pretty old and obsolete you know :)
> >>
> >> thanks,
> >>
> >> greg k-h
> > The regression does exist in 4.6-rc2.  I'll have the latest mainline
> > 4.7-rc4 kernel tested.
> The 4.7-rc4 kernel still exhibits the bug.

Have you tried adding a NO_LPM quirk entry for this device, as I 
suggested in an earlier email?  I can write a patch for this, if you 
want.

Alan Stern

[toc] | [prev] | [next] | [standalone]

#1437933

FromJoseph Salisbury <joseph.salisbury@canonical.com>
Date2016-07-06 22:30 +0200
Message-ID<rS1Ch-5tE-13@gated-at.bofh.it>
In reply to#1433078
On 06/28/2016 11:40 AM, Alan Stern wrote:
> On Tue, 28 Jun 2016, Joseph Salisbury wrote:
>
>> On 06/24/2016 08:06 AM, Joseph Salisbury wrote:
>>> On 06/22/2016 12:14 PM, Greg KH wrote:
>>>> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote:
>>>>> Hi Rupesh,
>>>>>
>>>>> A kernel bug report was opened against Ubuntu [0].  After a kernel
>>>>> bisect, it was found that reverting the following commit resolved this bug:
>>>>>
>>>>> commit a8425292816ceaa8c49e29d2114e85d85a73e080
>>>>> Author: Rupesh Tatiya <rtatiya@codeaurora.org>
>>>>> Date:   Tue Apr 14 16:36:55 2015 +0530
>>>>>
>>>>>     usb: Enable LPM for USB 2.01+ full-speed devices
>>>>>
>>>>>
>>>>> The regression was introduced as of v4.2-rc1.
>>>>>
>>>>> I was hoping to get your feedback, since you are the patch author.  Do
>>>>> you think gathering any additional data will help diagnose this issue,
>>>>> or would it be best to submit a revert request?
>>>> Does the problem still happen with 4.7-rc4 or even 4.6?
>>>>
>>>> 4.2 is pretty old and obsolete you know :)
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>> The regression does exist in 4.6-rc2.  I'll have the latest mainline
>>> 4.7-rc4 kernel tested.
>> The 4.7-rc4 kernel still exhibits the bug.
> Have you tried adding a NO_LPM quirk entry for this device, as I 
> suggested in an earlier email?  I can write a patch for this, if you 
> want.
>
> Alan Stern
>
Yes, adding a NO_LPM quirk entry resolves the bug.  I'll submit a patch
shortly, it is basically these lines added to usb_quirk_list[]:

+       /* ELAN Microelectronics Touchscreen */
+       { USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },

Thanks for the suggestion, Alan!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web