Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432684 > unrolled thread

[PATCH v4 0/6] mfd: tps65218: Clean ups

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 0/6] mfd: tps65218: Clean ups  Keerthy <j-keerthy@ti.com> - 2016-06-28 11:30 +0200
    [PATCH v4 4/6] gpio: tps65218-gpio: Add platform_device_id table Keerthy <j-keerthy@ti.com> - 2016-06-28 11:30 +0200
    Re: [PATCH v4 0/6] mfd: tps65218: Clean ups Keerthy <a0393675@ti.com> - 2016-06-28 14:30 +0200

#1432684 — [PATCH v4 0/6] mfd: tps65218: Clean ups

The series cleans up mainly the regulator driver and implements
the device tree parsing using the regulator framework. Removes
all the redundant compatibles for the individual regulators.
Adds platform_device_id table for the gpio and power button modules.

One of the patch removes redundant read wrapper and makes
use of regmap_read wherever necessary.

The series is checked for all the regulator registrations on
am437x-gp-evm and am437x-sk-evm.

Boot log on am437x-sk-evm: http://pastebin.ubuntu.com/18016754/

Changes in v4:

For gpio-tps65218 reatined the compatible table.
Fixed missing ';' in the power button patch.
Fixed comments on the Documentation patch.
Split the Device Tree patches to a separate series.

Changes in v3:

Missed making corresponding changes in the power button and gpio
drivers. Added couple of patches to fix them to use mfd_cell way
of parsing.

Keerthy (6):
  mfd: tps65218: Remove redundant read wrapper
  Documentation: regulator: tps65218: Update examples
  input: tps65218-pwrbutton: Add platform_device_id table
  gpio: tps65218-gpio: Add platform_device_id table
  mfd: tps65218: Use mfd_add_devices instead of of_platform_populate
  regulator: tps65218: Remove all the compatibles

 .../devicetree/bindings/regulator/tps65218.txt     |  87 ++++++++++---
 drivers/gpio/gpio-tps65218.c                       |  10 +-
 drivers/input/misc/tps65218-pwrbutton.c            |  10 +-
 drivers/mfd/tps65218.c                             |  32 ++---
 drivers/regulator/tps65218-regulator.c             | 134 ++++++++-------------
 include/linux/mfd/tps65218.h                       |   2 -
 6 files changed, 152 insertions(+), 123 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1432685 — [PATCH v4 4/6] gpio: tps65218-gpio: Add platform_device_id table

platform_device_id table is needed for adding the tps65218-gpio
module to the mfd_cell array.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Changes in v4:

  * Retained the compatible strings in order to interrogate the DT in the
    normal way.

 drivers/gpio/gpio-tps65218.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
index 0f9d9bd..0961f3a 100644
--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -231,6 +231,12 @@ static const struct of_device_id tps65218_dt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, tps65218_dt_match);
 
+static const struct platform_device_id tps65218_gpio_id_table[] = {
+	{ "tps65218-gpio", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, tps65218_gpio_id_table);
+
 static struct platform_driver tps65218_gpio_driver = {
 	.driver = {
 		.name = "tps65218-gpio",
@@ -238,6 +244,7 @@ static struct platform_driver tps65218_gpio_driver = {
 	},
 	.probe = tps65218_gpio_probe,
 	.remove = tps65218_gpio_remove,
+	.id_table = tps65218_gpio_id_table,
 };
 
 module_platform_driver(tps65218_gpio_driver);
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1432938

On Tuesday 28 June 2016 02:52 PM, Keerthy wrote:
> The series cleans up mainly the regulator driver and implements
> the device tree parsing using the regulator framework. Removes
> all the redundant compatibles for the individual regulators.
> Adds platform_device_id table for the gpio and power button modules.
>
> One of the patch removes redundant read wrapper and makes
> use of regmap_read wherever necessary.
>
> The series is checked for all the regulator registrations on
> am437x-gp-evm and am437x-sk-evm.
>
> Boot log on am437x-sk-evm: http://pastebin.ubuntu.com/18016754/

Seems like with https://lkml.org/lkml/2016/6/24/122 pulled in. Only
mfd and regulator patches need a bit of re-basing. I am sending a v6
of the series with all the driver patches.

>
> Changes in v4:
>
> For gpio-tps65218 reatined the compatible table.
> Fixed missing ';' in the power button patch.
> Fixed comments on the Documentation patch.
> Split the Device Tree patches to a separate series.
>
> Changes in v3:
>
> Missed making corresponding changes in the power button and gpio
> drivers. Added couple of patches to fix them to use mfd_cell way
> of parsing.
>
> Keerthy (6):
>    mfd: tps65218: Remove redundant read wrapper
>    Documentation: regulator: tps65218: Update examples
>    input: tps65218-pwrbutton: Add platform_device_id table
>    gpio: tps65218-gpio: Add platform_device_id table
>    mfd: tps65218: Use mfd_add_devices instead of of_platform_populate
>    regulator: tps65218: Remove all the compatibles
>
>   .../devicetree/bindings/regulator/tps65218.txt     |  87 ++++++++++---
>   drivers/gpio/gpio-tps65218.c                       |  10 +-
>   drivers/input/misc/tps65218-pwrbutton.c            |  10 +-
>   drivers/mfd/tps65218.c                             |  32 ++---
>   drivers/regulator/tps65218-regulator.c             | 134 ++++++++-------------
>   include/linux/mfd/tps65218.h                       |   2 -
>   6 files changed, 152 insertions(+), 123 deletions(-)
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web