Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432429 > unrolled thread
| Started by | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| First post | 2016-06-28 05:20 +0200 |
| Last post | 2016-06-29 11:00 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-28 05:20 +0200
Re: [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-29 11:00 +0200
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Date | 2016-06-28 05:20 +0200 |
| Subject | [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc |
| Message-ID | <rORJ7-19W-7@gated-at.bofh.it> |
Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
that it is not 16550 compatibal.
Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out
and serial_in in ACPI.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/tty/serial/8250/8250_dw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 65f3da7..7571b0f 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -301,8 +301,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
p->iotype = UPIO_MEM32;
p->regshift = 2;
p->serial_in = dw8250_serial_in32;
- /* So far none of there implement the Busy Functionality */
- data->uart_16550_compatible = true;
+ p->serial_out = dw8250_serial_out32;
+
+ /* Hisilicon 8250 dw uart is not 16550 compatible */
+ if (!acpi_dev_found("HISI0031"))
+ data->uart_16550_compatible = true;
}
/* Platforms with iDMA */
@@ -618,6 +621,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
{ "APMC0D08", 0},
{ "AMD0020", 0 },
{ "AMDI0020", 0 },
+ { "HISI0031", 0 },
{ },
};
MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
--
1.7.12.4
[toc] | [next] | [standalone]
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Date | 2016-06-29 11:00 +0200 |
| Subject | Re: [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc |
| Message-ID | <rPjvI-1Zc-17@gated-at.bofh.it> |
| In reply to | #1432429 |
+cc linux-acpi@vger.kernel.org
On 2016/6/28 11:17, Kefeng Wang wrote:
> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful
> that it is not 16550 compatibal.
>
> Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out
> and serial_in in ACPI.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/tty/serial/8250/8250_dw.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 65f3da7..7571b0f 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -301,8 +301,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
> p->iotype = UPIO_MEM32;
> p->regshift = 2;
> p->serial_in = dw8250_serial_in32;
> - /* So far none of there implement the Busy Functionality */
> - data->uart_16550_compatible = true;
> + p->serial_out = dw8250_serial_out32;
> +
> + /* Hisilicon 8250 dw uart is not 16550 compatible */
> + if (!acpi_dev_found("HISI0031"))
> + data->uart_16550_compatible = true;
> }
>
> /* Platforms with iDMA */
> @@ -618,6 +621,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "APMC0D08", 0},
> { "AMD0020", 0 },
> { "AMDI0020", 0 },
> + { "HISI0031", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web