Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1432205 > unrolled thread

Re: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test

Started byShuah Khan <shuahkh@osg.samsung.com>
First post2016-06-27 20:00 +0200
Last post2016-06-27 20:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in  on-fault-limit test Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-27 20:00 +0200

#1432205 — Re: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test

FromShuah Khan <shuahkh@osg.samsung.com>
Date2016-06-27 20:00 +0200
SubjectRe: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test
Message-ID<rOIZc-3tG-35@gated-at.bofh.it>
On 06/20/2016 03:27 PM, Yannick Brosseau wrote:
> The default MEMLOCK limit is not big enough to accomodate all the
> current pages of the test program process, so the test fails
> at this step.
> By removing the MCL_CURRENT flag, we allow the mlockall
> call to succeed. The mmap is twice the size of the current limit,
> so it will still fail as expected.
> 
> Signed-off-by: Yannick Brosseau <scientist@fb.com>

Thanks for the patch. I will get this into 4.8-rc1.

-- Shuah

> ---
>  tools/testing/selftests/vm/on-fault-limit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
> index 245accc..0ae458f 100644
> --- a/tools/testing/selftests/vm/on-fault-limit.c
> +++ b/tools/testing/selftests/vm/on-fault-limit.c
> @@ -20,7 +20,7 @@ static int test_limit(void)
>  		return ret;
>  	}
>  
> -	if (mlockall(MCL_CURRENT | MCL_ONFAULT | MCL_FUTURE)) {
> +	if (mlockall(MCL_ONFAULT | MCL_FUTURE)) {
>  		perror("mlockall");
>  		return ret;
>  	}
> 

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web