Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432070 > unrolled thread
| Started by | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| First post | 2016-06-27 16:20 +0200 |
| Last post | 2016-06-27 17:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-06-27 16:20 +0200
Re: [PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path Lee Jones <lee.jones@linaro.org> - 2016-06-27 17:10 +0200
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2016-06-27 16:20 +0200 |
| Subject | [PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path |
| Message-ID | <rOFyh-1kx-9@gated-at.bofh.it> |
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- drivers/mfd/arizona-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index bf27179..e4f97b3 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -1462,7 +1462,7 @@ int arizona_dev_init(struct arizona *arizona) /* Set up for interrupts */ ret = arizona_irq_init(arizona); if (ret != 0) - goto err_reset; + goto err_pm; pm_runtime_set_autosuspend_delay(arizona->dev, 100); pm_runtime_use_autosuspend(arizona->dev); @@ -1486,6 +1486,8 @@ int arizona_dev_init(struct arizona *arizona) err_irq: arizona_irq_exit(arizona); +err_pm: + pm_runtime_disable(arizona->dev); err_reset: arizona_enable_reset(arizona); regulator_disable(arizona->dcvdd); -- 2.1.4
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-06-27 17:10 +0200 |
| Subject | Re: [PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path |
| Message-ID | <rOGkG-1Xk-27@gated-at.bofh.it> |
| In reply to | #1432070 |
On Mon, 27 Jun 2016, Charles Keepax wrote: > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > drivers/mfd/arizona-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index bf27179..e4f97b3 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -1462,7 +1462,7 @@ int arizona_dev_init(struct arizona *arizona) > /* Set up for interrupts */ > ret = arizona_irq_init(arizona); > if (ret != 0) > - goto err_reset; > + goto err_pm; > > pm_runtime_set_autosuspend_delay(arizona->dev, 100); > pm_runtime_use_autosuspend(arizona->dev); > @@ -1486,6 +1486,8 @@ int arizona_dev_init(struct arizona *arizona) > > err_irq: > arizona_irq_exit(arizona); > +err_pm: > + pm_runtime_disable(arizona->dev); > err_reset: > arizona_enable_reset(arizona); > regulator_disable(arizona->dcvdd); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web