Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430418 > unrolled thread

[GIT PULL] drm/mediatek: MT8173 gamma & dither support

Started byBibby Hsieh <bibby.hsieh@mediatek.com>
First post2016-06-24 09:30 +0200
Last post2016-07-04 07:30 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] drm/mediatek: MT8173 gamma & dither support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-06-24 09:30 +0200
    Re: [GIT PULL] drm/mediatek: MT8173 gamma & dither support Matthias Brugger <matthias.bgg@gmail.com> - 2016-06-27 12:30 +0200
      Re: [GIT PULL] drm/mediatek: MT8173 gamma & dither support Bibby Hsieh <bibby.hsieh@mediatek.com> - 2016-06-27 13:30 +0200
        Re: [GIT PULL] drm/mediatek: MT8173 gamma & dither support Emil Velikov <emil.l.velikov@gmail.com> - 2016-07-04 00:50 +0200
          Re: [GIT PULL] drm/mediatek: MT8173 gamma & dither support CK Hu <ck.hu@mediatek.com> - 2016-07-04 07:30 +0200

#1430418 — [GIT PULL] drm/mediatek: MT8173 gamma & dither support

FromBibby Hsieh <bibby.hsieh@mediatek.com>
Date2016-06-24 09:30 +0200
Subject[GIT PULL] drm/mediatek: MT8173 gamma & dither support
Message-ID<rNtIR-56t-15@gated-at.bofh.it>
Hi Dave,

Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments.

Thanks
Bibby

The following changes since commit 1a695a905c18548062509178b98bc91e67510864:

  Linux 4.7-rc1 (2016-05-29 16:29:24 GMT)

are available in the git repository at:

  git@github.com:BibbyHsieh/linux4.7-rc1.git

for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9:

  drm/mediatek: Add gamma correction

-------------------------------------------------------------------------
This is MT8173 gamma & dither support PATCH v2, based on 4.7-rc1.

Changes since v1:
 -According to the suggestion from Daniel,
  we used the new atomic color management.
 -Applied gamma function at GAMMA engine (path 2).
 -Made dithering function support hardware mirroring well.
 -Removed the bpc variable from mtk_drm_crtc struct.
-------------------------------------------------------------------------

Bibby Hsieh (2):
  drm/mediatek: Add gamma correction
  drm/mediatek: set mt8173 dithering function

 drivers/gpu/drm/mediatek/mtk_disp_ovl.c     |    3 +-
 drivers/gpu/drm/mediatek/mtk_disp_rdma.c    |    3 +-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |   26 ++++-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |    1 +
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |  147 ++++++++++++++++++++++++++-
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   16 ++-
 6 files changed, 184 insertions(+), 12 deletions(-)

-- 
1.7.9.5

[toc] | [next] | [standalone]

#1431906

FromMatthias Brugger <matthias.bgg@gmail.com>
Date2016-06-27 12:30 +0200
Message-ID<rOBXI-7pb-25@gated-at.bofh.it>
In reply to#1430418

On 06/24/2016 09:27 AM, Bibby Hsieh wrote:
> Hi Dave,
>
> Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments.
>
> Thanks
> Bibby
>
> The following changes since commit 1a695a905c18548062509178b98bc91e67510864:
>
>   Linux 4.7-rc1 (2016-05-29 16:29:24 GMT)
>
> are available in the git repository at:
>
>   git@github.com:BibbyHsieh/linux4.7-rc1.git
>
> for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9:
>
>   drm/mediatek: Add gamma correction
>
> -------------------------------------------------------------------------

As far as I can see, your branch has 3 patches on top from Eddie. It 
seems to me as if you didn't send your patches to the mailinglist before?
Anyway this branch does not fulfill the rules to get merged into the 
linux kernel.

Why do you send a pull request? The normal process is to send the 
patches via email and if the maintainer wants you can send a pull 
request once the patches are ready to be merged.

Regards,
Matthias

> This is MT8173 gamma & dither support PATCH v2, based on 4.7-rc1.
>
> Changes since v1:
>  -According to the suggestion from Daniel,
>   we used the new atomic color management.
>  -Applied gamma function at GAMMA engine (path 2).
>  -Made dithering function support hardware mirroring well.
>  -Removed the bpc variable from mtk_drm_crtc struct.
> -------------------------------------------------------------------------
>
> Bibby Hsieh (2):
>   drm/mediatek: Add gamma correction
>   drm/mediatek: set mt8173 dithering function
>
>  drivers/gpu/drm/mediatek/mtk_disp_ovl.c     |    3 +-
>  drivers/gpu/drm/mediatek/mtk_disp_rdma.c    |    3 +-
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |   26 ++++-
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |    1 +
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |  147 ++++++++++++++++++++++++++-
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   16 ++-
>  6 files changed, 184 insertions(+), 12 deletions(-)
>

[toc] | [prev] | [next] | [standalone]

#1431956

FromBibby Hsieh <bibby.hsieh@mediatek.com>
Date2016-06-27 13:30 +0200
Message-ID<rOCTN-809-41@gated-at.bofh.it>
In reply to#1431906
On Mon, 2016-06-27 at 12:20 +0200, Matthias Brugger wrote:
> 
> On 06/24/2016 09:27 AM, Bibby Hsieh wrote:
> > Hi Dave,
> >
> > Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments.
> >
> > Thanks
> > Bibby
> >
> > The following changes since commit 1a695a905c18548062509178b98bc91e67510864:
> >
> >   Linux 4.7-rc1 (2016-05-29 16:29:24 GMT)
> >
> > are available in the git repository at:
> >
> >   git@github.com:BibbyHsieh/linux4.7-rc1.git
> >
> > for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9:
> >
> >   drm/mediatek: Add gamma correction
> >
> > -------------------------------------------------------------------------
> 
> As far as I can see, your branch has 3 patches on top from Eddie. It 
> seems to me as if you didn't send your patches to the mailinglist before?
> Anyway this branch does not fulfill the rules to get merged into the 
> linux kernel.
> 
> Why do you send a pull request? The normal process is to send the 
> patches via email and if the maintainer wants you can send a pull 
> request once the patches are ready to be merged.
> 
> Regards,
> Matthias
> 

I sent v1 and v2 on 2016-06-14 and 06-17 respectively [0-8].
After I made some modifications according to Daniel Vetter's comments,
there had been no further comments and I sent the pull request as the
other sub-sys.

I'm sorry for my mistake, I will re-arrange the tree for upstream.
Next time, I will check with maintainer by email first, and sent the
pull request.

Thanks.
Bibby 
 
[0]https://patchwork.kernel.org/patch/9174941/
[1]https://patchwork.kernel.org/patch/9174855/
[2]https://patchwork.kernel.org/patch/9182361/
[3]https://patchwork.kernel.org/patch/9182367/
[4]https://lists.freedesktop.org/archives/dri-devel/2016-June/111178.html
[5]https://lists.freedesktop.org/archives/dri-devel/2016-June/111177.html
[6]https://lists.freedesktop.org/archives/dri-devel/2016-June/111176.html
[7]https://lists.freedesktop.org/archives/dri-devel/2016-June/110781.html
[8]https://lists.freedesktop.org/archives/dri-devel/2016-June/110782.html
[9]https://lists.freedesktop.org/archives/dri-devel/2016-June/110784.html

> > This is MT8173 gamma & dither support PATCH v2, based on 4.7-rc1.
> >
> > Changes since v1:
> >  -According to the suggestion from Daniel,
> >   we used the new atomic color management.
> >  -Applied gamma function at GAMMA engine (path 2).
> >  -Made dithering function support hardware mirroring well.
> >  -Removed the bpc variable from mtk_drm_crtc struct.
> > -------------------------------------------------------------------------
> >
> > Bibby Hsieh (2):
> >   drm/mediatek: Add gamma correction
> >   drm/mediatek: set mt8173 dithering function
> >
> >  drivers/gpu/drm/mediatek/mtk_disp_ovl.c     |    3 +-
> >  drivers/gpu/drm/mediatek/mtk_disp_rdma.c    |    3 +-
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |   26 ++++-
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |    1 +
> >  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |  147 ++++++++++++++++++++++++++-
> >  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   16 ++-
> >  6 files changed, 184 insertions(+), 12 deletions(-)
> >

[toc] | [prev] | [next] | [standalone]

#1436066

FromEmil Velikov <emil.l.velikov@gmail.com>
Date2016-07-04 00:50 +0200
Message-ID<rQYn8-657-23@gated-at.bofh.it>
In reply to#1431956
Hi Bibby,

On 27 June 2016 at 12:29, Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
> On Mon, 2016-06-27 at 12:20 +0200, Matthias Brugger wrote:
>>
>> On 06/24/2016 09:27 AM, Bibby Hsieh wrote:
>> > Hi Dave,
>> >
>> > Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments.
>> >
>> > Thanks
>> > Bibby
>> >
>> > The following changes since commit 1a695a905c18548062509178b98bc91e67510864:
>> >
>> >   Linux 4.7-rc1 (2016-05-29 16:29:24 GMT)
>> >
>> > are available in the git repository at:
>> >
>> >   git@github.com:BibbyHsieh/linux4.7-rc1.git
>> >
>> > for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9:
>> >
>> >   drm/mediatek: Add gamma correction
>> >
>> > -------------------------------------------------------------------------
>>
>> As far as I can see, your branch has 3 patches on top from Eddie. It
>> seems to me as if you didn't send your patches to the mailinglist before?
>> Anyway this branch does not fulfill the rules to get merged into the
>> linux kernel.
>>
>> Why do you send a pull request? The normal process is to send the
>> patches via email and if the maintainer wants you can send a pull
>> request once the patches are ready to be merged.
>>
>> Regards,
>> Matthias
>>
>
> I sent v1 and v2 on 2016-06-14 and 06-17 respectively [0-8].
> After I made some modifications according to Daniel Vetter's comments,
> there had been no further comments and I sent the pull request as the
> other sub-sys.
>
> I'm sorry for my mistake, I will re-arrange the tree for upstream.
> Next time, I will check with maintainer by email first, and sent the
> pull request.
>
It might be a bit hard to find out who's the maintainer considering
MAINTAINERS has no entry for this driver.

Looking at how things are going Philipp Zabel will be the more likely
person for the task, yet I would be nice if someone from the Mediatek
squad is helping him out - CK Hu perhaps ?

Regards,
Emil

[toc] | [prev] | [next] | [standalone]

#1436570

FromCK Hu <ck.hu@mediatek.com>
Date2016-07-04 07:30 +0200
Message-ID<rR4Cd-1Br-11@gated-at.bofh.it>
In reply to#1436066
Hi, Emil:

On Sun, 2016-07-03 at 23:43 +0100, Emil Velikov wrote:
> Hi Bibby,
> 
> On 27 June 2016 at 12:29, Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
> > On Mon, 2016-06-27 at 12:20 +0200, Matthias Brugger wrote:
> >>
> >> On 06/24/2016 09:27 AM, Bibby Hsieh wrote:
> >> > Hi Dave,
> >> >
> >> > Please consider merging this tag, which contains the v2 MT8173 gamma & dither function patches I sent on 2016-06-17, rebased onto v4.7-rc1. There have been no further comments.
> >> >
> >> > Thanks
> >> > Bibby
> >> >
> >> > The following changes since commit 1a695a905c18548062509178b98bc91e67510864:
> >> >
> >> >   Linux 4.7-rc1 (2016-05-29 16:29:24 GMT)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >   git@github.com:BibbyHsieh/linux4.7-rc1.git
> >> >
> >> > for you to fetch changes up to dd0eb773bc125f5e6bca735d19c08500dc3730f9:
> >> >
> >> >   drm/mediatek: Add gamma correction
> >> >
> >> > -------------------------------------------------------------------------
> >>
> >> As far as I can see, your branch has 3 patches on top from Eddie. It
> >> seems to me as if you didn't send your patches to the mailinglist before?
> >> Anyway this branch does not fulfill the rules to get merged into the
> >> linux kernel.
> >>
> >> Why do you send a pull request? The normal process is to send the
> >> patches via email and if the maintainer wants you can send a pull
> >> request once the patches are ready to be merged.
> >>
> >> Regards,
> >> Matthias
> >>
> >
> > I sent v1 and v2 on 2016-06-14 and 06-17 respectively [0-8].
> > After I made some modifications according to Daniel Vetter's comments,
> > there had been no further comments and I sent the pull request as the
> > other sub-sys.
> >
> > I'm sorry for my mistake, I will re-arrange the tree for upstream.
> > Next time, I will check with maintainer by email first, and sent the
> > pull request.
> >
> It might be a bit hard to find out who's the maintainer considering
> MAINTAINERS has no entry for this driver.
> 
> Looking at how things are going Philipp Zabel will be the more likely
> person for the task, yet I would be nice if someone from the Mediatek
> squad is helping him out - CK Hu perhaps ?
> 
> Regards,
> Emil

I'm willing to be one of Mediatek DRM driver maintainer. I wish this
would make things easier.

Regards,
CK

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web