Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431884 > unrolled thread

drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812: possible pointless variable ?

Back to article view | Back to linux.kernel

Contents

  drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812: possible  pointless variable ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-27 12:10 +0200
    [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable Matthias Beyer <mail@beyermatthias.de> - 2016-06-30 18:50 +0200
    [PATCH] Remove unused variable Matthias Beyer <mail@beyermatthias.de> - 2016-06-30 18:50 +0200

#1431884 — drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812: possible pointless variable ?

Hello there,

linux-4.7-rc5/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812]:
(style) Variable 'stretch_amount2' is assigned a value that is never
used.

Source code is

    else if (stretch_amount == 3 || stretch_amount == 4)
        stretch_amount2 = 1;

Suggest either use the variable in some way, or delete it.

Regards

David Binderman

[toc] | [next] | [standalone]

#1434735 — [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
index 64ee78f..1dcd52d 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
@@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
 {
 	uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
 	struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
-	uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
+	uint8_t i, stretch_amount, volt_offset = 0;
 	struct phm_ppt_v1_information *table_info =
 			(struct phm_ppt_v1_information *)(hwmgr->pptable);
 	struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
@@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
 	}
 
 	/* Populate CKS Lookup Table */
-	if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
-		stretch_amount2 = 0;
-	else if (stretch_amount == 3 || stretch_amount == 4)
-		stretch_amount2 = 1;
-	else {
+	if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
+			stretch_amount != 4 && stretch_amount != 5) {
 		phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
 				PHM_PlatformCaps_ClockStretcher);
 		PP_ASSERT_WITH_CODE(false,
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1434736 — [PATCH] Remove unused variable

Hi,

after reading your email, I created this patch.

**Please note all**: I'm getting into kernel dev right now (again), so I don't
even know how to test-compile this patch, let alone testing it.

You're more than welcome to teach me things.

Matthias Beyer (1):
  drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

 drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

-- 
2.9.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web