Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1430204 > unrolled thread

Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system

Started bySteven Rostedt <rostedt@goodmis.org>
First post2016-06-23 23:50 +0200
Last post2016-06-24 13:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to  the Make system Steven Rostedt <rostedt@goodmis.org> - 2016-06-23 23:50 +0200
    Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to  the Make system John Kacur <jkacur@redhat.com> - 2016-06-24 13:50 +0200

#1430204 — Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-06-23 23:50 +0200
SubjectRe: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system
Message-ID<rNkFz-7yS-5@gated-at.bofh.it>
On Thu, 23 Jun 2016 14:11:51 +0200
John Kacur <jkacur@redhat.com> wrote:


> index 9c50456f7419..f530488545e0 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -1,4 +1,6 @@
> +#ifndef _GNU_SOURCE
>  #define _GNU_SOURCE
> +#endif
>  #include <pthread.h>
>  #include <stdarg.h>
>  #include <stdlib.h>
> diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> index 8a813c494520..2794730febc4 100644
> --- a/src/sched_deadline/deadline_test.c
> +++ b/src/sched_deadline/deadline_test.c
> @@ -29,7 +29,9 @@
>   *    Look for "simple_test"
>   *
>   */
> +#ifndef _GNU_SOURCE
>  #define _GNU_SOURCE
> +#endif

I'd say nuke these if they are already defined via the Makefile or
something. I can move the define to the Makefile in my github too.

-- Steve

>  #include <pthread.h>
>  #include <stdarg.h>
>  #include <stdlib.h>

[toc] | [next] | [standalone]


#1430600

FromJohn Kacur <jkacur@redhat.com>
Date2016-06-24 13:50 +0200
Message-ID<rNxMt-7xb-5@gated-at.bofh.it>
In reply to#1430204

On Thu, 23 Jun 2016, Steven Rostedt wrote:

> On Thu, 23 Jun 2016 14:11:51 +0200
> John Kacur <jkacur@redhat.com> wrote:
> 
> 
> > index 9c50456f7419..f530488545e0 100644
> > --- a/src/sched_deadline/cyclicdeadline.c
> > +++ b/src/sched_deadline/cyclicdeadline.c
> > @@ -1,4 +1,6 @@
> > +#ifndef _GNU_SOURCE
> >  #define _GNU_SOURCE
> > +#endif
> >  #include <pthread.h>
> >  #include <stdarg.h>
> >  #include <stdlib.h>
> > diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> > index 8a813c494520..2794730febc4 100644
> > --- a/src/sched_deadline/deadline_test.c
> > +++ b/src/sched_deadline/deadline_test.c
> > @@ -29,7 +29,9 @@
> >   *    Look for "simple_test"
> >   *
> >   */
> > +#ifndef _GNU_SOURCE
> >  #define _GNU_SOURCE
> > +#endif
> 
> I'd say nuke these if they are already defined via the Makefile or
> something. I can move the define to the Makefile in my github too.
> 
> -- Steve

Agreed.

From 02b15d056e6127f773fb71f69c0c5fe393422a87 Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Fri, 24 Jun 2016 13:34:54 +0200
Subject: [PATCH] rt-tests-1.1.1: Remove _GNU_SOURCE from source files

Remove _GNU_SOURCE from source files since it is defined in the Makefile

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/rt-migrate-test/rt-migrate-test.c | 3 ---
 src/sched_deadline/cyclicdeadline.c   | 3 ---
 src/sched_deadline/deadline_test.c    | 3 ---
 3 files changed, 9 deletions(-)

diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
index d7b68ddac3e5..0a0bb77ab661 100644
--- a/src/rt-migrate-test/rt-migrate-test.c
+++ b/src/rt-migrate-test/rt-migrate-test.c
@@ -20,9 +20,6 @@
  *
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  */
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
 #include <stdio.h>
 #ifndef __USE_XOPEN2K
 # define __USE_XOPEN2K
diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index f530488545e0..fd78d315563e 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -1,6 +1,3 @@
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
 #include <pthread.h>
 #include <stdarg.h>
 #include <stdlib.h>
diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
index 2794730febc4..196dfecbbb78 100644
--- a/src/sched_deadline/deadline_test.c
+++ b/src/sched_deadline/deadline_test.c
@@ -29,9 +29,6 @@
  *    Look for "simple_test"
  *
  */
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
 #include <pthread.h>
 #include <stdarg.h>
 #include <stdlib.h>
-- 
2.4.11

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web