Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430019 > unrolled thread

[PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

Started byColin King <colin.king@canonical.com>
First post2016-06-23 19:50 +0200
Last post2016-06-23 22:10 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" Colin King <colin.king@canonical.com> - 2016-06-23 19:50 +0200
    Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->  "upgrade" Eli Billauer <eli.billauer@gmail.com> - 2016-06-23 21:10 +0200
    Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->  "upgrade" Joe Perches <joe@perches.com> - 2016-06-23 21:10 +0200
      Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->  "upgrade" Eli Billauer <eli.billauer@gmail.com> - 2016-06-23 21:30 +0200
        Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->  "upgrade" Colin Ian King <colin.king@canonical.com> - 2016-06-23 22:00 +0200
          Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->  "upgrade" Eli Billauer <eli.billauer@gmail.com> - 2016-06-23 22:10 +0200

#1430019 — [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromColin King <colin.king@canonical.com>
Date2016-06-23 19:50 +0200
Subject[PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNgVj-4UA-13@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

trivial fix to spelling mistake in dev_err message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/char/xillybus/xillybus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
index dcd19f3..8586a85 100644
--- a/drivers/char/xillybus/xillybus_core.c
+++ b/drivers/char/xillybus/xillybus_core.c
@@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
 	/* Check version number. Accept anything below 0x82 for now. */
 	if (*version > 0x82) {
 		dev_err(endpoint->dev,
-			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
+			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
 			*version);
 		return -ENODEV;
 	}
-- 
2.8.1

[toc] | [next] | [standalone]

#1430058 — Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromEli Billauer <eli.billauer@gmail.com>
Date2016-06-23 21:10 +0200
SubjectRe: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNiaJ-60P-5@gated-at.bofh.it>
In reply to#1430019
I stand corrected. Thanks.

Acked-by: Eli Billauer <eli.billauer@gmail.com>

On 23/06/16 20:48, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   drivers/char/xillybus/xillybus_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
> index dcd19f3..8586a85 100644
> --- a/drivers/char/xillybus/xillybus_core.c
> +++ b/drivers/char/xillybus/xillybus_core.c
> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
>   	/* Check version number. Accept anything below 0x82 for now. */
>   	if (*version>  0x82) {
>   		dev_err(endpoint->dev,
> -			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
> +			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
>   			*version);
>   		return -ENODEV;
>   	}
>

[toc] | [prev] | [next] | [standalone]

#1430061 — Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromJoe Perches <joe@perches.com>
Date2016-06-23 21:10 +0200
SubjectRe: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNiaJ-60P-15@gated-at.bofh.it>
In reply to#1430019
On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
> trivial fix to spelling mistake in dev_err message
[]
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
[]
> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
>  	/* Check version number. Accept anything below 0x82 for now. */
>  	if (*version > 0x82) {

trivia:  code doesn't match comment above it.

>  		dev_err(endpoint->dev,
> -			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
> +			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
>  			*version);
>  		return -ENODEV;
>  	}

[toc] | [prev] | [next] | [standalone]

#1430087 — Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromEli Billauer <eli.billauer@gmail.com>
Date2016-06-23 21:30 +0200
SubjectRe: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNiu7-68M-55@gated-at.bofh.it>
In reply to#1430061
This is getting increasingly embarrassing. I suppose a single patch, 
fixing both silly mistakes (of mine), would be in place.

Colin, would you prefer to submit a patch with both issues fixed 
yourself, or should I take care of it?

Thanks, both of you.
    Eli

On 23/06/16 22:05, Joe Perches wrote:
> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>    
>> trivial fix to spelling mistake in dev_err message
>>      
> []
>    
>> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
>>      
> []
>    
>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
>>   	/* Check version number. Accept anything below 0x82 for now. */
>>   	if (*version>  0x82) {
>>      
> trivia:  code doesn't match comment above it.
>
>    
>>   		dev_err(endpoint->dev,
>> -			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
>> +			"No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
>>   			*version);
>>   		return -ENODEV;
>>   	}
>>      
>

[toc] | [prev] | [next] | [standalone]

#1430116 — Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromColin Ian King <colin.king@canonical.com>
Date2016-06-23 22:00 +0200
SubjectRe: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNiX7-6lq-15@gated-at.bofh.it>
In reply to#1430087
On 23/06/16 20:23, Eli Billauer wrote:
> This is getting increasingly embarrassing. I suppose a single patch,
> fixing both silly mistakes (of mine), would be in place.
> 
> Colin, would you prefer to submit a patch with both issues fixed
> yourself, or should I take care of it?

Eli, I don't mind if you fix it up.

> 
> Thanks, both of you.
>    Eli
> 
> On 23/06/16 22:05, Joe Perches wrote:
>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>   
>>> trivial fix to spelling mistake in dev_err message
>>>      
>> []
>>   
>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>> b/drivers/char/xillybus/xillybus_core.c
>>>      
>> []
>>   
>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>> *endpoint)
>>>       /* Check version number. Accept anything below 0x82 for now. */
>>>       if (*version>  0x82) {
>>>      
>> trivia:  code doesn't match comment above it.
>>
>>   
>>>           dev_err(endpoint->dev,
>>> -            "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgarde. Aborting.\n",
>>> +            "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgrade. Aborting.\n",
>>>               *version);
>>>           return -ENODEV;
>>>       }
>>>      
>>    
>

[toc] | [prev] | [next] | [standalone]

#1430123 — Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"

FromEli Billauer <eli.billauer@gmail.com>
Date2016-06-23 22:10 +0200
SubjectRe: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Message-ID<rNj6O-6Ez-7@gated-at.bofh.it>
In reply to#1430116
OK, I'll submit a patch quite soon. Thanks again.

    Eli

On 23/06/16 22:51, Colin Ian King wrote:
> On 23/06/16 20:23, Eli Billauer wrote:
>    
>> This is getting increasingly embarrassing. I suppose a single patch,
>> fixing both silly mistakes (of mine), would be in place.
>>
>> Colin, would you prefer to submit a patch with both issues fixed
>> yourself, or should I take care of it?
>>      
> Eli, I don't mind if you fix it up.
>
>    
>> Thanks, both of you.
>>     Eli
>>
>> On 23/06/16 22:05, Joe Perches wrote:
>>      
>>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>>
>>>        
>>>> trivial fix to spelling mistake in dev_err message
>>>>
>>>>          
>>> []
>>>
>>>        
>>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>>> b/drivers/char/xillybus/xillybus_core.c
>>>>
>>>>          
>>> []
>>>
>>>        
>>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>>> *endpoint)
>>>>        /* Check version number. Accept anything below 0x82 for now. */
>>>>        if (*version>   0x82) {
>>>>
>>>>          
>>> trivia:  code doesn't match comment above it.
>>>
>>>
>>>        
>>>>            dev_err(endpoint->dev,
>>>> -            "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgarde. Aborting.\n",
>>>> +            "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgrade. Aborting.\n",
>>>>                *version);
>>>>            return -ENODEV;
>>>>        }
>>>>
>>>>          
>>>
>>>        
>>      
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web