Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431023 > unrolled thread
| Started by | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| First post | 2016-06-25 02:20 +0200 |
| Last post | 2016-07-05 12:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Andrew Duggan <aduggan@synaptics.com> - 2016-06-25 02:20 +0200
Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Nick Dyer <nick.dyer@itdev.co.uk> - 2016-07-05 12:20 +0200
| From | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| Date | 2016-06-25 02:20 +0200 |
| Subject | [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data |
| Message-ID | <rNJui-6KT-25@gated-at.bofh.it> |
The pointer to struct rmi_function in f12_data is never set and was never
used. The fn pointer is also stored in rmi_2d_sensor which is a member of
f12_data.
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
drivers/input/rmi4/rmi_f12.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 041a91d..7d66766 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -27,7 +27,6 @@ enum rmi_f12_object_type {
};
struct f12_data {
- struct rmi_function *fn;
struct rmi_2d_sensor sensor;
struct rmi_2d_sensor_platform_data sensor_pdata;
bool has_dribble;
--
2.5.0
[toc] | [next] | [standalone]
| From | Nick Dyer <nick.dyer@itdev.co.uk> |
|---|---|
| Date | 2016-07-05 12:20 +0200 |
| Subject | Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data |
| Message-ID | <rRvCq-1tJ-13@gated-at.bofh.it> |
| In reply to | #1431023 |
On 25/06/2016 01:19, Andrew Duggan wrote:
> The pointer to struct rmi_function in f12_data is never set and was never
> used. The fn pointer is also stored in rmi_2d_sensor which is a member of
> f12_data.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Reviewed-by: Nick Dyer <nick@shmanahar.org>
> ---
> drivers/input/rmi4/rmi_f12.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 041a91d..7d66766 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -27,7 +27,6 @@ enum rmi_f12_object_type {
> };
>
> struct f12_data {
> - struct rmi_function *fn;
> struct rmi_2d_sensor sensor;
> struct rmi_2d_sensor_platform_data sensor_pdata;
> bool has_dribble;
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web