Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1430104 > unrolled thread
| Started by | megous@megous.com |
|---|---|
| First post | 2016-06-23 21:40 +0200 |
| Last post | 2016-06-25 00:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One megous@megous.com - 2016-06-23 21:40 +0200
Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 05:00 +0200
Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Julian Calaby <julian.calaby@gmail.com> - 2016-06-24 05:00 +0200
Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Ondřej Jirman <megous@megous.com> - 2016-06-25 00:50 +0200
| From | megous@megous.com |
|---|---|
| Date | 2016-06-23 21:40 +0200 |
| Subject | [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One |
| Message-ID | <rNiDM-6cT-41@gated-at.bofh.it> |
From: Ondrej Jirman <megous@megous.com>
Xulong Orange Pi One uses GPIO based regulator that
switches between two voltages: 1.1V and 1.3V. The
regulator is controlled from the PL6 pin.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 0adf932..ce4ba91 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -88,6 +88,25 @@
gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
};
};
+
+ vdd_soc: gpio-regulator {
+ compatible = "regulator-gpio";
+
+ regulator-name = "soc-vdd-supply";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-boot-on;
+ regulator-type = "voltage";
+
+ gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
+ states = <1100000 0x0
+ 1300000 0x1>;
+
+ startup-delay-us = <100000>;
+ enable-active-high;
+ };
+};
+
};
&ehci1 {
@@ -131,6 +150,13 @@
allwinner,drive = <SUN4I_PINCTRL_10_MA>;
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
};
+
+ soc_reg0: soc_reg@0 {
+ allwinner,pins = "PL6";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
};
&uart0 {
--
2.9.0
[toc] | [next] | [standalone]
| From | Julian Calaby <julian.calaby@gmail.com> |
|---|---|
| Date | 2016-06-24 05:00 +0200 |
| Subject | Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One |
| Message-ID | <rNpvz-2g4-5@gated-at.bofh.it> |
| In reply to | #1430104 |
Hi Ondrej,
On Fri, Jun 24, 2016 at 5:21 AM, <megous@megous.com> wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Xulong Orange Pi One uses GPIO based regulator that
> switches between two voltages: 1.1V and 1.3V. The
> regulator is controlled from the PL6 pin.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> index 0adf932..ce4ba91 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> @@ -88,6 +88,25 @@
> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
> };
> };
> +
> + vdd_soc: gpio-regulator {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "soc-vdd-supply";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-boot-on;
> + regulator-type = "voltage";
> +
> + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
> + states = <1100000 0x0
> + 1300000 0x1>;
> +
> + startup-delay-us = <100000>;
> + enable-active-high;
> + };
> +};
> +
Also, isn't adding another closing bracket here a syntax error?
> };
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
[toc] | [prev] | [next] | [standalone]
| From | Julian Calaby <julian.calaby@gmail.com> |
|---|---|
| Date | 2016-06-24 05:00 +0200 |
| Subject | Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One |
| Message-ID | <rNpvA-2g4-15@gated-at.bofh.it> |
| In reply to | #1430104 |
Hi Ondrej,
On Fri, Jun 24, 2016 at 5:21 AM, <megous@megous.com> wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Xulong Orange Pi One uses GPIO based regulator that
> switches between two voltages: 1.1V and 1.3V. The
> regulator is controlled from the PL6 pin.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> index 0adf932..ce4ba91 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> @@ -88,6 +88,25 @@
> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
> };
> };
> +
> + vdd_soc: gpio-regulator {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "soc-vdd-supply";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-boot-on;
> + regulator-type = "voltage";
> +
> + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
> + states = <1100000 0x0
> + 1300000 0x1>;
> +
> + startup-delay-us = <100000>;
> + enable-active-high;
Don't you need to reference the new pinctl node in this one?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
[toc] | [prev] | [next] | [standalone]
| From | Ondřej Jirman <megous@megous.com> |
|---|---|
| Date | 2016-06-25 00:50 +0200 |
| Subject | Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One |
| Message-ID | <rNI5b-5LK-3@gated-at.bofh.it> |
| In reply to | #1430321 |
[Multipart message — attachments visible in raw view] — view raw
Hi Julian,
thank you for the review. You're right. I added the pinctrl client
nodes. Also the patches were split incorrectly, so I fixed that too.
regards,
Ondrej
On 24.6.2016 04:51, Julian Calaby wrote:
> Hi Ondrej,
>
> On Fri, Jun 24, 2016 at 5:21 AM, <megous@megous.com> wrote:
>> From: Ondrej Jirman <megous@megous.com>
>>
>> Xulong Orange Pi One uses GPIO based regulator that
>> switches between two voltages: 1.1V and 1.3V. The
>> regulator is controlled from the PL6 pin.
>>
>> Signed-off-by: Ondrej Jirman <megous@megous.com>
>> ---
>> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
>> index 0adf932..ce4ba91 100644
>> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
>> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
>> @@ -88,6 +88,25 @@
>> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
>> };
>> };
>> +
>> + vdd_soc: gpio-regulator {
>> + compatible = "regulator-gpio";
>> +
>> + regulator-name = "soc-vdd-supply";
>> + regulator-min-microvolt = <1100000>;
>> + regulator-max-microvolt = <1300000>;
>> + regulator-boot-on;
>> + regulator-type = "voltage";
>> +
>> + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
>> + states = <1100000 0x0
>> + 1300000 0x1>;
>> +
>> + startup-delay-us = <100000>;
>> + enable-active-high;
>
> Don't you need to reference the new pinctl node in this one?
>
> Thanks,
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web