Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430744 > unrolled thread

Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

Started by"Andrew F. Davis" <afd@ti.com>
First post2016-06-24 17:10 +0200
Last post2016-06-24 22:20 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple  Current/Voltage Monitors "Andrew F. Davis" <afd@ti.com> - 2016-06-24 17:10 +0200
    Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple  Current/Voltage Monitors Guenter Roeck <linux@roeck-us.net> - 2016-06-24 18:50 +0200
      Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple  Current/Voltage Monitors "Andrew F. Davis" <afd@ti.com> - 2016-06-24 19:40 +0200
        Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple  Current/Voltage Monitors Guenter Roeck <linux@roeck-us.net> - 2016-06-24 22:20 +0200

#1430744 — Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

From"Andrew F. Davis" <afd@ti.com>
Date2016-06-24 17:10 +0200
SubjectRe: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors
Message-ID<rNAU2-1d8-23@gated-at.bofh.it>
On 06/18/2016 10:16 AM, Guenter Roeck wrote:
>
> The chip registers are 16 bit. Can you repeat the command using the "w"
> option ?
> 

# i2cdump -y 2 0x40 w
     0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
00: 2771 0000 0000 0000 0000 0000 0000 f87f
08: f87f f87f f87f f87f f87f 0000 fe7f 0300
10: 1027 2823 ffff ffff ffff ffff ffff ffff
18: ffff ffff XXXX f8f8 ffff ffff 4954 2032
20: 2771 0000 0000 0000 0000 0000 0000 f87f
28: f87f f87f f87f f87f f87f 0000 fe7f 0300
30: 1027 2823 ffff ffff ffff ffff ffff ffff
38: ffff ffff XXXX f8f8 ffff ffff 4954 2032
40: 2771 0000 0000 0000 0000 0000 0000 f87f
48: f87f f87f f87f f87f f87f 0000 fe7f 0300
50: 1027 2823 ffff ffff ffff ffff ffff ffff
58: ffff ffff XXXX f8f8 ffff ffff 4954 2032
60: 2771 0000 0000 0000 0000 0000 0000 f87f
68: f87f f87f f87f f87f f87f 0000 fe7f 0300
70: 1027 2823 ffff ffff ffff ffff ffff ffff
78: ffff ffff XXXX f8f8 ffff ffff 4954 2032
80: 2771 0000 0000 0000 0000 0000 0000 f87f
88: f87f f87f f87f f87f f87f 0000 fe7f 0300
90: 1027 2823 ffff ffff ffff ffff ffff ffff
98: ffff ffff XXXX f8f8 ffff ffff 4954 2032
a0: 2771 0000 0000 0000 0000 0000 0000 f87f
a8: f87f f87f f87f f87f f87f 0000 fe7f 0300
b0: 1027 2823 ffff ffff ffff ffff ffff ffff
b8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
c0: 2771 0000 0000 0000 0000 0000 0000 f87f
c8: f87f f87f f87f f87f f87f 0000 fe7f 0300
d0: 1027 2823 ffff ffff ffff ffff ffff ffff
d8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
e0: 2771 0000 0000 0000 0000 0000 0000 f87f
e8: f87f f87f f87f f87f f87f 0000 fe7f 0300
f0: 1027 2823 ffff ffff ffff ffff ffff ffff
f8: ffff ffff XXXX f8f8 ffff ffff 4954 2032

[toc] | [next] | [standalone]

#1430806

FromGuenter Roeck <linux@roeck-us.net>
Date2016-06-24 18:50 +0200
Message-ID<rNCsN-28b-3@gated-at.bofh.it>
In reply to#1430744
On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote:
> On 06/18/2016 10:16 AM, Guenter Roeck wrote:
> >
> > The chip registers are 16 bit. Can you repeat the command using the "w"
> > option ?
> > 
> 
> # i2cdump -y 2 0x40 w
>      0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
> 00: 2771 0000 0000 0000 0000 0000 0000 f87f
> 08: f87f f87f f87f f87f f87f 0000 fe7f 0300
> 10: 1027 2823 ffff ffff ffff ffff ffff ffff
> 18: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> 20: 2771 0000 0000 0000 0000 0000 0000 f87f
> 28: f87f f87f f87f f87f f87f 0000 fe7f 0300
> 30: 1027 2823 ffff ffff ffff ffff ffff ffff
> 38: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> 40: 2771 0000 0000 0000 0000 0000 0000 f87f
> 48: f87f f87f f87f f87f f87f 0000 fe7f 0300
> 50: 1027 2823 ffff ffff ffff ffff ffff ffff
> 58: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> 60: 2771 0000 0000 0000 0000 0000 0000 f87f
> 68: f87f f87f f87f f87f f87f 0000 fe7f 0300
> 70: 1027 2823 ffff ffff ffff ffff ffff ffff
> 78: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> 80: 2771 0000 0000 0000 0000 0000 0000 f87f
> 88: f87f f87f f87f f87f f87f 0000 fe7f 0300
> 90: 1027 2823 ffff ffff ffff ffff ffff ffff
> 98: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> a0: 2771 0000 0000 0000 0000 0000 0000 f87f
> a8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> b0: 1027 2823 ffff ffff ffff ffff ffff ffff
> b8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> c0: 2771 0000 0000 0000 0000 0000 0000 f87f
> c8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> d0: 1027 2823 ffff ffff ffff ffff ffff ffff
> d8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> e0: 2771 0000 0000 0000 0000 0000 0000 f87f
> e8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> f0: 1027 2823 ffff ffff ffff ffff ffff ffff
> f8: ffff ffff XXXX f8f8 ffff ffff 4954 2032

Thanks a lot!

Guenter

[toc] | [prev] | [next] | [standalone]

#1430831

From"Andrew F. Davis" <afd@ti.com>
Date2016-06-24 19:40 +0200
Message-ID<rNDfb-2Hg-7@gated-at.bofh.it>
In reply to#1430806
On 06/24/2016 11:46 AM, Guenter Roeck wrote:
> On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote:
>> On 06/18/2016 10:16 AM, Guenter Roeck wrote:
>>>
>>> The chip registers are 16 bit. Can you repeat the command using the "w"
>>> option ?
>>>
>>
>> # i2cdump -y 2 0x40 w
>>      0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
>> 00: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 08: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 10: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 18: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 20: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 28: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 30: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 38: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 40: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 48: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 50: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 58: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 60: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 68: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 70: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 78: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> 80: 2771 0000 0000 0000 0000 0000 0000 f87f
>> 88: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> 90: 1027 2823 ffff ffff ffff ffff ffff ffff
>> 98: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> a0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> a8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> b0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> b8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> c0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> c8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> d0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> d8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
>> e0: 2771 0000 0000 0000 0000 0000 0000 f87f
>> e8: f87f f87f f87f f87f f87f 0000 fe7f 0300
>> f0: 1027 2823 ffff ffff ffff ffff ffff ffff
>> f8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> 
> Thanks a lot!
> 

Feel free to completely ignore the first register dump I sent, I did it
for the wrong device anyway :).

I had just gotten done reading this:
https://lkml.org/lkml/2015/12/10/459
and accidentally got EVMs confused did the test for the TMP461, but it
does look like on startup register 0x16 can be used to differentiate the
parts, if the TMP461 hadn't gone into a different driver.

Andrew

[toc] | [prev] | [next] | [standalone]

#1430918

FromGuenter Roeck <linux@roeck-us.net>
Date2016-06-24 22:20 +0200
Message-ID<rNFK2-4q7-7@gated-at.bofh.it>
In reply to#1430831
On Fri, Jun 24, 2016 at 12:30:56PM -0500, Andrew F. Davis wrote:
> On 06/24/2016 11:46 AM, Guenter Roeck wrote:
> > On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote:
> >> On 06/18/2016 10:16 AM, Guenter Roeck wrote:
> >>>
> >>> The chip registers are 16 bit. Can you repeat the command using the "w"
> >>> option ?
> >>>
> >>
> >> # i2cdump -y 2 0x40 w
> >>      0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
> >> 00: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> 08: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> 10: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> 18: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> 20: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> 28: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> 30: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> 38: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> 40: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> 48: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> 50: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> 58: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> 60: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> 68: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> 70: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> 78: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> 80: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> 88: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> 90: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> 98: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> a0: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> a8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> b0: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> b8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> c0: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> c8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> d0: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> d8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> >> e0: 2771 0000 0000 0000 0000 0000 0000 f87f
> >> e8: f87f f87f f87f f87f f87f 0000 fe7f 0300
> >> f0: 1027 2823 ffff ffff ffff ffff ffff ffff
> >> f8: ffff ffff XXXX f8f8 ffff ffff 4954 2032
> > 
> > Thanks a lot!
> > 
> 
> Feel free to completely ignore the first register dump I sent, I did it
> for the wrong device anyway :).
> 
> I had just gotten done reading this:
> https://lkml.org/lkml/2015/12/10/459
> and accidentally got EVMs confused did the test for the TMP461, but it
> does look like on startup register 0x16 can be used to differentiate the
> parts, if the TMP461 hadn't gone into a different driver.
> 
Good catch.

That makes me wonder if we should move tmp461 support to the lm90 driver.
What do you think ? Problem is that tmp461 will be auto-detected as tmp451
by the lm90 driver, which is less than perfect.

My test script for ina3221 only accepts a single value - 16380 - for the
limit registers. Seems odd. I'll have to look into it some more.

Guenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web