Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1430771 > unrolled thread

Re: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding

Started byRob Herring <robh@kernel.org>
First post2016-06-24 17:50 +0200
Last post2016-06-27 08:30 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding Rob Herring <robh@kernel.org> - 2016-06-24 17:50 +0200
    Re: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding Jonathan Cameron <jic23@kernel.org> - 2016-06-26 12:30 +0200
      Re: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> - 2016-06-27 08:30 +0200

#1430771 — Re: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding

FromRob Herring <robh@kernel.org>
Date2016-06-24 17:50 +0200
SubjectRe: [PATCH v3 1/3] Documentation: DT: Add iproc-static-adc binding
Message-ID<rNBwK-1xi-9@gated-at.bofh.it>
On Wed, Jun 22, 2016 at 11:41:51AM +0530, Raveendra Padasalagi wrote:
> The patch adds devicetree binding document for broadcom's
> iproc-static-adc controller driver.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  .../bindings/iio/adc/brcm,iproc-static-adc.txt     | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> new file mode 100644
> index 0000000..a82076e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> @@ -0,0 +1,38 @@
> +* Broadcom's IPROC Static ADC controller
> +
> +Broadcom iProc ADC controller has 8 channels 10bit ADC.
> +Allows user to convert analog input voltage values to digital.
> +
> +Required properties:
> +
> +- compatible: Must be "brcm,iproc-static-adc"
> +
> +- adc-syscon: Handler of syscon node defining physical base address of the
> +  controller and length of memory mapped region.
> +
> +- #io-channel-cells = <1>; As ADC has multiple outputs
> +  refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
> +
> +- clocks: Clock used for this block.
> +
> +- clock-names: Clock name should be given as tsc_clk.
> +
> +- interrupts: interrupt line number.
> +
> +For example:
> +
> +	ts_adc_syscon: ts_adc_syscon@180a6000 {
> +		compatible = "brcm,iproc-ts-adc-syscon","syscon";
> +		reg = <0x180a6000 0xc30>;
> +	};
> +
> +	adc: adc@180a6000 {
> +		compatible = "brcm,iproc-static-adc";
> +		adc-syscon = <&ts_adc_syscon>;
> +		#io-channel-cells = <1>;
> +		io-channel-ranges;

Not documented.

> +		clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
> +		clock-names = "tsc_clk";
> +		interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +		status = "disabled";
> +	};
> -- 
> 1.9.1
> 

[toc] | [next] | [standalone]


#1431399

FromJonathan Cameron <jic23@kernel.org>
Date2016-06-26 12:30 +0200
Message-ID<rOfua-1zv-71@gated-at.bofh.it>
In reply to#1430771
On 24/06/16 16:43, Rob Herring wrote:
> On Wed, Jun 22, 2016 at 11:41:51AM +0530, Raveendra Padasalagi wrote:
>> The patch adds devicetree binding document for broadcom's
>> iproc-static-adc controller driver.
>>
>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>  .../bindings/iio/adc/brcm,iproc-static-adc.txt     | 38 ++++++++++++++++++++++
>>  1 file changed, 38 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>> new file mode 100644
>> index 0000000..a82076e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>> @@ -0,0 +1,38 @@
>> +* Broadcom's IPROC Static ADC controller
>> +
>> +Broadcom iProc ADC controller has 8 channels 10bit ADC.
>> +Allows user to convert analog input voltage values to digital.
>> +
>> +Required properties:
>> +
>> +- compatible: Must be "brcm,iproc-static-adc"
>> +
>> +- adc-syscon: Handler of syscon node defining physical base address of the
>> +  controller and length of memory mapped region.
>> +
>> +- #io-channel-cells = <1>; As ADC has multiple outputs
>> +  refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
>> +
>> +- clocks: Clock used for this block.
>> +
>> +- clock-names: Clock name should be given as tsc_clk.
>> +
>> +- interrupts: interrupt line number.
>> +
>> +For example:
>> +
>> +	ts_adc_syscon: ts_adc_syscon@180a6000 {
>> +		compatible = "brcm,iproc-ts-adc-syscon","syscon";
>> +		reg = <0x180a6000 0xc30>;
>> +	};
>> +
>> +	adc: adc@180a6000 {
>> +		compatible = "brcm,iproc-static-adc";
>> +		adc-syscon = <&ts_adc_syscon>;
>> +		#io-channel-cells = <1>;
>> +		io-channel-ranges;
> 
> Not documented.
Core iio docs, but obviously a cross reference would be good.
> 
>> +		clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
>> +		clock-names = "tsc_clk";
>> +		interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
>> +		status = "disabled";
>> +	};
>> -- 
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[toc] | [prev] | [next] | [standalone]


#1431745

FromRaveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Date2016-06-27 08:30 +0200
Message-ID<rOydr-502-11@gated-at.bofh.it>
In reply to#1431399
On Sun, Jun 26, 2016 at 3:54 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 24/06/16 16:43, Rob Herring wrote:
>> On Wed, Jun 22, 2016 at 11:41:51AM +0530, Raveendra Padasalagi wrote:
>>> The patch adds devicetree binding document for broadcom's
>>> iproc-static-adc controller driver.
>>>
>>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>> ---
>>>  .../bindings/iio/adc/brcm,iproc-static-adc.txt     | 38 ++++++++++++++++++++++
>>>  1 file changed, 38 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>>> new file mode 100644
>>> index 0000000..a82076e
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>>> @@ -0,0 +1,38 @@
>>> +* Broadcom's IPROC Static ADC controller
>>> +
>>> +Broadcom iProc ADC controller has 8 channels 10bit ADC.
>>> +Allows user to convert analog input voltage values to digital.
>>> +
>>> +Required properties:
>>> +
>>> +- compatible: Must be "brcm,iproc-static-adc"
>>> +
>>> +- adc-syscon: Handler of syscon node defining physical base address of the
>>> +  controller and length of memory mapped region.
>>> +
>>> +- #io-channel-cells = <1>; As ADC has multiple outputs
>>> +  refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
>>> +
>>> +- clocks: Clock used for this block.
>>> +
>>> +- clock-names: Clock name should be given as tsc_clk.
>>> +
>>> +- interrupts: interrupt line number.
>>> +
>>> +For example:
>>> +
>>> +    ts_adc_syscon: ts_adc_syscon@180a6000 {
>>> +            compatible = "brcm,iproc-ts-adc-syscon","syscon";
>>> +            reg = <0x180a6000 0xc30>;
>>> +    };
>>> +
>>> +    adc: adc@180a6000 {
>>> +            compatible = "brcm,iproc-static-adc";
>>> +            adc-syscon = <&ts_adc_syscon>;
>>> +            #io-channel-cells = <1>;
>>> +            io-channel-ranges;
>>
>> Not documented.
> Core iio docs, but obviously a cross reference would be good.

Yes, Will provide the cross reference to core iio docs in the next patch.
Thanks.

>>
>>> +            clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
>>> +            clock-names = "tsc_clk";
>>> +            interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
>>> +            status = "disabled";
>>> +    };
>>> --
>>> 1.9.1
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web