Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427802 > unrolled thread

[PATCH] xen/PMU: Log VPMU initialization error at lower level

Back to article view | Back to linux.kernel

Contents

  [PATCH] xen/PMU: Log VPMU initialization error at lower level Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-21 16:20 +0200
    Re: [Xen-devel] [PATCH] xen/PMU: Log VPMU initialization error at  lower level Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-06-21 16:30 +0200
    Re: [PATCH] xen/PMU: Log VPMU initialization error at lower level Juergen Gross <jgross@suse.com> - 2016-06-21 16:50 +0200
    Re: [Xen-devel] [PATCH] xen/PMU: Log VPMU initialization error at  lower level David Vrabel <david.vrabel@citrix.com> - 2016-06-21 17:30 +0200

#1427802 — [PATCH] xen/PMU: Log VPMU initialization error at lower level

This will match how PMU errors are reported at check_hw_exists()'s
msr_fail label, which is reached when VPMU initialzation fails.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/xen/pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 9466354..32bdc2c 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -547,7 +547,7 @@ void xen_pmu_init(int cpu)
 	return;
 
 fail:
-	pr_warn_once("Could not initialize VPMU for cpu %d, error %d\n",
+	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
 		cpu, err);
 	free_pages((unsigned long)xenpmu_data, 0);
 }
-- 
1.8.1.4

[toc] | [next] | [standalone]

#1427820 — Re: [Xen-devel] [PATCH] xen/PMU: Log VPMU initialization error at lower level

On Tue, Jun 21, 2016 at 10:17:33AM -0400, Boris Ostrovsky wrote:
> This will match how PMU errors are reported at check_hw_exists()'s
> msr_fail label, which is reached when VPMU initialzation fails.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  arch/x86/xen/pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 9466354..32bdc2c 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,7 +547,7 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_warn_once("Could not initialize VPMU for cpu %d, error %d\n",
> +	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>  		cpu, err);
>  	free_pages((unsigned long)xenpmu_data, 0);
>  }
> -- 
> 1.8.1.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

[toc] | [prev] | [next] | [standalone]

#1427838

On 21/06/16 16:17, Boris Ostrovsky wrote:
> This will match how PMU errors are reported at check_hw_exists()'s
> msr_fail label, which is reached when VPMU initialzation fails.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Acked-by: Juergen Gross <jgross@suse.com>

> ---
>  arch/x86/xen/pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 9466354..32bdc2c 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,7 +547,7 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_warn_once("Could not initialize VPMU for cpu %d, error %d\n",
> +	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>  		cpu, err);
>  	free_pages((unsigned long)xenpmu_data, 0);
>  }
> 

[toc] | [prev] | [next] | [standalone]

#1427878 — Re: [Xen-devel] [PATCH] xen/PMU: Log VPMU initialization error at lower level

On 21/06/16 15:17, Boris Ostrovsky wrote:
> This will match how PMU errors are reported at check_hw_exists()'s
> msr_fail label, which is reached when VPMU initialzation fails.

Applied to for-linus-4.8, thanks.

David

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web