Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427882 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-06-21 17:40 +0200 |
| Last post | 2016-06-21 17:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static Arnd Bergmann <arnd@arndb.de> - 2016-06-21 17:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-21 17:40 +0200 |
| Subject | Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static |
| Message-ID | <rMvWq-7DO-11@gated-at.bofh.it> |
On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
>
> -struct syscore_ops mvebu_mbus_syscore_ops = {
> +static struct syscore_ops mvebu_mbus_syscore_ops = {
> .suspend = mvebu_mbus_suspend,
> .resume = mvebu_mbus_resume,
> };
>
Looks good, but I immediately thought it should be "const" as well.
Unfortunately there is a list_head in them, so that isn't easy,
but if anyone has an idea for how to make these all const, that
would be nice.
Anyway, that shouldn't stop your patch from getting merged, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
(also for patch 1/2).
Arnd
Back to top | Article view | linux.kernel
csiph-web