Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427662 > unrolled thread

[PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

Started byRafał Miłecki <zajec5@gmail.com>
First post2016-06-21 13:50 +0200
Last post2016-06-21 14:30 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki <zajec5@gmail.com> - 2016-06-21 13:50 +0200
    Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki <zajec5@gmail.com> - 2016-06-21 14:30 +0200
      Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear  R7000 "Imre Kaloz" <kaloz@openwrt.org> - 2016-06-21 16:30 +0200
        Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki <zajec5@gmail.com> - 2016-06-21 17:30 +0200
          Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear  R7000 "Imre Kaloz" <kaloz@openwrt.org> - 2016-06-22 12:30 +0200
    Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear  R7000 "Imre Kaloz" <kaloz@openwrt.org> - 2016-06-21 14:30 +0200

#1427662 — [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

FromRafał Miłecki <zajec5@gmail.com>
Date2016-06-21 13:50 +0200
Subject[PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Message-ID<rMslR-5hj-57@gated-at.bofh.it>
There is one GPIO controlling power for both USB ports.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
index a22ed14..a76486b 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
@@ -104,3 +104,11 @@
 &uart0 {
 	status = "okay";
 };
+
+&usb2 {
+	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
-- 
1.8.4.5

[toc] | [next] | [standalone]

#1427697

FromRafał Miłecki <zajec5@gmail.com>
Date2016-06-21 14:30 +0200
Message-ID<rMsYy-5LM-9@gated-at.bofh.it>
In reply to#1427662
On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
> Is there any reason you are not handling this properly as a regulator with
> usb-nop-xceiv?

We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's USB.

I sent patch for this:
https://patchwork.kernel.org/patch/9148097/

[toc] | [prev] | [next] | [standalone]

#1427812 — Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

From"Imre Kaloz" <kaloz@openwrt.org>
Date2016-06-21 16:30 +0200
SubjectRe: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Message-ID<rMuQF-6YC-9@gated-at.bofh.it>
In reply to#1427697
On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:

> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>> Is there any reason you are not handling this properly as a regulator  
>> with
>> usb-nop-xceiv?
>
> We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's  
> USB.

I see. That shouldn't stop you from addressing the regulator part, tho ;)


Imre

[toc] | [prev] | [next] | [standalone]

#1427879

FromRafał Miłecki <zajec5@gmail.com>
Date2016-06-21 17:30 +0200
Message-ID<rMvMK-7AG-39@gated-at.bofh.it>
In reply to#1427812
On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>
>>> Is there any reason you are not handling this properly as a regulator
>>> with
>>> usb-nop-xceiv?
>>
>>
>> We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's
>> USB.
>
>
> I see. That shouldn't stop you from addressing the regulator part, tho ;)

How? Be more specific please.

-- 
Rafał

[toc] | [prev] | [next] | [standalone]

#1428661 — Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

From"Imre Kaloz" <kaloz@openwrt.org>
Date2016-06-22 12:30 +0200
SubjectRe: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Message-ID<rMNzY-28F-11@gated-at.bofh.it>
In reply to#1427879
On Tue, 21 Jun 2016 17:23:18 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:

> On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
>> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com>  
>> wrote:
>>
>>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>>
>>>> Is there any reason you are not handling this properly as a regulator
>>>> with
>>>> usb-nop-xceiv?
>>>
>>>
>>> We can't use USB NOP PHY as we need a specific PHY driver for  
>>> Broadcom's
>>> USB.
>>
>>
>> I see. That shouldn't stop you from addressing the regulator part, tho  
>> ;)
>
> How? Be more specific please.
>

Instead of blindly enabling a GPIO, you should define that GPIO line as a  
fixed regulator and make the USB phy driver handle it. Take a look at  
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7776ab70d75ff9857343e44e428744d81c30ce1b  
for example.


Imre

[toc] | [prev] | [next] | [standalone]

#1427699 — Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

From"Imre Kaloz" <kaloz@openwrt.org>
Date2016-06-21 14:30 +0200
SubjectRe: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Message-ID<rMsYy-5LM-11@gated-at.bofh.it>
In reply to#1427662
Is there any reason you are not handling this properly as a regulator with  
usb-nop-xceiv?


Imre

On Tue, 21 Jun 2016 13:42:38 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:

> There is one GPIO controlling power for both USB ports.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
>  arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts  
> b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> index a22ed14..a76486b 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> @@ -104,3 +104,11 @@
>  &uart0 {
>  	status = "okay";
>  };
> +
> +&usb2 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&usb3 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web