Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427462 > unrolled thread
| Started by | Andreas Schwab <schwab@suse.de> |
|---|---|
| First post | 2016-06-21 10:40 +0200 |
| Last post | 2016-06-21 14:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32 Andreas Schwab <schwab@suse.de> - 2016-06-21 10:40 +0200
Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32 "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-06-21 14:00 +0200
| From | Andreas Schwab <schwab@suse.de> |
|---|---|
| Date | 2016-06-21 10:40 +0200 |
| Subject | Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32 |
| Message-ID | <rMpnY-3mT-31@gated-at.bofh.it> |
Yury Norov <ynorov@caviumnetworks.com> writes:
> diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h
> index e8c4a7b..351d6bb 100644
> --- a/sysdeps/unix/sysv/linux/sysdep-vdso.h
> +++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h
> @@ -37,7 +37,7 @@
> __label__ out; \
> __label__ iserr; \
> INTERNAL_SYSCALL_DECL (sc_err); \
> - long int sc_ret; \
> + __syscall_slong_t sc_ret; \
> \
> __typeof (__vdso_##name) vdsop = __vdso_##name; \
> PTR_DEMANGLE (vdsop); \
> @@ -64,7 +64,7 @@
> # define INTERNAL_VSYSCALL(name, err, nr, args...) \
> ({ \
> __label__ out; \
> - long v_ret; \
> + __syscall_slong_t v_ret; \
> \
> __typeof (__vdso_##name) vdsop = __vdso_##name; \
> PTR_DEMANGLE (vdsop); \
That part should have no effect now that __SYSCALL_SLONG_TYPE remains to
be long.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
[toc] | [next] | [standalone]
| From | "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> |
|---|---|
| Date | 2016-06-21 14:00 +0200 |
| Message-ID | <rMsvv-5kN-17@gated-at.bofh.it> |
| In reply to | #1427462 |
Hi,
On 2016/6/21 15:58, Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
>> diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> index e8c4a7b..351d6bb 100644
>> --- a/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> +++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> @@ -37,7 +37,7 @@
>> __label__ out; \
>> __label__ iserr; \
>> INTERNAL_SYSCALL_DECL (sc_err); \
>> - long int sc_ret; \
>> + __syscall_slong_t sc_ret; \
>> \
>> __typeof (__vdso_##name) vdsop = __vdso_##name; \
>> PTR_DEMANGLE (vdsop); \
>> @@ -64,7 +64,7 @@
>> # define INTERNAL_VSYSCALL(name, err, nr, args...) \
>> ({ \
>> __label__ out; \
>> - long v_ret; \
>> + __syscall_slong_t v_ret; \
>> \
>> __typeof (__vdso_##name) vdsop = __vdso_##name; \
>> PTR_DEMANGLE (vdsop); \
>
> That part should have no effect now that __SYSCALL_SLONG_TYPE remains to
> be long.
Agree. According to the discussion in "[PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed
always via 64bit values.". We should update this to long long too.
Regard
Bamvor
>
> Andreas.
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web