Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426912 > unrolled thread

[PATCH] ipmi: set si_trydefaults=0 for ARM64

Back to article view | Back to linux.kernel

Contents

  [PATCH] ipmi: set si_trydefaults=0 for ARM64 Tony Camuso <tcamuso@redhat.com> - 2016-06-20 20:30 +0200
    Re: [PATCH] ipmi: set si_trydefaults=0 for ARM64 Corey Minyard <minyard@acm.org> - 2016-06-20 23:20 +0200
      Re: [PATCH] ipmi: set si_trydefaults=0 for ARM64 Tony Camuso <tcamuso@redhat.com> - 2016-06-21 13:30 +0200

#1426912 — [PATCH] ipmi: set si_trydefaults=0 for ARM64

Port I/O space does not exist in ARM64 and is not mapped. Attempts to
access it on ARM systems cause stack traces and worse.

Signed-off-by: Tony Camuso <tcamuso@redhat.com>
---
 drivers/char/ipmi/ipmi_si_intf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 615abbf..85dcc86 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3841,6 +3841,11 @@ static int init_ipmi_si(void)
 		spmi_find_bmc();
 #endif
 
+#ifdef CONFIG_ARM64
+	/* Don't touch port io space */
+	si_trydefaults = 0;
+#endif
+
 #ifdef CONFIG_PARISC
 	register_parisc_driver(&ipmi_parisc_driver);
 	parisc_registered = true;
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1427059

On 06/20/2016 01:26 PM, Tony Camuso wrote:
> Port I/O space does not exist in ARM64 and is not mapped. Attempts to
> access it on ARM systems cause stack traces and worse.

At this point, I think it is best to just completely pull out all concept
of "default addresses" in the IPMI driver.  The defaults were disabled
by default in 3.16, this is as good an impetus as any to just get rid
of them.

If you want, you can do a patch, or I can pull them out if you would
prefer that.

Thanks,

-corey

> Signed-off-by: Tony Camuso <tcamuso@redhat.com>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 615abbf..85dcc86 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3841,6 +3841,11 @@ static int init_ipmi_si(void)
>   		spmi_find_bmc();
>   #endif
>   
> +#ifdef CONFIG_ARM64
> +	/* Don't touch port io space */
> +	si_trydefaults = 0;
> +#endif
> +
>   #ifdef CONFIG_PARISC
>   	register_parisc_driver(&ipmi_parisc_driver);
>   	parisc_registered = true;

[toc] | [prev] | [next] | [standalone]

#1427627

On 06/20/2016 04:57 PM, Corey Minyard wrote:
> On 06/20/2016 01:26 PM, Tony Camuso wrote:
>> Port I/O space does not exist in ARM64 and is not mapped. Attempts to
>> access it on ARM systems cause stack traces and worse.
>
> At this point, I think it is best to just completely pull out all concept
> of "default addresses" in the IPMI driver.  The defaults were disabled
> by default in 3.16, this is as good an impetus as any to just get rid
> of them.
>
> If you want, you can do a patch, or I can pull them out if you would
> prefer that.

I'll give it a go. Should have something later today.

Regards,
Tony


>
> Thanks,
>
> -corey
>
>> Signed-off-by: Tony Camuso <tcamuso@redhat.com>
>> ---
>>   drivers/char/ipmi/ipmi_si_intf.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
>> index 615abbf..85dcc86 100644
>> --- a/drivers/char/ipmi/ipmi_si_intf.c
>> +++ b/drivers/char/ipmi/ipmi_si_intf.c
>> @@ -3841,6 +3841,11 @@ static int init_ipmi_si(void)
>>           spmi_find_bmc();
>>   #endif
>>   +#ifdef CONFIG_ARM64
>> +    /* Don't touch port io space */
>> +    si_trydefaults = 0;
>> +#endif
>> +
>>   #ifdef CONFIG_PARISC
>>       register_parisc_driver(&ipmi_parisc_driver);
>>       parisc_registered = true;
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web