Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425670 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-06-18 10:30 +0200 |
| Last post | 2016-06-21 11:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] iommu/amd: Remove create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-18 10:30 +0200
Re: [PATCH] iommu/amd: Remove create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-20 19:00 +0200
Re: [PATCH] iommu/amd: Remove create_workqueue Joerg Roedel <joro@8bytes.org> - 2016-06-21 11:20 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-06-18 10:30 +0200 |
| Subject | [PATCH] iommu/amd: Remove create_workqueue |
| Message-ID | <rLjND-1CT-1@gated-at.bofh.it> |
alloc_workqueue replaces deprecated create_workqueue().
A dedicated workqueue has been used since the workitem (viz
&fault->work), is involved in IO page-fault handling.
WQ_MEM_RECLAIM has been set to guarantee forward progress under memory
pressure, which is a requirement here.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/iommu/amd_iommu_v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 56999d2f..0d52ceb 100644
--- a/drivers/iommu/amd_iommu_v2.c
+++ b/drivers/iommu/amd_iommu_v2.c
@@ -961,7 +961,7 @@ static int __init amd_iommu_v2_init(void)
spin_lock_init(&state_lock);
ret = -ENOMEM;
- iommu_wq = create_workqueue("amd_iommu_v2");
+ iommu_wq = alloc_workqueue("amd_iommu_v2", WQ_MEM_RECLAIM, 0);
if (iommu_wq == NULL)
goto out;
--
2.1.4
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-06-20 19:00 +0200 |
| Message-ID | <rMaIi-2hU-31@gated-at.bofh.it> |
| In reply to | #1425670 |
On Sat, Jun 18, 2016 at 01:58:30PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > &fault->work), is involved in IO page-fault handling. > WQ_MEM_RECLAIM has been set to guarantee forward progress under memory > pressure, which is a requirement here. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Date | 2016-06-21 11:20 +0200 |
| Message-ID | <rMq0F-3PM-19@gated-at.bofh.it> |
| In reply to | #1425670 |
On Sat, Jun 18, 2016 at 01:58:30PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > &fault->work), is involved in IO page-fault handling. > WQ_MEM_RECLAIM has been set to guarantee forward progress under memory > pressure, which is a requirement here. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > --- > drivers/iommu/amd_iommu_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web