Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1426812 > unrolled thread
| Started by | Tyler Baker <tyler.baker@linaro.org> |
|---|---|
| First post | 2016-06-20 19:00 +0200 |
| Last post | 2016-06-21 17:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1 15/25] PCI: generic: Free resource list close to where it's allocated Tyler Baker <tyler.baker@linaro.org> - 2016-06-20 19:00 +0200
Re: [PATCH v1 15/25] PCI: generic: Free resource list close to where it's allocated Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-06-20 19:30 +0200
Re: [PATCH v1 15/25] PCI: generic: Free resource list close to where it's allocated Bjorn Helgaas <helgaas@kernel.org> - 2016-06-21 17:20 +0200
| From | Tyler Baker <tyler.baker@linaro.org> |
|---|---|
| Date | 2016-06-20 19:00 +0200 |
| Subject | Re: [PATCH v1 15/25] PCI: generic: Free resource list close to where it's allocated |
| Message-ID | <rMaIi-2hU-15@gated-at.bofh.it> |
Hi Bjorn, On 6 June 2016 at 16:06, Bjorn Helgaas <bhelgaas@google.com> wrote: > Previously we allocated the PCI resource list in > gen_pci_parse_request_of_pci_ranges(), but if we had an error, we freed it > on error in gen_pci_init(). > > Reorder gen_pci_init() so we can take care of error path cleanup in > gen_pci_parse_request_of_pci_ranges() instead. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> The kernelci.org bot has reported[0] new qemu-aarch64 (arm64-defconfig) boot failures[1][2] in next-20160620. I've bisected[3] this boot failure down to this patch, and confirmed reverting it on top of next-20160620 resolves the boot issue. I have not investigated further, but you can easily reproduce[4] the boot failure on an x86 host running qemu-system-aarch64 (I'm running qemu-system 2.6). Cheers, Tyler [0] https://kernelci.org/boot/all/job/next/kernel/next-20160620/ [1] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-cambridge/boot-apm-mustang-kvm-guest.txt [2] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-tbaker/boot-qemu-aarch64,legacy.txt [3] http://hastebin.com/segiruribu.vbs [4] http://hastebin.com/dafuzicuyi.avrasm
[toc] | [next] | [standalone]
| From | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| Date | 2016-06-20 19:30 +0200 |
| Message-ID | <rMbbk-2Hq-17@gated-at.bofh.it> |
| In reply to | #1426812 |
On Mon, Jun 20, 2016 at 09:56:45AM -0700, Tyler Baker wrote: > Hi Bjorn, > > On 6 June 2016 at 16:06, Bjorn Helgaas <bhelgaas@google.com> wrote: > > Previously we allocated the PCI resource list in > > gen_pci_parse_request_of_pci_ranges(), but if we had an error, we freed it > > on error in gen_pci_init(). > > > > Reorder gen_pci_init() so we can take care of error path cleanup in > > gen_pci_parse_request_of_pci_ranges() instead. > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > The kernelci.org bot has reported[0] new qemu-aarch64 > (arm64-defconfig) boot failures[1][2] in next-20160620. I've > bisected[3] this boot failure down to this patch, and confirmed > reverting it on top of next-20160620 resolves the boot issue. > > I have not investigated further, but you can easily reproduce[4] the > boot failure on an x86 host running qemu-system-aarch64 (I'm running > qemu-system 2.6). That's most likely because pci_ecam_create() requires the bus_range resource (its busr parameter) to be initialized when it is called and that's not the case after this patch is applied if I read it correctly. It is probably a NULL pointer dereference in pci_ecam_create(). Thanks, Lorenzo > > Cheers, > > Tyler > > [0] https://kernelci.org/boot/all/job/next/kernel/next-20160620/ > [1] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-cambridge/boot-apm-mustang-kvm-guest.txt > [2] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-tbaker/boot-qemu-aarch64,legacy.txt > [3] http://hastebin.com/segiruribu.vbs > [4] http://hastebin.com/dafuzicuyi.avrasm > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-06-21 17:20 +0200 |
| Message-ID | <rMvD4-7x7-9@gated-at.bofh.it> |
| In reply to | #1426846 |
On Mon, Jun 20, 2016 at 06:22:40PM +0100, Lorenzo Pieralisi wrote: > On Mon, Jun 20, 2016 at 09:56:45AM -0700, Tyler Baker wrote: > > Hi Bjorn, > > > > On 6 June 2016 at 16:06, Bjorn Helgaas <bhelgaas@google.com> wrote: > > > Previously we allocated the PCI resource list in > > > gen_pci_parse_request_of_pci_ranges(), but if we had an error, we freed it > > > on error in gen_pci_init(). > > > > > > Reorder gen_pci_init() so we can take care of error path cleanup in > > > gen_pci_parse_request_of_pci_ranges() instead. > > > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > > > The kernelci.org bot has reported[0] new qemu-aarch64 > > (arm64-defconfig) boot failures[1][2] in next-20160620. I've > > bisected[3] this boot failure down to this patch, and confirmed > > reverting it on top of next-20160620 resolves the boot issue. > > > > I have not investigated further, but you can easily reproduce[4] the > > boot failure on an x86 host running qemu-system-aarch64 (I'm running > > qemu-system 2.6). > > That's most likely because pci_ecam_create() requires the bus_range > resource (its busr parameter) to be initialized when it is called > and that's not the case after this patch is applied if I read it > correctly. > > It is probably a NULL pointer dereference in pci_ecam_create(). Yep, thanks everybody, I dropped that ill-considered patch altogether. > > [0] https://kernelci.org/boot/all/job/next/kernel/next-20160620/ > > [1] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-cambridge/boot-apm-mustang-kvm-guest.txt > > [2] https://storage.kernelci.org/next/next-20160620/arm64-defconfig/lab-tbaker/boot-qemu-aarch64,legacy.txt > > [3] http://hastebin.com/segiruribu.vbs > > [4] http://hastebin.com/dafuzicuyi.avrasm > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web