Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425957 > unrolled thread
| Started by | Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> |
|---|---|
| First post | 2016-06-19 12:10 +0200 |
| Last post | 2016-06-21 12:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> - 2016-06-19 12:10 +0200
Re: [PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding Rob Herring <robh@kernel.org> - 2016-06-20 20:10 +0200
Re: [PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> - 2016-06-21 12:10 +0200
| From | Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> |
|---|---|
| Date | 2016-06-19 12:10 +0200 |
| Subject | [PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding |
| Message-ID | <rLHPY-Tf-11@gated-at.bofh.it> |
The patch adds devicetree binding document for broadcom's
iproc-static-adc controller driver.
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
.../bindings/iio/adc/brcm,iproc-static-adc.txt | 43 ++++++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
new file mode 100644
index 0000000..1de0dfa
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
@@ -0,0 +1,43 @@
+* Broadcom's IPROC Static ADC controller
+
+Required properties:
+
+- compatible: Must be "brcm,iproc-static-adc"
+
+- #address-cells: Specify the number of u32 entries needed in child nodes.
+ Should set to 1.
+
+- #size-cells: Specify number of u32 entries needed to specify child nodes size
+ in reg property. Should set to 1.
+
+- adc-syscon: Handler of syscon node defining physical base address of the
+ controller and length of memory mapped region.
+
+- #io-channel-cells = <1>; As ADC has multiple outputs
+ refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
+
+- clocks: Clock used for this block.
+
+- clock-names: Clock name should be given as tsc_clk.
+
+- interrupts: interrupt line number.
+
+For example:
+
+ ts_adc_syscon: ts_adc_syscon@180a6000 {
+ compatible = "brcm,iproc-ts-adc-syscon","syscon";
+ reg = <0x180a6000 0xc30>;
+ };
+
+ adc: adc@180a6000 {
+ compatible = "brcm,iproc-static-adc";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ adc-syscon = <&ts_adc_syscon>;
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+ clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
+ clock-names = "tsc_clk";
+ interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
--
1.9.1
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-06-20 20:10 +0200 |
| Message-ID | <rMbO2-3aM-25@gated-at.bofh.it> |
| In reply to | #1425957 |
On Sun, Jun 19, 2016 at 03:36:28PM +0530, Raveendra Padasalagi wrote:
> The patch adds devicetree binding document for broadcom's
> iproc-static-adc controller driver.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
> .../bindings/iio/adc/brcm,iproc-static-adc.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> new file mode 100644
> index 0000000..1de0dfa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> @@ -0,0 +1,43 @@
> +* Broadcom's IPROC Static ADC controller
> +
> +Required properties:
> +
> +- compatible: Must be "brcm,iproc-static-adc"
> +
> +- #address-cells: Specify the number of u32 entries needed in child nodes.
> + Should set to 1.
> +
> +- #size-cells: Specify number of u32 entries needed to specify child nodes size
> + in reg property. Should set to 1.
Why are these needed? What child nodes can you have?
> +
> +- adc-syscon: Handler of syscon node defining physical base address of the
> + controller and length of memory mapped region.
> +
> +- #io-channel-cells = <1>; As ADC has multiple outputs
> + refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
> +
> +- clocks: Clock used for this block.
> +
> +- clock-names: Clock name should be given as tsc_clk.
> +
> +- interrupts: interrupt line number.
> +
> +For example:
> +
> + ts_adc_syscon: ts_adc_syscon@180a6000 {
> + compatible = "brcm,iproc-ts-adc-syscon","syscon";
> + reg = <0x180a6000 0xc30>;
> + };
> +
> + adc: adc@180a6000 {
> + compatible = "brcm,iproc-static-adc";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + adc-syscon = <&ts_adc_syscon>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> + clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
> + clock-names = "tsc_clk";
> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> |
|---|---|
| Date | 2016-06-21 12:10 +0200 |
| Message-ID | <rMqN4-4mp-73@gated-at.bofh.it> |
| In reply to | #1426893 |
Hi Rob,
Please find my reply inline.
Regards,
Raveendra
On Mon, Jun 20, 2016 at 11:34 PM, Rob Herring <robh@kernel.org> wrote:
> On Sun, Jun 19, 2016 at 03:36:28PM +0530, Raveendra Padasalagi wrote:
>> The patch adds devicetree binding document for broadcom's
>> iproc-static-adc controller driver.
>>
>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>> .../bindings/iio/adc/brcm,iproc-static-adc.txt | 43 ++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>> new file mode 100644
>> index 0000000..1de0dfa
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>> @@ -0,0 +1,43 @@
>> +* Broadcom's IPROC Static ADC controller
>> +
>> +Required properties:
>> +
>> +- compatible: Must be "brcm,iproc-static-adc"
>> +
>
>> +- #address-cells: Specify the number of u32 entries needed in child nodes.
>> + Should set to 1.
>> +
>> +- #size-cells: Specify number of u32 entries needed to specify child nodes size
>> + in reg property. Should set to 1.
>
> Why are these needed? What child nodes can you have?
Yes, these are not needed. ADC can't have any child nodes.
I will fix it in the next patch. Thanks.
>> +
>> +- adc-syscon: Handler of syscon node defining physical base address of the
>> + controller and length of memory mapped region.
>> +
>> +- #io-channel-cells = <1>; As ADC has multiple outputs
>> + refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
>> +
>> +- clocks: Clock used for this block.
>> +
>> +- clock-names: Clock name should be given as tsc_clk.
>> +
>> +- interrupts: interrupt line number.
>> +
>> +For example:
>> +
>> + ts_adc_syscon: ts_adc_syscon@180a6000 {
>> + compatible = "brcm,iproc-ts-adc-syscon","syscon";
>> + reg = <0x180a6000 0xc30>;
>> + };
>> +
>> + adc: adc@180a6000 {
>> + compatible = "brcm,iproc-static-adc";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + adc-syscon = <&ts_adc_syscon>;
>> + #io-channel-cells = <1>;
>> + io-channel-ranges;
>> + clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
>> + clock-names = "tsc_clk";
>> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + };
>> --
>> 1.9.1
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web