Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428783 > unrolled thread
| Started by | Jiri Kosina <jikos@kernel.org> |
|---|---|
| First post | 2016-06-22 15:30 +0200 |
| Last post | 2016-06-22 22:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 4/4] HID: remove ThingM blink(1) driver Jiri Kosina <jikos@kernel.org> - 2016-06-22 15:30 +0200
Re: [PATCH 4/4] HID: remove ThingM blink(1) driver Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-22 17:50 +0200
Re: [PATCH 4/4] HID: remove ThingM blink(1) driver Heiner Kallweit <hkallweit1@gmail.com> - 2016-06-22 22:00 +0200
Re: [PATCH 4/4] HID: remove ThingM blink(1) driver Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-22 22:10 +0200
Re: [PATCH 4/4] HID: remove ThingM blink(1) driver Heiner Kallweit <hkallweit1@gmail.com> - 2016-06-22 22:00 +0200
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2016-06-22 15:30 +0200 |
| Subject | Re: [PATCH 4/4] HID: remove ThingM blink(1) driver |
| Message-ID | <rMQo9-41d-1@gated-at.bofh.it> |
On Tue, 21 Jun 2016, Heiner Kallweit wrote: > Now that support for ThingM blink(1) was merged into the hid-led driver > the dedicated driver for this device can be removed. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/hid/Kconfig | 10 -- > drivers/hid/Makefile | 1 - > drivers/hid/hid-thingm.c | 259 ----------------------------------------------- > 3 files changed, 270 deletions(-) > delete mode 100644 drivers/hid/hid-thingm.c > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index ab22090..6b08a3b 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -828,16 +828,6 @@ config HID_TOPSEED > Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic > CLLRCMCE remote control. > > -config HID_THINGM Overall the patchset looks good to me. I'd suggest we keep CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so that we don't cause kernel config regressions for users who had CONFIG_HID_THINGM already turned on. Also adding Vivien Didelot to CC, as the author of the original driver. Vivien, the full set can be found in linux-input archives ( http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) -- Jiri Kosina SUSE Labs
[toc] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-06-22 17:50 +0200 |
| Message-ID | <rMSzD-5iW-9@gated-at.bofh.it> |
| In reply to | #1428783 |
Hi,
Jiri Kosina <jikos@kernel.org> writes:
> On Tue, 21 Jun 2016, Heiner Kallweit wrote:
>
>> Now that support for ThingM blink(1) was merged into the hid-led driver
>> the dedicated driver for this device can be removed.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/hid/Kconfig | 10 --
>> drivers/hid/Makefile | 1 -
>> drivers/hid/hid-thingm.c | 259 -----------------------------------------------
>> 3 files changed, 270 deletions(-)
>> delete mode 100644 drivers/hid/hid-thingm.c
>>
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index ab22090..6b08a3b 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -828,16 +828,6 @@ config HID_TOPSEED
>> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic
>> CLLRCMCE remote control.
>>
>> -config HID_THINGM
>
> Overall the patchset looks good to me. I'd suggest we keep
> CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so
> that we don't cause kernel config regressions for users who had
> CONFIG_HID_THINGM already turned on.
>
> Also adding Vivien Didelot to CC, as the author of the original driver.
> Vivien, the full set can be found in linux-input archives (
> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
Thanks a lot for the follow-up Jiri.
If you guys decide to remove hid-thingm.c, you need to update the
MAINTAINERS entry, checkpatch.pl should have warned about that.
I can hardly test the patchset now. Heiner, can you confirm me that with
your patchset, we will still see 3 led_classdev in sysfs for the
blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)?
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Heiner Kallweit <hkallweit1@gmail.com> |
|---|---|
| Date | 2016-06-22 22:00 +0200 |
| Message-ID | <rMWtA-7Ln-5@gated-at.bofh.it> |
| In reply to | #1428915 |
Am 22.06.2016 um 17:42 schrieb Vivien Didelot: > Hi, > > Jiri Kosina <jikos@kernel.org> writes: > >> On Tue, 21 Jun 2016, Heiner Kallweit wrote: >> >>> Now that support for ThingM blink(1) was merged into the hid-led driver >>> the dedicated driver for this device can be removed. >>> >>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >>> --- >>> drivers/hid/Kconfig | 10 -- >>> drivers/hid/Makefile | 1 - >>> drivers/hid/hid-thingm.c | 259 ----------------------------------------------- >>> 3 files changed, 270 deletions(-) >>> delete mode 100644 drivers/hid/hid-thingm.c >>> >>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >>> index ab22090..6b08a3b 100644 >>> --- a/drivers/hid/Kconfig >>> +++ b/drivers/hid/Kconfig >>> @@ -828,16 +828,6 @@ config HID_TOPSEED >>> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic >>> CLLRCMCE remote control. >>> >>> -config HID_THINGM >> >> Overall the patchset looks good to me. I'd suggest we keep >> CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so >> that we don't cause kernel config regressions for users who had >> CONFIG_HID_THINGM already turned on. >> >> Also adding Vivien Didelot to CC, as the author of the original driver. >> Vivien, the full set can be found in linux-input archives ( >> http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) > > Thanks a lot for the follow-up Jiri. > > If you guys decide to remove hid-thingm.c, you need to update the > MAINTAINERS entry, checkpatch.pl should have warned about that. > Right, thanks for the hint. > I can hardly test the patchset now. Heiner, can you confirm me that with > your patchset, we will still see 3 led_classdev in sysfs for the > blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)? > Yes, this will still be the case. Regards, Heiner > Thanks, > > Vivien >
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-06-22 22:10 +0200 |
| Message-ID | <rMWDg-846-19@gated-at.bofh.it> |
| In reply to | #1429083 |
Hi Heiner,
Heiner Kallweit <hkallweit1@gmail.com> writes:
>>> Also adding Vivien Didelot to CC, as the author of the original driver.
>>> Vivien, the full set can be found in linux-input archives (
>>> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
>>
>> Thanks a lot for the follow-up Jiri.
>>
>> If you guys decide to remove hid-thingm.c, you need to update the
>> MAINTAINERS entry, checkpatch.pl should have warned about that.
>>
> Right, thanks for the hint.
>
>> I can hardly test the patchset now. Heiner, can you confirm me that with
>> your patchset, we will still see 3 led_classdev in sysfs for the
>> blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)?
>>
> Yes, this will still be the case.
Looks good to me then! Please Cc' me in the v2 so I can hack the change.
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Heiner Kallweit <hkallweit1@gmail.com> |
|---|---|
| Date | 2016-06-22 22:00 +0200 |
| Message-ID | <rMWtA-7Ln-17@gated-at.bofh.it> |
| In reply to | #1428783 |
Am 22.06.2016 um 15:25 schrieb Jiri Kosina: > On Tue, 21 Jun 2016, Heiner Kallweit wrote: > >> Now that support for ThingM blink(1) was merged into the hid-led driver >> the dedicated driver for this device can be removed. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> drivers/hid/Kconfig | 10 -- >> drivers/hid/Makefile | 1 - >> drivers/hid/hid-thingm.c | 259 ----------------------------------------------- >> 3 files changed, 270 deletions(-) >> delete mode 100644 drivers/hid/hid-thingm.c >> >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >> index ab22090..6b08a3b 100644 >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -828,16 +828,6 @@ config HID_TOPSEED >> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic >> CLLRCMCE remote control. >> >> -config HID_THINGM > > Overall the patchset looks good to me. I'd suggest we keep > CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so > that we don't cause kernel config regressions for users who had > CONFIG_HID_THINGM already turned on. > OK I'll add this and provide a v2 of the patch removing the old thingm driver. > Also adding Vivien Didelot to CC, as the author of the original driver. > Vivien, the full set can be found in linux-input archives ( > http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) > Sorry, forgot that.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web