Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421336 > unrolled thread

[PATCH 0/2] pinctrl: convert palmas and as3722 to tristate

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] pinctrl: convert palmas and as3722 to tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-13 23:20 +0200
    [PATCH 1/2] pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-13 23:20 +0200
      Re: [PATCH 1/2] pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate Linus Walleij <linus.walleij@linaro.org> - 2016-06-22 18:10 +0200
    [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-13 23:20 +0200
      Re: [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate Linus Walleij <linus.walleij@linaro.org> - 2016-06-22 18:10 +0200

#1421336 — [PATCH 0/2] pinctrl: convert palmas and as3722 to tristate

As part of a previous review[1], these two drivers (currently bool) were
nominated by their author to be converted to tristate (vs. removing the
existing modular references.)

Upon detecting a non-modular driver making modular references, I don't
immediately convert them to tristate, since it increases functionality
that I can't readily test, and it may not have a sensible use case (e.g.
in the case of core arch support relating to timer ticks or similar.)
So instead the modular references are removed w/o changing the existing
functionality by default.

However there is no reason the original author or an interested user
with the capability to test can't nominate the driver to be tristate
either as the original intent, or as a functional and tested use case.

Here we convert two drivers to tristate and ensure that they can compile
and pass modpost without suffering unresolved symbols:

paul@builder:~/git/linux-head$ ls -l ../arm-build/drivers/pinctrl/*ko
[...]
-rw-rw-r-- 1 paul paul 15585 Jun 13 15:49 ../arm-build/drivers/pinctrl/pinctrl-as3722.ko
-rw-rw-r-- 1 paul paul 25497 Jun 13 15:49 ../arm-build/drivers/pinctrl/pinctrl-palmas.ko
paul@builder:~/git/linux-head$

To be clear, I don't have the hardware required for runtime testing of
the modular instances, and hence that remains to be done by someone
with the hardware and the desire to have the driver(s) modular.

That said, this change won't regress any existing users who are relying
on the current built-in behaviour, so merging doesn't need to be
conditional on obtaining run time testing of the modular instances.

Paul.

[1] https://lkml.kernel.org/r/1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com
---

Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org


Paul Gortmaker (2):
  pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate
  pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate

 drivers/pinctrl/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.8.4

[toc] | [next] | [standalone]

#1421340 — [PATCH 1/2] pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate

The Kconfig currently controlling compilation of this code is:

config PINCTRL_PALMAS
        bool "Pinctrl driver for the PALMAS Series MFD devices"

...meaning that it currently is not being built as a module by anyone.

During an audit for non-modular drivers using modular infrastructure
this driver showed up.

But rather than demodularize it, Laxman indicated that it would be
prefereable to instead convert the driver option to tristate.

This does that, and confirms that it will compile and modpost as
such.  However, since I do not have the hardware to confirm that
no new runtime issues exist when modular, that remains untested.

Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index ea25eeeceef1..a92e61870024 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -218,7 +218,7 @@ config PINCTRL_MAX77620
 	  open drain, FPS slots etc.
 
 config PINCTRL_PALMAS
-	bool "Pinctrl driver for the PALMAS Series MFD devices"
+	tristate "Pinctrl driver for the PALMAS Series MFD devices"
 	depends on OF && MFD_PALMAS
 	select PINMUX
 	select GENERIC_PINCONF
-- 
2.8.4

[toc] | [prev] | [next] | [standalone]

#1428935 — Re: [PATCH 1/2] pinctrl: palmas: convert PINCTRL_PALMAS from bool to tristate

On Mon, Jun 13, 2016 at 11:10 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_PALMAS
>         bool "Pinctrl driver for the PALMAS Series MFD devices"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> During an audit for non-modular drivers using modular infrastructure
> this driver showed up.
>
> But rather than demodularize it, Laxman indicated that it would be
> prefereable to instead convert the driver option to tristate.
>
> This does that, and confirms that it will compile and modpost as
> such.  However, since I do not have the hardware to confirm that
> no new runtime issues exist when modular, that remains untested.
>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1421342 — [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate

The Kconfig currently controlling compilation of this code is:

config PINCTRL_AS3722
        bool "Pinctrl and GPIO driver for ams AS3722 PMIC"

...meaning that it currently is not being built as a module by anyone.

During an audit for non-modular drivers using modular infrastructure
this driver showed up.

But rather than demodularize it, Laxman indicated that it would be
prefereable to instead convert the driver option to tristate.

This does that, and confirms that it will compile and modpost as
such.  However, since I do not have the hardware to confirm that
no new runtime issues exist when modular, that remains untested.

Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index a92e61870024..2f805014cc21 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -35,7 +35,7 @@ config PINCTRL_ADI2
 	  machine and arch are selected to build.
 
 config PINCTRL_AS3722
-	bool "Pinctrl and GPIO driver for ams AS3722 PMIC"
+	tristate "Pinctrl and GPIO driver for ams AS3722 PMIC"
 	depends on MFD_AS3722 && GPIOLIB
 	select PINMUX
 	select GENERIC_PINCONF
-- 
2.8.4

[toc] | [prev] | [next] | [standalone]

#1428944 — Re: [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate

On Mon, Jun 13, 2016 at 11:10 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_AS3722
>         bool "Pinctrl and GPIO driver for ams AS3722 PMIC"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> During an audit for non-modular drivers using modular infrastructure
> this driver showed up.
>
> But rather than demodularize it, Laxman indicated that it would be
> prefereable to instead convert the driver option to tristate.
>
> This does that, and confirms that it will compile and modpost as
> such.  However, since I do not have the hardware to confirm that
> no new runtime issues exist when modular, that remains untested.
>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web