Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427593 > unrolled thread

[PATCH v2] HID: i2c-hid: set power sleep before shutdown

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] HID: i2c-hid: set power sleep before shutdown Guohua Zhong <ghzhong@yifangdigital.com> - 2016-06-21 12:40 +0200
    Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown Jiri Kosina <jikos@kernel.org> - 2016-06-21 13:10 +0200
      Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown ghzhong <ghzhong@yifangdigital.com> - 2016-06-22 13:30 +0200
        Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown Jiri Kosina <jikos@kernel.org> - 2016-06-22 13:30 +0200

#1427593 — [PATCH v2] HID: i2c-hid: set power sleep before shutdown

Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
irq before device shutdown.

Some HW design (i.e. Umaro, a chromebook model) is that the power to
i2c hid device won't down after device shutdown. Also the i2c-hid driver
do not send suspend cmd to the hid i2c device and free its irq before
shutdown.So if We touch the touchscreen or some other i2c hid device,
the power consumtion will be go up even when the device is in shutdown
state.

Though the root cause maybe a HW issue. But it seems that it is a
good pratice to set power sleep for i2c-hid device before shutdown.

Signed-off-by: Guohua Zhong <ghzhong@yifangdigital.com>
---
 drivers/hid/i2c-hid/i2c-hid.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 2e021ba..79406ae 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -1106,6 +1106,14 @@ static int i2c_hid_remove(struct i2c_client *client)
 	return 0;
 }
 
+static void i2c_hid_shutdown(struct i2c_client *client)
+{
+	struct i2c_hid *ihid = i2c_get_clientdata(client);
+
+	i2c_hid_set_power(client, I2C_HID_PWR_SLEEP);
+	free_irq(client->irq, ihid);
+}
+
 #ifdef CONFIG_PM_SLEEP
 static int i2c_hid_suspend(struct device *dev)
 {
@@ -1230,7 +1238,7 @@ static struct i2c_driver i2c_hid_driver = {
 
 	.probe		= i2c_hid_probe,
 	.remove		= i2c_hid_remove,
-
+	.shutdown	= i2c_hid_shutdown,
 	.id_table	= i2c_hid_id_table,
 };
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1427610

On Tue, 21 Jun 2016, Guohua Zhong wrote:

> Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
> irq before device shutdown.
> 
> Some HW design (i.e. Umaro, a chromebook model) is that the power to
> i2c hid device won't down after device shutdown. Also the i2c-hid driver
> do not send suspend cmd to the hid i2c device and free its irq before
> shutdown.So if We touch the touchscreen or some other i2c hid device,
> the power consumtion will be go up even when the device is in shutdown
> state.
> 
> Though the root cause maybe a HW issue. But it seems that it is a
> good pratice to set power sleep for i2c-hid device before shutdown.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1428699

On 06/21/2016 07:09 PM, Jiri Kosina wrote:
> On Tue, 21 Jun 2016, Guohua Zhong wrote:
>
>> Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
>> irq before device shutdown.
>>
>> Some HW design (i.e. Umaro, a chromebook model) is that the power to
>> i2c hid device won't down after device shutdown. Also the i2c-hid driver
>> do not send suspend cmd to the hid i2c device and free its irq before
>> shutdown.So if We touch the touchscreen or some other i2c hid device,
>> the power consumtion will be go up even when the device is in shutdown
>> state.
>>
>> Though the root cause maybe a HW issue. But it seems that it is a
>> good pratice to set power sleep for i2c-hid device before shutdown.
> Applied, thanks.
>
Do you mean that the Patch V2 has been reviewed & approved? Or I make something wrong and need  to do something else?

[toc] | [prev] | [next] | [standalone]

#1428703

On Wed, 22 Jun 2016, ghzhong wrote:

> Do you mean that the Patch V2 has been reviewed & approved? Or I make 
> something wrong and need to do something else?

It's queued in for-4.8/i2c-hid branch of hid.git:

	https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/log/?h=for-4.8/i2c-hid

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web