Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427860 > unrolled thread
| Started by | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| First post | 2016-06-21 17:10 +0200 |
| Last post | 2016-06-23 08:50 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Mark Rutland <mark.rutland@arm.com> - 2016-06-21 17:10 +0200
Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-06-22 10:10 +0200
Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Mark Rutland <mark.rutland@arm.com> - 2016-06-22 12:20 +0200
Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Stephan Linz <linz@li-pro.net> - 2016-06-22 18:10 +0200
Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-06-23 08:50 +0200
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-06-21 17:10 +0200 |
| Subject | Re: [PATCH v3 2/7] leds: documentation: 'ide-disk' to 'disk-activity' |
| Message-ID | <rMvtn-7tu-7@gated-at.bofh.it> |
On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: > Cc: Joseph Jezak <josejx@gentoo.org> > Cc: Nico Macrionitis <acrux@cruxppc.org> > Cc: Jörg Sommer <joerg@alea.gnuu.de> > Signed-off-by: Stephan Linz <linz@li-pro.net> > --- > Documentation/devicetree/bindings/leds/common.txt | 2 +- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- > Documentation/laptops/asus-laptop.txt | 2 +- > Documentation/leds/leds-class.txt | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index af10678..1e97169 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -26,7 +26,7 @@ Optional properties for child nodes: > "default-on" - LED will turn on (but for leds-gpio see "default-state" > property in Documentation/devicetree/bindings/gpio/led.txt) > "heartbeat" - LED "double" flashes at a load average based rate > - "ide-disk" - LED indicates disk activity > + "disk-activity" - LED indicates disk activity > "timer" - LED flashes at a fixed, configurable rate We should not break the binding. Code must continue to support "ide-disk", though we can mark it deprecated in the binding documentation, and update the in-kernel dts files to use "disk-activity". Thanks, Mark.
[toc] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-06-22 10:10 +0200 |
| Message-ID | <rMLot-Tc-9@gated-at.bofh.it> |
| In reply to | #1427860 |
On 06/21/2016 05:05 PM, Mark Rutland wrote: > On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: >> Cc: Joseph Jezak <josejx@gentoo.org> >> Cc: Nico Macrionitis <acrux@cruxppc.org> >> Cc: Jörg Sommer <joerg@alea.gnuu.de> >> Signed-off-by: Stephan Linz <linz@li-pro.net> >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 +- >> Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- >> Documentation/laptops/asus-laptop.txt | 2 +- >> Documentation/leds/leds-class.txt | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt >> index af10678..1e97169 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -26,7 +26,7 @@ Optional properties for child nodes: >> "default-on" - LED will turn on (but for leds-gpio see "default-state" >> property in Documentation/devicetree/bindings/gpio/led.txt) >> "heartbeat" - LED "double" flashes at a load average based rate >> - "ide-disk" - LED indicates disk activity >> + "disk-activity" - LED indicates disk activity >> "timer" - LED flashes at a fixed, configurable rate > > We should not break the binding. > > Code must continue to support "ide-disk", though we can mark it > deprecated in the binding documentation, and update the in-kernel dts > files to use "disk-activity". The code in the version 4 of the patchset supports also "ide-disk". Stephan, could you send a new version of this patch, with preserved "ide-disk" property, marked as deprecated? -- Best regards, Jacek Anaszewski
[toc] | [prev] | [next] | [standalone]
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-06-22 12:20 +0200 |
| Message-ID | <rMNqi-25n-27@gated-at.bofh.it> |
| In reply to | #1428533 |
On Wed, Jun 22, 2016 at 09:55:43AM +0200, Jacek Anaszewski wrote: > On 06/21/2016 05:05 PM, Mark Rutland wrote: > >On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: > >>Cc: Joseph Jezak <josejx@gentoo.org> > >>Cc: Nico Macrionitis <acrux@cruxppc.org> > >>Cc: Jörg Sommer <joerg@alea.gnuu.de> > >>Signed-off-by: Stephan Linz <linz@li-pro.net> > >>--- > >> Documentation/devicetree/bindings/leds/common.txt | 2 +- > >> Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- > >> Documentation/laptops/asus-laptop.txt | 2 +- > >> Documentation/leds/leds-class.txt | 2 +- > >> 4 files changed, 4 insertions(+), 4 deletions(-) > >> > >>diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > >>index af10678..1e97169 100644 > >>--- a/Documentation/devicetree/bindings/leds/common.txt > >>+++ b/Documentation/devicetree/bindings/leds/common.txt > >>@@ -26,7 +26,7 @@ Optional properties for child nodes: > >> "default-on" - LED will turn on (but for leds-gpio see "default-state" > >> property in Documentation/devicetree/bindings/gpio/led.txt) > >> "heartbeat" - LED "double" flashes at a load average based rate > >>- "ide-disk" - LED indicates disk activity > >>+ "disk-activity" - LED indicates disk activity > >> "timer" - LED flashes at a fixed, configurable rate > > > >We should not break the binding. > > > >Code must continue to support "ide-disk", though we can mark it > >deprecated in the binding documentation, and update the in-kernel dts > >files to use "disk-activity". > > The code in the version 4 of the patchset supports also "ide-disk". Ah, sorry, I missed v4. > Stephan, could you send a new version of this patch, with preserved > "ide-disk" property, marked as deprecated? With that, feel free to add: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark.
[toc] | [prev] | [next] | [standalone]
| From | Stephan Linz <linz@li-pro.net> |
|---|---|
| Date | 2016-06-22 18:10 +0200 |
| Message-ID | <rMST0-5Fj-41@gated-at.bofh.it> |
| In reply to | #1428533 |
[Multipart message — attachments visible in raw view] — view raw
Hi Jacek, Am 22.06.2016 um 09:55 schrieb Jacek Anaszewski: > On 06/21/2016 05:05 PM, Mark Rutland wrote: >> On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: >>> Cc: Joseph Jezak <josejx@gentoo.org> >>> Cc: Nico Macrionitis <acrux@cruxppc.org> >>> Cc: Jörg Sommer <joerg@alea.gnuu.de> >>> Signed-off-by: Stephan Linz <linz@li-pro.net> >>> --- >>> Documentation/devicetree/bindings/leds/common.txt | 2 +- >>> Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- >>> Documentation/laptops/asus-laptop.txt | 2 +- >>> Documentation/leds/leds-class.txt | 2 +- >>> 4 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/common.txt >>> b/Documentation/devicetree/bindings/leds/common.txt >>> index af10678..1e97169 100644 >>> --- a/Documentation/devicetree/bindings/leds/common.txt >>> +++ b/Documentation/devicetree/bindings/leds/common.txt >>> @@ -26,7 +26,7 @@ Optional properties for child nodes: >>> "default-on" - LED will turn on (but for leds-gpio see >>> "default-state" >>> property in >>> Documentation/devicetree/bindings/gpio/led.txt) >>> "heartbeat" - LED "double" flashes at a load average based rate >>> - "ide-disk" - LED indicates disk activity >>> + "disk-activity" - LED indicates disk activity >>> "timer" - LED flashes at a fixed, configurable rate >> >> We should not break the binding. >> >> Code must continue to support "ide-disk", though we can mark it >> deprecated in the binding documentation, and update the in-kernel dts >> files to use "disk-activity". > > The code in the version 4 of the patchset supports also "ide-disk". > > Stephan, could you send a new version of this patch, with preserved > "ide-disk" property, marked as deprecated? Yes, I can. I'll submit a new v5 patch set. You can pick out then the right patch for the LED for-next branch, okay? br, Stephan >
[toc] | [prev] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-06-23 08:50 +0200 |
| Message-ID | <rN6CB-6aT-3@gated-at.bofh.it> |
| In reply to | #1428937 |
On 06/22/2016 06:05 PM, Stephan Linz wrote: > Hi Jacek, > > Am 22.06.2016 um 09:55 schrieb Jacek Anaszewski: >> On 06/21/2016 05:05 PM, Mark Rutland wrote: >>> On Thu, Jun 09, 2016 at 12:29:37AM +0200, Stephan Linz wrote: >>>> Cc: Joseph Jezak <josejx@gentoo.org> >>>> Cc: Nico Macrionitis <acrux@cruxppc.org> >>>> Cc: Jörg Sommer <joerg@alea.gnuu.de> >>>> Signed-off-by: Stephan Linz <linz@li-pro.net> >>>> --- >>>> Documentation/devicetree/bindings/leds/common.txt | 2 +- >>>> Documentation/devicetree/bindings/leds/leds-gpio.txt | 2 +- >>>> Documentation/laptops/asus-laptop.txt | 2 +- >>>> Documentation/leds/leds-class.txt | 2 +- >>>> 4 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/leds/common.txt >>>> b/Documentation/devicetree/bindings/leds/common.txt >>>> index af10678..1e97169 100644 >>>> --- a/Documentation/devicetree/bindings/leds/common.txt >>>> +++ b/Documentation/devicetree/bindings/leds/common.txt >>>> @@ -26,7 +26,7 @@ Optional properties for child nodes: >>>> "default-on" - LED will turn on (but for leds-gpio see >>>> "default-state" >>>> property in >>>> Documentation/devicetree/bindings/gpio/led.txt) >>>> "heartbeat" - LED "double" flashes at a load average based rate >>>> - "ide-disk" - LED indicates disk activity >>>> + "disk-activity" - LED indicates disk activity >>>> "timer" - LED flashes at a fixed, configurable rate >>> >>> We should not break the binding. >>> >>> Code must continue to support "ide-disk", though we can mark it >>> deprecated in the binding documentation, and update the in-kernel dts >>> files to use "disk-activity". >> >> The code in the version 4 of the patchset supports also "ide-disk". >> >> Stephan, could you send a new version of this patch, with preserved >> "ide-disk" property, marked as deprecated? > > Yes, I can. I'll submit a new v5 patch set. You can pick out then the > right patch for the LED for-next branch, okay? You don't need to submit whole patch set, only the affected patch. -- Best regards, Jacek Anaszewski
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web