Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428241 > unrolled thread

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW  functions "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2016-06-22 00:40 +0200
    RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW  functions "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-06-22 01:20 +0200
      Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW  functions Mark Brown <broonie@kernel.org> - 2016-06-22 02:40 +0200
        Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-22 03:10 +0200
          Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW  functions Mark Brown <broonie@kernel.org> - 2016-06-23 12:10 +0200
            Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-23 15:00 +0200

#1428241 — Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

On 6/21/2016 7:50 PM, Adam Thomson wrote:
> This patch set converts the da7219 codec driver to use device/fwnode functions
> to access properties, instead of the DT only of_* functions, allowing ACPI
> to be used as well.
>
> The DT bindings for da7219 have a device node for the main codec properties,
> and a named child node (da7219_aad), which contains all of the accessory
> detection related properties for the device. ACPI also supports this kind of
> FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> added to take make use of this in driver code.
>
> The first patch adds functions to allow searching for a named child node of a
> device, for both DT and ACPI, and the second patch updates the codec driver to
> use the standard device/fwnode calls, including this new function.
>
> These changes are based on the v4.7-rc4 kernel.
>
> Changes in v4:
>   - Rebase to v4.7-rc4
>   - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
>
> Changes in v3:
>   - Use of_node_cmp() in device_get_named_child_node() to match DT node.
>
> Changes in v2:
>   - Rebase to v4.7-rc1
>   - Small updates to codec patch based on previous reviewer comments
>
> Adam Thomson (2):
>    device property: Add function to search for named child of device
>    ASoC: da7219: Convert driver to use generic device/fwnode functions
>
>   drivers/base/property.c       |  28 ++++++++++++
>   include/acpi/acpi_bus.h       |   7 +++
>   include/linux/acpi.h          |   6 +++
>   include/linux/of.h            |  14 +++---
>   include/linux/property.h      |   3 ++
>   sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++---------------------
>   sound/soc/codecs/da7219.c     |  34 +++++++-------
>   7 files changed, 119 insertions(+), 76 deletions(-)
>
> --
> 1.9.3
>
I'm fine with the first patch and the second one carries a couple of 
ACKs already, so do you want me to apply them both?

[toc] | [next] | [standalone]

#1428259

On 21 June 2016 23:30, Rafael J. Wysocki wrote:

> > This patch set converts the da7219 codec driver to use device/fwnode functions
> > to access properties, instead of the DT only of_* functions, allowing ACPI
> > to be used as well.
> >
> > The DT bindings for da7219 have a device node for the main codec properties,
> > and a named child node (da7219_aad), which contains all of the accessory
> > detection related properties for the device. ACPI also supports this kind of
> > FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> > added to take make use of this in driver code.
> >
> > The first patch adds functions to allow searching for a named child node of a
> > device, for both DT and ACPI, and the second patch updates the codec driver to
> > use the standard device/fwnode calls, including this new function.
> >
> > These changes are based on the v4.7-rc4 kernel.
> >
> > Changes in v4:
> >   - Rebase to v4.7-rc4
> >   - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
> >
> > Changes in v3:
> >   - Use of_node_cmp() in device_get_named_child_node() to match DT node.
> >
> > Changes in v2:
> >   - Rebase to v4.7-rc1
> >   - Small updates to codec patch based on previous reviewer comments
> >
> > Adam Thomson (2):
> >    device property: Add function to search for named child of device
> >    ASoC: da7219: Convert driver to use generic device/fwnode functions
> >
> >   drivers/base/property.c       |  28 ++++++++++++
> >   include/acpi/acpi_bus.h       |   7 +++
> >   include/linux/acpi.h          |   6 +++
> >   include/linux/of.h            |  14 +++---
> >   include/linux/property.h      |   3 ++
> >   sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++--------------------
> -
> >   sound/soc/codecs/da7219.c     |  34 +++++++-------
> >   7 files changed, 119 insertions(+), 76 deletions(-)
> >
> > --
> > 1.9.3
> >
> I'm fine with the first patch and the second one carries a couple of
> ACKs already, so do you want me to apply them both?

Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
though before we can proceed.

[toc] | [prev] | [next] | [standalone]

#1428282

[Multipart message — attachments visible in raw view] — view raw

On Tue, Jun 21, 2016 at 10:54:39PM +0000, Opensource [Adam Thomson] wrote:
> On 21 June 2016 23:30, Rafael J. Wysocki wrote:

> > I'm fine with the first patch and the second one carries a couple of
> > ACKs already, so do you want me to apply them both?

None of whom are from anyone who works on the subsystem at all!  I've
not looked at the patch yet.

> Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
> though before we can proceed.

Probably the easiest thing would be a tag for the core change that I can
pull.

[toc] | [prev] | [next] | [standalone]

#1428300 — Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 21, 2016 at 10:54:39PM +0000, Opensource [Adam Thomson] wrote:
>> On 21 June 2016 23:30, Rafael J. Wysocki wrote:
>
>> > I'm fine with the first patch and the second one carries a couple of
>> > ACKs already, so do you want me to apply them both?
>
> None of whom are from anyone who works on the subsystem at all!  I've
> not looked at the patch yet.
>
>> Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
>> though before we can proceed.
>
> Probably the easiest thing would be a tag for the core change that I can
> pull.

Or you can apply them both if that helps (please consider the first
one as ACKed in that case).

[toc] | [prev] | [next] | [standalone]

#1429654

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jun 22, 2016 at 03:05:26AM +0200, Rafael J. Wysocki wrote:
> On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:

> > Probably the easiest thing would be a tag for the core change that I can
> > pull.

> Or you can apply them both if that helps (please consider the first
> one as ACKed in that case).

That works too, if I do that I'll make a tag in case it needs to get
pulled elsewhere.

[toc] | [prev] | [next] | [standalone]

#1429785 — Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

On Thu, Jun 23, 2016 at 12:01 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 22, 2016 at 03:05:26AM +0200, Rafael J. Wysocki wrote:
>> On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:
>
>> > Probably the easiest thing would be a tag for the core change that I can
>> > pull.
>
>> Or you can apply them both if that helps (please consider the first
>> one as ACKed in that case).
>
> That works too, if I do that I'll make a tag in case it needs to get
> pulled elsewhere.

Sounds good, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web