Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426709 > unrolled thread

Re: [PATCH v2] staging: esp8089: add new driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] staging: esp8089: add new driver Greg KH <gregkh@linuxfoundation.org> - 2016-06-20 17:50 +0200
    Re: [PATCH v2] staging: esp8089: add new driver Greg KH <gregkh@linuxfoundation.org> - 2016-06-21 17:30 +0200

#1426709 — Re: [PATCH v2] staging: esp8089: add new driver

On Sun, Jun 19, 2016 at 08:33:48PM +0800, Icenowy Zheng wrote:
> This commit adds Espressif ESP8089 driver, the SDIO version.
> 
> ESP8089 is a 802.11b/g/n card with SDIO/SPI interface. It is usually used in
> low-price tablets with Allwiner or RockChip SoCs.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Why is this driver being sent for the staging tree?  What is wrong with
it that it can't go into the "proper" place in the kernel right now?

And you need a TODO file in your driver's directory before I can take
this as well.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1427876

On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> I cannot promise the code style (although I did indent -kr -i8).
> I cannot also promise the effect.

I don't understand this at all, sorry.

Why should we accept this driver?  Who is going to maintain it?  What
needs to be done to it?

And why are you top-posting?  :)

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web