Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426601 > unrolled thread

Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

Started byMichal Marek <mmarek@suse.com>
First post2016-06-20 15:30 +0200
Last post2016-06-21 14:30 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues Michal Marek <mmarek@suse.com> - 2016-06-20 15:30 +0200
    Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues Julia Lawall <julia.lawall@lip6.fr> - 2016-06-20 22:30 +0200
      Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues Michal Marek <mmarek@suse.com> - 2016-06-21 12:10 +0200
        Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 13:40 +0200
        Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues Yann Droneaud <ydroneaud@opteya.com> - 2016-06-21 14:30 +0200

#1426601 — Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues

FromMichal Marek <mmarek@suse.com>
Date2016-06-20 15:30 +0200
SubjectRe: [PATCH v2 1/3] coccinelle: also catch kzfree() issues
Message-ID<rM7r4-jP-11@gated-at.bofh.it>
On 2016-05-23 17:18, Julia Lawall wrote:
> 
> 
> On Mon, 23 May 2016, Yann Droneaud wrote:
> 
>> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
>> kfree() is no more the only function to be considered:
>> kzfree() should be recognized too.
>>
>> In particular, kzfree() must not be called on memory
>> allocated through devm_*() functions.
>>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Hi Julia,

does your ACK apply to the other two patches as well?

Thanks,
Michal

[toc] | [next] | [standalone]

#1427017

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-06-20 22:30 +0200
Message-ID<rMdZw-4vT-15@gated-at.bofh.it>
In reply to#1426601

On Mon, 20 Jun 2016, Michal Marek wrote:

> On 2016-05-23 17:18, Julia Lawall wrote:
> > 
> > 
> > On Mon, 23 May 2016, Yann Droneaud wrote:
> > 
> >> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
> >> kfree() is no more the only function to be considered:
> >> kzfree() should be recognized too.
> >>
> >> In particular, kzfree() must not be called on memory
> >> allocated through devm_*() functions.
> >>
> >> Cc: Johannes Weiner <hannes@cmpxchg.org>
> >> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > 
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> Hi Julia,
> 
> does your ACK apply to the other two patches as well?

Sorry, I seem to have missed the other two.  I have reviewed them now, and 
the ack applies to all three.  Thanks for checking on it.

julia

[toc] | [prev] | [next] | [standalone]

#1427544

FromMichal Marek <mmarek@suse.com>
Date2016-06-21 12:10 +0200
Message-ID<rMqN4-4mp-71@gated-at.bofh.it>
In reply to#1427017
Dne 20.6.2016 v 22:21 Julia Lawall napsal(a):
> 
> 
> On Mon, 20 Jun 2016, Michal Marek wrote:
> 
>> On 2016-05-23 17:18, Julia Lawall wrote:
>>>
>>>
>>> On Mon, 23 May 2016, Yann Droneaud wrote:
>>>
>>>> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
>>>> kfree() is no more the only function to be considered:
>>>> kzfree() should be recognized too.
>>>>
>>>> In particular, kzfree() must not be called on memory
>>>> allocated through devm_*() functions.
>>>>
>>>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>>>> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
>>>
>>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> Hi Julia,
>>
>> does your ACK apply to the other two patches as well?
> 
> Sorry, I seem to have missed the other two.  I have reviewed them now, and 
> the ack applies to all three.  Thanks for checking on it.

Np. Applied to kbuild.git#misc now.

Michal

[toc] | [prev] | [next] | [standalone]

#1427631

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-06-21 13:40 +0200
Message-ID<rMsc9-5dO-1@gated-at.bofh.it>
In reply to#1427544

[Multipart message — attachments visible in raw view] — view raw

On Tue, 21 Jun 2016, Yann Droneaud wrote:

> Hi,
>
> Le mardi 21 juin 2016 à 11:43 +0200, Michal Marek a écrit :
> > Dne 20.6.2016 v 22:21 Julia Lawall napsal(a):
> > > On Mon, 20 Jun 2016, Michal Marek wrote:
> > > On 2016-05-23 17:18, Julia Lawall wrote:
> > > > > On Mon, 23 May 2016, Yann Droneaud wrote:
> > > > >
> > > > > > Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
> > > > > > kfree() is no more the only function to be considered:
> > > > > > kzfree() should be recognized too.
> > > > > >
> > > > > > In particular, kzfree() must not be called on memory
> > > > > > allocated through devm_*() functions.
> > > > > >
> > > > > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > > > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > > > >
> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > > >
> > > > Hi Julia,
> > > >
> > > > does your ACK apply to the other two patches as well?
> > >
> > > Sorry, I seem to have missed the other two.  I have reviewed them
> > > now, and the ack applies to all three.  Thanks for checking on it.
> >
>
> Back in February, those two other patches were already Acked-by:
>
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161818100.2685@hadrien
> http://lkml.kernel.org/r/alpine.DEB.2.10.1602161819340.2685@hadrien
>
> I've (re)sent them with added Acked-by:, and thought it would not
> require further Acked-by:.
>
> Anyway, this one was new and required proper review. Thanks a lot.

Thanks for the reminder.  Since they are comitted now, things are going in
the right direction.

julia

[toc] | [prev] | [next] | [standalone]

#1427700

FromYann Droneaud <ydroneaud@opteya.com>
Date2016-06-21 14:30 +0200
Message-ID<rMsc9-5dO-3@gated-at.bofh.it>
In reply to#1427544
Hi,

Le mardi 21 juin 2016 à 11:43 +0200, Michal Marek a écrit :
> Dne 20.6.2016 v 22:21 Julia Lawall napsal(a):
> > On Mon, 20 Jun 2016, Michal Marek wrote:
> > On 2016-05-23 17:18, Julia Lawall wrote:
> > > > On Mon, 23 May 2016, Yann Droneaud wrote:
> > > > 
> > > > > Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
> > > > > kfree() is no more the only function to be considered:
> > > > > kzfree() should be recognized too.
> > > > > 
> > > > > In particular, kzfree() must not be called on memory
> > > > > allocated through devm_*() functions.
> > > > > 
> > > > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> > > > 
> > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > > 
> > > Hi Julia,
> > > 
> > > does your ACK apply to the other two patches as well?
> > 
> > Sorry, I seem to have missed the other two.  I have reviewed them
> > now, and the ack applies to all three.  Thanks for checking on it.
> 

Back in February, those two other patches were already Acked-by:

http://lkml.kernel.org/r/alpine.DEB.2.10.1602161818100.2685@hadrien
http://lkml.kernel.org/r/alpine.DEB.2.10.1602161819340.2685@hadrien

I've (re)sent them with added Acked-by:, and thought it would not
require further Acked-by:.

Anyway, this one was new and required proper review. Thanks a lot.

> Np. Applied to kbuild.git#misc now.
> 

Thanks a lot.

-- 
Yann Droneaud
OPTEYA

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web