Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423825 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-06-16 11:10 +0200 |
| Last post | 2016-06-20 13:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] crypto: caam: fix misspelled upper_32_bits Arnd Bergmann <arnd@arndb.de> - 2016-06-16 11:10 +0200
Re: [PATCH] crypto: caam: fix misspelled upper_32_bits Horia Ioan Geanta Neag <horia.geanta@nxp.com> - 2016-06-16 13:10 +0200
Re: [PATCH] crypto: caam: fix misspelled upper_32_bits Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-20 13:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-16 11:10 +0200 |
| Subject | [PATCH] crypto: caam: fix misspelled upper_32_bits |
| Message-ID | <rKBtf-6qC-11@gated-at.bofh.it> |
An endianess fix mistakenly used higher_32_bits() instead of
upper_32_bits(), and that doesn't exist:
drivers/crypto/caam/desc_constr.h: In function 'append_ptr':
drivers/crypto/caam/desc_constr.h:84:75: error: implicit declaration of function 'higher_32_bits' [-Werror=implicit-function-declaration]
*offset = cpu_to_caam_dma(ptr);
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 261ea058f016 ("crypto: caam - handle core endianness != caam endianness")
---
drivers/crypto/caam/regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h
index 8c766cf9202c..b3c5016f6458 100644
--- a/drivers/crypto/caam/regs.h
+++ b/drivers/crypto/caam/regs.h
@@ -183,10 +183,10 @@ static inline u64 rd_reg64(void __iomem *reg)
#ifdef CONFIG_SOC_IMX7D
#define cpu_to_caam_dma(value) \
(((u64)cpu_to_caam32(lower_32_bits(value)) << 32) | \
- (u64)cpu_to_caam32(higher_32_bits(value)))
+ (u64)cpu_to_caam32(upper_32_bits(value)))
#define caam_dma_to_cpu(value) \
(((u64)caam32_to_cpu(lower_32_bits(value)) << 32) | \
- (u64)caam32_to_cpu(higher_32_bits(value)))
+ (u64)caam32_to_cpu(upper_32_bits(value)))
#else
#define cpu_to_caam_dma(value) cpu_to_caam64(value)
#define caam_dma_to_cpu(value) caam64_to_cpu(value)
--
2.9.0
[toc] | [next] | [standalone]
| From | Horia Ioan Geanta Neag <horia.geanta@nxp.com> |
|---|---|
| Date | 2016-06-16 13:10 +0200 |
| Message-ID | <rKDlo-7DU-37@gated-at.bofh.it> |
| In reply to | #1423825 |
On 6/16/2016 12:04 PM, Arnd Bergmann wrote:
> An endianess fix mistakenly used higher_32_bits() instead of
> upper_32_bits(), and that doesn't exist:
>
> drivers/crypto/caam/desc_constr.h: In function 'append_ptr':
> drivers/crypto/caam/desc_constr.h:84:75: error: implicit declaration of function 'higher_32_bits' [-Werror=implicit-function-declaration]
> *offset = cpu_to_caam_dma(ptr);
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 261ea058f016 ("crypto: caam - handle core endianness != caam endianness")
Oops... thanks Arnd!
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
> ---
> drivers/crypto/caam/regs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/caam/regs.h b/drivers/crypto/caam/regs.h
> index 8c766cf9202c..b3c5016f6458 100644
> --- a/drivers/crypto/caam/regs.h
> +++ b/drivers/crypto/caam/regs.h
> @@ -183,10 +183,10 @@ static inline u64 rd_reg64(void __iomem *reg)
> #ifdef CONFIG_SOC_IMX7D
> #define cpu_to_caam_dma(value) \
> (((u64)cpu_to_caam32(lower_32_bits(value)) << 32) | \
> - (u64)cpu_to_caam32(higher_32_bits(value)))
> + (u64)cpu_to_caam32(upper_32_bits(value)))
> #define caam_dma_to_cpu(value) \
> (((u64)caam32_to_cpu(lower_32_bits(value)) << 32) | \
> - (u64)caam32_to_cpu(higher_32_bits(value)))
> + (u64)caam32_to_cpu(upper_32_bits(value)))
> #else
> #define cpu_to_caam_dma(value) cpu_to_caam64(value)
> #define caam_dma_to_cpu(value) caam64_to_cpu(value)
>
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-06-20 13:40 +0200 |
| Message-ID | <rM5IC-7CS-3@gated-at.bofh.it> |
| In reply to | #1423825 |
On Thu, Jun 16, 2016 at 11:05:46AM +0200, Arnd Bergmann wrote:
> An endianess fix mistakenly used higher_32_bits() instead of
> upper_32_bits(), and that doesn't exist:
>
> drivers/crypto/caam/desc_constr.h: In function 'append_ptr':
> drivers/crypto/caam/desc_constr.h:84:75: error: implicit declaration of function 'higher_32_bits' [-Werror=implicit-function-declaration]
> *offset = cpu_to_caam_dma(ptr);
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 261ea058f016 ("crypto: caam - handle core endianness != caam endianness")
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web